You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by "dsoumis (via GitHub)" <gi...@apache.org> on 2026/03/27 14:59:23 UTC

[PR] Add various tests [tomcat]

dsoumis opened a new pull request, #969:
URL: https://github.com/apache/tomcat/pull/969

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Re: [PR] Add various tests [tomcat]

Posted by "dsoumis (via GitHub)" <gi...@apache.org>.
dsoumis commented on PR #969:
URL: https://github.com/apache/tomcat/pull/969#issuecomment-4143837238

   > I'm not a big fan of adding the dependency to the main TesterSupport class. Maybe move it somewhere else. Also usually we use static certificates but of course the strategy doesn't scale indefinitely.
   
   I was thinking that would be beneficial if we had a certificate generation method programmatically in the main helper class. The reason I didn't use a static certificate for the test, was exactly this; the ability to create one programmatically through BouncyCastle and avoid adding extra resources to the repo.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Re: [PR] Add various tests [tomcat]

Posted by "rmaucher (via GitHub)" <gi...@apache.org>.
rmaucher commented on PR #969:
URL: https://github.com/apache/tomcat/pull/969#issuecomment-4143919721

   Maybe. Is it fast ?
   OTOH, it will work without the dependency if the code is not used at all (= test is skipped).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Re: [PR] Add various tests [tomcat]

Posted by "rmaucher (via GitHub)" <gi...@apache.org>.
rmaucher commented on PR #969:
URL: https://github.com/apache/tomcat/pull/969#issuecomment-4143334454

   I'm not a big fan of adding the dependency to the main TesterSupport class. Maybe move it somewhere else.
   Also usually we use static certificates but of course the strategy doesn't scale indefinitely.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Re: [PR] Add various tests [tomcat]

Posted by "dsoumis (via GitHub)" <gi...@apache.org>.
dsoumis commented on PR #969:
URL: https://github.com/apache/tomcat/pull/969#issuecomment-4143978050

   Definitely not slow.
   I see the point, I will create a new class with that utility so the rest of the tests can be ran independently.  


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Re: [PR] Add various tests [tomcat]

Posted by "dsoumis (via GitHub)" <gi...@apache.org>.
dsoumis merged PR #969:
URL: https://github.com/apache/tomcat/pull/969


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org