You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@netbeans.apache.org by "tmysik (via GitHub)" <gi...@apache.org> on 2023/04/20 08:24:38 UTC

[GitHub] [netbeans] tmysik commented on pull request #5853: Fix for PHPUnit 10 #5790

tmysik commented on PR #5853:
URL: https://github.com/apache/netbeans/pull/5853#issuecomment-1515926966

   Overall looks good to me. Here are my notes:
   
   - cannot we use the PHPUnit way also for older versions of PHPUnit? Maybe we could avoid the PHPUnit version selection at all?
   - cannot we detect what version of PHPUnit is used? I mean, some _cheap_ way, like existence of some file inside PHPUnit directory (not so nice but could work)
   - cannot we improve error message so user knows what to do if the running of the tests does not work? Something like "Verify PHPUnit version in the Project Properties dialog"
   
   Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists