You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@kafka.apache.org by Joe Stein <cr...@gmail.com> on 2013/11/21 01:00:15 UTC

Review Request 15744: Patch for KAFKA-1133

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15744/
-----------------------------------------------------------

Review request for kafka.


Bugs: KAFKA-1133
    https://issues.apache.org/jira/browse/KAFKA-1133


Repository: kafka


Description
-------

KAFKA-1133 LICENSE and NOTICE files need to get into META-INF when jars are built before they're signed for publishing to maven


Diffs
-----

  project/Build.scala 500040ba9e69b6f76f4655ce3df9598404737008 

Diff: https://reviews.apache.org/r/15744/diff/


Testing
-------


Thanks,

Joe Stein

Re: Review Request 15744: Patch for KAFKA-1133

Posted by Joel Koshy <jj...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15744/#review29206
-----------------------------------------------------------

Ship it!


- Joel Koshy


On Nov. 21, 2013, midnight, Joe Stein wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15744/
> -----------------------------------------------------------
> 
> (Updated Nov. 21, 2013, midnight)
> 
> 
> Review request for kafka.
> 
> 
> Bugs: KAFKA-1133
>     https://issues.apache.org/jira/browse/KAFKA-1133
> 
> 
> Repository: kafka
> 
> 
> Description
> -------
> 
> KAFKA-1133 LICENSE and NOTICE files need to get into META-INF when jars are built before they're signed for publishing to maven
> 
> 
> Diffs
> -----
> 
>   project/Build.scala 500040ba9e69b6f76f4655ce3df9598404737008 
> 
> Diff: https://reviews.apache.org/r/15744/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Joe Stein
> 
>