You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by da...@apache.org on 2019/12/07 20:54:22 UTC
[camel] 06/08: CAMEL-14263: camel-smpp should use source code
generated configurer to avoid reflection configuration.
This is an automated email from the ASF dual-hosted git repository.
davsclaus pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/camel.git
commit 42202212c922b9ea87f629f28ff7a3f425bb74ee
Author: Claus Ibsen <cl...@gmail.com>
AuthorDate: Sat Dec 7 21:33:05 2019 +0100
CAMEL-14263: camel-smpp should use source code generated configurer to avoid reflection configuration.
---
.../apache/camel/component/smpp/SmppComponent.java | 2 --
.../camel/component/smpp/SmppComponentTest.java | 25 ++++++----------------
2 files changed, 7 insertions(+), 20 deletions(-)
diff --git a/components/camel-smpp/src/main/java/org/apache/camel/component/smpp/SmppComponent.java b/components/camel-smpp/src/main/java/org/apache/camel/component/smpp/SmppComponent.java
index 5959216..f7f17fc 100644
--- a/components/camel-smpp/src/main/java/org/apache/camel/component/smpp/SmppComponent.java
+++ b/components/camel-smpp/src/main/java/org/apache/camel/component/smpp/SmppComponent.java
@@ -52,9 +52,7 @@ public class SmppComponent extends DefaultComponent {
// create a copy of the configuration as other endpoints can adjust their copy as well
SmppConfiguration config = this.configuration.copy();
-
config.configureFromURI(new URI(uri));
- setProperties(config, parameters);
SmppEndpoint answer = new SmppEndpoint(uri, this, config);
setProperties(answer, parameters);
diff --git a/components/camel-smpp/src/test/java/org/apache/camel/component/smpp/SmppComponentTest.java b/components/camel-smpp/src/test/java/org/apache/camel/component/smpp/SmppComponentTest.java
index fba696d..f246754 100644
--- a/components/camel-smpp/src/test/java/org/apache/camel/component/smpp/SmppComponentTest.java
+++ b/components/camel-smpp/src/test/java/org/apache/camel/component/smpp/SmppComponentTest.java
@@ -46,7 +46,9 @@ public class SmppComponentTest {
@Before
public void setUp() {
context = new DefaultCamelContext();
+ context.start();
component = new SmppComponent(context);
+ component.start();
}
@Test
@@ -68,12 +70,15 @@ public class SmppComponentTest {
@Test
public void createEndpointStringStringMapShouldReturnASmppEndpoint() throws Exception {
CamelContext context = new DefaultCamelContext();
+ context.start();
component = new SmppComponent(context);
+ component.start();
+
Map<String, String> parameters = new HashMap<>();
parameters.put("password", "secret");
Endpoint endpoint = component.createEndpoint("smpp://smppclient@localhost:2775", "?password=secret", parameters);
SmppEndpoint smppEndpoint = (SmppEndpoint) endpoint;
-
+
assertEquals("smpp://smppclient@localhost:2775", smppEndpoint.getEndpointUri());
assertEquals("smpp://smppclient@localhost:2775", smppEndpoint.getEndpointKey());
assertSame(component, smppEndpoint.getComponent());
@@ -87,8 +92,6 @@ public class SmppComponentTest {
@Test
public void createEndpointStringStringMapShouldReturnASmppsEndpoint() throws Exception {
- CamelContext context = new DefaultCamelContext();
- component = new SmppComponent(context);
Map<String, String> parameters = new HashMap<>();
parameters.put("password", "secret");
Endpoint endpoint = component.createEndpoint("smpps://smppclient@localhost:2775", "?password=secret", parameters);
@@ -174,19 +177,5 @@ public class SmppComponentTest {
assertSame(configuration, component.getConfiguration());
}
-
- @Test
- public void createEndpointWithSessionStateListener() throws Exception {
- SimpleRegistry registry = new SimpleRegistry();
- registry.bind("sessionStateListener", new SessionStateListener() {
- @Override
- public void onStateChange(SessionState arg0, SessionState arg1, Session arg2) {
- }
- });
- context.setRegistry(registry);
- component = new SmppComponent(context);
- SmppEndpoint endpoint = (SmppEndpoint) component.createEndpoint("smpp://smppclient@localhost:2775?password=password&sessionStateListener=#sessionStateListener");
-
- assertNotNull(endpoint.getConfiguration().getSessionStateListener());
- }
+
}