You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/01/30 13:34:33 UTC
[GitHub] [airflow] potiuk opened a new pull request #21217: Optimize Airflow images for cross-version caching
potiuk opened a new pull request #21217:
URL: https://github.com/apache/airflow/pull/21217
Airflow produces images for multiple versions. Sometimes we
release several images for different versions close to one another
when base Python image is the same. In those cases it would be
great if images for different Airflow versions shared as much
as possible of image layers - the "base" dependencies usually
do not change between versions so two images with the same Python
version could only start differring at the moment we start to
install Airflow for the first time.
This change moves AIRFLOW_VERSION ARG declaration and ENV variable
as possible, so that earlier layers in the Docker images are
the same for different Airflow image versions as long as the base
Python image is the same.
This should decrease significantly used space if someone switches
between two Airflow versions in the same system (for testing
or when doing migration). It also should speed up cache
refreshing and rebuilding and decrease overall size of the cache
used by multiple Airflow Images (especially when we are close
to release (like we are now with Airlfow 2.2.4)
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #21217: Optimize Airflow images for cross-version caching
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #21217:
URL: https://github.com/apache/airflow/pull/21217#issuecomment-1025214017
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #21217: Optimize Airflow images for cross-version caching
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #21217:
URL: https://github.com/apache/airflow/pull/21217
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk closed pull request #21217: Optimize Airflow images for cross-version caching
Posted by GitBox <gi...@apache.org>.
potiuk closed pull request #21217:
URL: https://github.com/apache/airflow/pull/21217
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org