You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-dev@db.apache.org by "Øystein Grøvlen (JIRA)" <ji...@apache.org> on 2007/05/25 15:30:20 UTC

[jira] Created: (DERBY-2695) Add locator support of soft upgrade to 10.3

Add locator support of soft upgrade to 10.3
-------------------------------------------

                 Key: DERBY-2695
                 URL: https://issues.apache.org/jira/browse/DERBY-2695
             Project: Derby
          Issue Type: Sub-task
            Reporter: Øystein Grøvlen
         Assigned To: Øystein Grøvlen




-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (DERBY-2695) Add locator support of soft upgrade to 10.3

Posted by "Øystein Grøvlen (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DERBY-2695?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Øystein Grøvlen updated DERBY-2695:
-----------------------------------

    Derby Info: [Patch Available]

> Add locator support of soft upgrade to 10.3
> -------------------------------------------
>
>                 Key: DERBY-2695
>                 URL: https://issues.apache.org/jira/browse/DERBY-2695
>             Project: Derby
>          Issue Type: Sub-task
>          Components: Network Server
>    Affects Versions: 10.3.0.0
>            Reporter: Øystein Grøvlen
>            Assignee: Øystein Grøvlen
>             Fix For: 10.3.0.0
>
>         Attachments: softupgrade.diff
>
>
> If a database is soft upgraded to 10.3, the stored procedures used by the locator implementation will not be present.  Hence, the server will in this scenario need to ignore requests for locators and send LOB values instead.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (DERBY-2695) Add locator support of soft upgrade to 10.3

Posted by "Øystein Grøvlen (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DERBY-2695?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Øystein Grøvlen updated DERBY-2695:
-----------------------------------

          Component/s: Network Server
          Description: If a database is soft upgraded to 10.3, the stored procedures used by the locator implementation will not be present.  Hence, the server will in this scenario need to ignore requests for locators and send LOB values instead.
    Affects Version/s: 10.3.0.0
        Fix Version/s: 10.3.0.0

> Add locator support of soft upgrade to 10.3
> -------------------------------------------
>
>                 Key: DERBY-2695
>                 URL: https://issues.apache.org/jira/browse/DERBY-2695
>             Project: Derby
>          Issue Type: Sub-task
>          Components: Network Server
>    Affects Versions: 10.3.0.0
>            Reporter: Øystein Grøvlen
>         Assigned To: Øystein Grøvlen
>             Fix For: 10.3.0.0
>
>
> If a database is soft upgraded to 10.3, the stored procedures used by the locator implementation will not be present.  Hence, the server will in this scenario need to ignore requests for locators and send LOB values instead.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (DERBY-2695) Add locator support of soft upgrade to 10.3

Posted by "Øystein Grøvlen (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DERBY-2695?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Øystein Grøvlen updated DERBY-2695:
-----------------------------------

    Attachment: softupgrade.diff

Attached patch handles soft upgrade by not using locators if the stored procedures for locators does not exists.  The following files are changed:

M      java/drda/org/apache/derby/impl/drda/Database.java
    Added method to check whether the necessary stored procedure
    exists in the database.

M      java/drda/org/apache/derby/impl/drda/DRDAConnThread.java
    Ignore requests for locators if locators are not supported.

I am struggling a bit with getting the upgrade tests to test client/server Lobs so I will have to get back to that in a later patch.


> Add locator support of soft upgrade to 10.3
> -------------------------------------------
>
>                 Key: DERBY-2695
>                 URL: https://issues.apache.org/jira/browse/DERBY-2695
>             Project: Derby
>          Issue Type: Sub-task
>          Components: Network Server
>    Affects Versions: 10.3.0.0
>            Reporter: Øystein Grøvlen
>            Assignee: Øystein Grøvlen
>             Fix For: 10.3.0.0
>
>         Attachments: softupgrade.diff
>
>
> If a database is soft upgraded to 10.3, the stored procedures used by the locator implementation will not be present.  Hence, the server will in this scenario need to ignore requests for locators and send LOB values instead.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (DERBY-2695) Add locator support of soft upgrade to 10.3

Posted by "Rick Hillegas (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/DERBY-2695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12500227 ] 

Rick Hillegas commented on DERBY-2695:
--------------------------------------

The patch looks good to me. It might be useful at some point to abstract the DRDA type checking from DRDAConnThread into a isLobLocator() method for use by other code. This might be usable by the DRDA type checking code in, say, NetStatementRequest.calculateOUTOVRLidAndLengthOverrides() and I can imagine that other code might need this check in the future.

The tests ran cleanly for me except for the following error in org.apache.derbyTesting.functionTests.tests.lang.CollationTest2. This error also occurs in a clean client which doesn't have this patch. Committed at subversion revision 542925.

testNorwayCollation(org.apache.derbyTesting.functionTests.tests.lang.CollationTest2)junit.framework.AssertionFailedError: Column value mismatch @ column 'X', row 16:
    Expected: >W?gan<
    Found:    >Waagan<
	at org.apache.derbyTesting.junit.JDBC.assertRowInResultSet(JDBC.java:871)
	at org.apache.derbyTesting.junit.JDBC.assertFullResultSet(JDBC.java:764)
	at org.apache.derbyTesting.junit.JDBC.assertFullResultSet(JDBC.java:702)
	at org.apache.derbyTesting.junit.JDBC.assertFullResultSet(JDBC.java:660)
	at org.apache.derbyTesting.functionTests.tests.lang.CollationTest2.runDerby2670(CollationTest2.java:1766)
	at org.apache.derbyTesting.functionTests.tests.lang.CollationTest2.testNorwayCollation(CollationTest2.java:1929)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
	at org.apache.derbyTesting.junit.BaseTestCase.runBare(BaseTestCase.java:88)
	at junit.extensions.TestDecorator.basicRun(TestDecorator.java:24)
	at junit.extensions.TestSetup$1.protect(TestSetup.java:21)
	at junit.extensions.TestSetup.run(TestSetup.java:25)
	at junit.extensions.TestDecorator.basicRun(TestDecorator.java:24)
	at junit.extensions.TestSetup$1.protect(TestSetup.java:21)
	at junit.extensions.TestSetup.run(TestSetup.java:25)
	at org.apache.derbyTesting.junit.BaseTestSetup.run(BaseTestSetup.java:57)
	at junit.extensions.TestDecorator.basicRun(TestDecorator.java:24)
	at junit.extensions.TestSetup$1.protect(TestSetup.java:21)
	at junit.extensions.TestSetup.run(TestSetup.java:25)
	at junit.extensions.TestDecorator.basicRun(TestDecorator.java:24)
	at junit.extensions.TestSetup$1.protect(TestSetup.java:21)
	at junit.extensions.TestSetup.run(TestSetup.java:25)
	at org.apache.derbyTesting.junit.BaseTestSetup.run(BaseTestSetup.java:57)
	at junit.extensions.TestDecorator.basicRun(TestDecorator.java:24)
	at junit.extensions.TestSetup$1.protect(TestSetup.java:21)
	at junit.extensions.TestSetup.run(TestSetup.java:25)
	at junit.extensions.TestDecorator.basicRun(TestDecorator.java:24)
	at junit.extensions.TestSetup$1.protect(TestSetup.java:21)
	at junit.extensions.TestSetup.run(TestSetup.java:25)
	at org.apache.derbyTesting.junit.BaseTestSetup.run(BaseTestSetup.java:57)
	at junit.extensions.TestDecorator.basicRun(TestDecorator.java:24)
	at junit.extensions.TestSetup$1.protect(TestSetup.java:21)
	at junit.extensions.TestSetup.run(TestSetup.java:25)
	at junit.extensions.TestDecorator.basicRun(TestDecorator.java:24)
	at junit.extensions.TestSetup$1.protect(TestSetup.java:21)
	at junit.extensions.TestSetup.run(TestSetup.java:25)
	at org.apache.derbyTesting.junit.BaseTestSetup.run(BaseTestSetup.java:57)
	at junit.extensions.TestDecorator.basicRun(TestDecorator.java:24)
	at junit.extensions.TestSetup$1.protect(TestSetup.java:21)
	at junit.extensions.TestSetup.run(TestSetup.java:25)
	at junit.extensions.TestDecorator.basicRun(TestDecorator.java:24)
	at junit.extensions.TestSetup$1.protect(TestSetup.java:21)
	at junit.extensions.TestSetup.run(TestSetup.java:25)
	at org.apache.derbyTesting.junit.BaseTestSetup.run(BaseTestSetup.java:57)
	at junit.extensions.TestDecorator.basicRun(TestDecorator.java:24)
	at junit.extensions.TestSetup$1.protect(TestSetup.java:21)
	at junit.extensions.TestSetup.run(TestSetup.java:25)


> Add locator support of soft upgrade to 10.3
> -------------------------------------------
>
>                 Key: DERBY-2695
>                 URL: https://issues.apache.org/jira/browse/DERBY-2695
>             Project: Derby
>          Issue Type: Sub-task
>          Components: Network Server
>    Affects Versions: 10.3.0.0
>            Reporter: Øystein Grøvlen
>            Assignee: Øystein Grøvlen
>             Fix For: 10.3.0.0
>
>         Attachments: softupgrade.diff
>
>
> If a database is soft upgraded to 10.3, the stored procedures used by the locator implementation will not be present.  Hence, the server will in this scenario need to ignore requests for locators and send LOB values instead.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (DERBY-2695) Add locator support of soft upgrade to 10.3

Posted by "Myrna van Lunteren (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DERBY-2695?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Myrna van Lunteren resolved DERBY-2695.
---------------------------------------

    Resolution: Fixed

I'm closing this issue now, because the functionality has gone in, and it's not going to make it into the list of fixed bugs...

> Add locator support of soft upgrade to 10.3
> -------------------------------------------
>
>                 Key: DERBY-2695
>                 URL: https://issues.apache.org/jira/browse/DERBY-2695
>             Project: Derby
>          Issue Type: Sub-task
>          Components: Network Server
>    Affects Versions: 10.3.0.0
>            Reporter: Øystein Grøvlen
>            Assignee: Øystein Grøvlen
>             Fix For: 10.3.0.0
>
>         Attachments: softupgrade.diff
>
>
> If a database is soft upgraded to 10.3, the stored procedures used by the locator implementation will not be present.  Hence, the server will in this scenario need to ignore requests for locators and send LOB values instead.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (DERBY-2695) Add locator support of soft upgrade to 10.3

Posted by "Øystein Grøvlen (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/DERBY-2695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12500359 ] 

Øystein Grøvlen commented on DERBY-2695:
----------------------------------------

Thanks for the commit, Rick.
Good idea to abstract the DRDA type checking.  I will put that on my todo list.


> Add locator support of soft upgrade to 10.3
> -------------------------------------------
>
>                 Key: DERBY-2695
>                 URL: https://issues.apache.org/jira/browse/DERBY-2695
>             Project: Derby
>          Issue Type: Sub-task
>          Components: Network Server
>    Affects Versions: 10.3.0.0
>            Reporter: Øystein Grøvlen
>            Assignee: Øystein Grøvlen
>             Fix For: 10.3.0.0
>
>         Attachments: softupgrade.diff
>
>
> If a database is soft upgraded to 10.3, the stored procedures used by the locator implementation will not be present.  Hence, the server will in this scenario need to ignore requests for locators and send LOB values instead.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (DERBY-2695) Add locator support of soft upgrade to 10.3

Posted by "Myrna van Lunteren (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/DERBY-2695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12502654 ] 

Myrna van Lunteren commented on DERBY-2695:
-------------------------------------------

Is that task necessary/possible for 10.3? Or can we make that task a separate issue for a future release and close this?

> Add locator support of soft upgrade to 10.3
> -------------------------------------------
>
>                 Key: DERBY-2695
>                 URL: https://issues.apache.org/jira/browse/DERBY-2695
>             Project: Derby
>          Issue Type: Sub-task
>          Components: Network Server
>    Affects Versions: 10.3.0.0
>            Reporter: Øystein Grøvlen
>            Assignee: Øystein Grøvlen
>             Fix For: 10.3.0.0
>
>         Attachments: softupgrade.diff
>
>
> If a database is soft upgraded to 10.3, the stored procedures used by the locator implementation will not be present.  Hence, the server will in this scenario need to ignore requests for locators and send LOB values instead.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (DERBY-2695) Add locator support of soft upgrade to 10.3

Posted by "Øystein Grøvlen (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/DERBY-2695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12502734 ] 

Øystein Grøvlen commented on DERBY-2695:
----------------------------------------

The DRDA type checking does not need to be in for 10.3.
However, I plan to do some more testing of soft upgrade before I close this.

> Add locator support of soft upgrade to 10.3
> -------------------------------------------
>
>                 Key: DERBY-2695
>                 URL: https://issues.apache.org/jira/browse/DERBY-2695
>             Project: Derby
>          Issue Type: Sub-task
>          Components: Network Server
>    Affects Versions: 10.3.0.0
>            Reporter: Øystein Grøvlen
>            Assignee: Øystein Grøvlen
>             Fix For: 10.3.0.0
>
>         Attachments: softupgrade.diff
>
>
> If a database is soft upgraded to 10.3, the stored procedures used by the locator implementation will not be present.  Hence, the server will in this scenario need to ignore requests for locators and send LOB values instead.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (DERBY-2695) Add locator support of soft upgrade to 10.3

Posted by "Kathey Marsden (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DERBY-2695?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kathey Marsden updated DERBY-2695:
----------------------------------

    Derby Info:   (was: [Patch Available])

Looks like this patch has already been committed

> Add locator support of soft upgrade to 10.3
> -------------------------------------------
>
>                 Key: DERBY-2695
>                 URL: https://issues.apache.org/jira/browse/DERBY-2695
>             Project: Derby
>          Issue Type: Sub-task
>          Components: Network Server
>    Affects Versions: 10.3.0.0
>            Reporter: Øystein Grøvlen
>            Assignee: Øystein Grøvlen
>             Fix For: 10.3.0.0
>
>         Attachments: softupgrade.diff
>
>
> If a database is soft upgraded to 10.3, the stored procedures used by the locator implementation will not be present.  Hence, the server will in this scenario need to ignore requests for locators and send LOB values instead.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.