You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2021/01/07 13:14:55 UTC

[GitHub] [activemq-nms-api] Havret commented on a change in pull request #17: More async methods added

Havret commented on a change in pull request #17:
URL: https://github.com/apache/activemq-nms-api/pull/17#discussion_r553318852



##########
File path: src/nms-api/IConnection.cs
##########
@@ -95,16 +96,22 @@ public interface IConnection : IDisposable, IStartable, IStoppable
         /// </summary>
         ISession CreateSession();
 
+        Task<ISession> CreateSessionAsync();

Review comment:
       It would be wise to have a CancellationToken as a parameter to all `*Async` methods. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org