You are viewing a plain text version of this content. The canonical link for it is here.
Posted to java-dev@axis.apache.org by "Saminda Wishwajith Abeyruwan (JIRA)" <ji...@apache.org> on 2007/05/07 07:39:15 UTC
[jira] Created: (AXIS2-2642) Inconsistencies in getting engaged
modules
Inconsistencies in getting engaged modules
-------------------------------------------
Key: AXIS2-2642
URL: https://issues.apache.org/jira/browse/AXIS2-2642
Project: Axis 2.0 (Axis2)
Issue Type: Bug
Environment: Any
Reporter: Saminda Wishwajith Abeyruwan
We've came across the following inconsistencies when calling getEngagedModules() method, in
1. AxisOperation
2. AxisService
3. AxisServiceGroup
AxisOperation has,
public Collection getEngagedModules() {...} --> This will give an instance of ArrayList which has AxisModule objects.
AxisService has,
public Collection getEngagedModules() {...} --> This will give an instance of ArrayList which has String objects.
String objects are the names of engaged modules.
AxisServiceGroup has,
public ArrayList getEngagedModules() {...} --> This will give an instance of ArrayList which has String objects.
String objects are the names of engaged modules.
This will lead to difficulties when working with them.
IMHO getEngagedModules() should be an abstract method in AxisDescription;
public List getEngagedModules(),
and should return either AxisModule or Name of the module as String. IMHO AxisModule would be preferable. Thus, others that extend from AxisDecription will be benefited too.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org
[jira] Commented: (AXIS2-2642) Inconsistencies in getting engaged
modules
Posted by "Glen Daniels (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AXIS2-2642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12505476 ]
Glen Daniels commented on AXIS2-2642:
-------------------------------------
First part of this is done - engaged modules are now kept as AxisModules everywhere, not Strings.
Refactoring up to AxisDescription not done yet, but on the way.
> Inconsistencies in getting engaged modules
> -------------------------------------------
>
> Key: AXIS2-2642
> URL: https://issues.apache.org/jira/browse/AXIS2-2642
> Project: Axis 2.0 (Axis2)
> Issue Type: Bug
> Environment: Any
> Reporter: Saminda Wishwajith Abeyruwan
> Assignee: Glen Daniels
> Priority: Blocker
>
> We've came across the following inconsistencies when calling getEngagedModules() method, in
> 1. AxisOperation
> 2. AxisService
> 3. AxisServiceGroup
> AxisOperation has,
> public Collection getEngagedModules() {...} --> This will give an instance of ArrayList which has AxisModule objects.
> AxisService has,
> public Collection getEngagedModules() {...} --> This will give an instance of ArrayList which has String objects.
> String objects are the names of engaged modules.
> AxisServiceGroup has,
> public ArrayList getEngagedModules() {...} --> This will give an instance of ArrayList which has String objects.
> String objects are the names of engaged modules.
> This will lead to difficulties when working with them.
> IMHO getEngagedModules() should be an abstract method in AxisDescription;
> public List getEngagedModules(),
> and should return either AxisModule or Name of the module as String. IMHO AxisModule would be preferable. Thus, others that extend from AxisDecription will be benefited too.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org
[jira] Assigned: (AXIS2-2642) Inconsistencies in getting engaged
modules
Posted by "Jaliya Ekanayake (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AXIS2-2642?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jaliya Ekanayake reassigned AXIS2-2642:
---------------------------------------
Assignee: Jaliya Ekanayake (was: Deepal Jayasinghe)
> Inconsistencies in getting engaged modules
> -------------------------------------------
>
> Key: AXIS2-2642
> URL: https://issues.apache.org/jira/browse/AXIS2-2642
> Project: Axis 2.0 (Axis2)
> Issue Type: Bug
> Environment: Any
> Reporter: Saminda Wishwajith Abeyruwan
> Assignee: Jaliya Ekanayake
> Priority: Blocker
>
> We've came across the following inconsistencies when calling getEngagedModules() method, in
> 1. AxisOperation
> 2. AxisService
> 3. AxisServiceGroup
> AxisOperation has,
> public Collection getEngagedModules() {...} --> This will give an instance of ArrayList which has AxisModule objects.
> AxisService has,
> public Collection getEngagedModules() {...} --> This will give an instance of ArrayList which has String objects.
> String objects are the names of engaged modules.
> AxisServiceGroup has,
> public ArrayList getEngagedModules() {...} --> This will give an instance of ArrayList which has String objects.
> String objects are the names of engaged modules.
> This will lead to difficulties when working with them.
> IMHO getEngagedModules() should be an abstract method in AxisDescription;
> public List getEngagedModules(),
> and should return either AxisModule or Name of the module as String. IMHO AxisModule would be preferable. Thus, others that extend from AxisDecription will be benefited too.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org
[jira] Updated: (AXIS2-2642) Inconsistencies in getting engaged
modules
Posted by "Jaliya Ekanayake (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AXIS2-2642?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jaliya Ekanayake updated AXIS2-2642:
------------------------------------
Comment: was deleted
> Inconsistencies in getting engaged modules
> -------------------------------------------
>
> Key: AXIS2-2642
> URL: https://issues.apache.org/jira/browse/AXIS2-2642
> Project: Axis 2.0 (Axis2)
> Issue Type: Bug
> Environment: Any
> Reporter: Saminda Wishwajith Abeyruwan
> Assignee: Jaliya Ekanayake
> Priority: Blocker
>
> We've came across the following inconsistencies when calling getEngagedModules() method, in
> 1. AxisOperation
> 2. AxisService
> 3. AxisServiceGroup
> AxisOperation has,
> public Collection getEngagedModules() {...} --> This will give an instance of ArrayList which has AxisModule objects.
> AxisService has,
> public Collection getEngagedModules() {...} --> This will give an instance of ArrayList which has String objects.
> String objects are the names of engaged modules.
> AxisServiceGroup has,
> public ArrayList getEngagedModules() {...} --> This will give an instance of ArrayList which has String objects.
> String objects are the names of engaged modules.
> This will lead to difficulties when working with them.
> IMHO getEngagedModules() should be an abstract method in AxisDescription;
> public List getEngagedModules(),
> and should return either AxisModule or Name of the module as String. IMHO AxisModule would be preferable. Thus, others that extend from AxisDecription will be benefited too.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org
[jira] Reopened: (AXIS2-2642) Inconsistencies in getting engaged
modules
Posted by "Jaliya Ekanayake (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AXIS2-2642?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jaliya Ekanayake reopened AXIS2-2642:
-------------------------------------
Better to return module references at all these cases.
> Inconsistencies in getting engaged modules
> -------------------------------------------
>
> Key: AXIS2-2642
> URL: https://issues.apache.org/jira/browse/AXIS2-2642
> Project: Axis 2.0 (Axis2)
> Issue Type: Bug
> Environment: Any
> Reporter: Saminda Wishwajith Abeyruwan
> Assignee: Jaliya Ekanayake
> Priority: Blocker
>
> We've came across the following inconsistencies when calling getEngagedModules() method, in
> 1. AxisOperation
> 2. AxisService
> 3. AxisServiceGroup
> AxisOperation has,
> public Collection getEngagedModules() {...} --> This will give an instance of ArrayList which has AxisModule objects.
> AxisService has,
> public Collection getEngagedModules() {...} --> This will give an instance of ArrayList which has String objects.
> String objects are the names of engaged modules.
> AxisServiceGroup has,
> public ArrayList getEngagedModules() {...} --> This will give an instance of ArrayList which has String objects.
> String objects are the names of engaged modules.
> This will lead to difficulties when working with them.
> IMHO getEngagedModules() should be an abstract method in AxisDescription;
> public List getEngagedModules(),
> and should return either AxisModule or Name of the module as String. IMHO AxisModule would be preferable. Thus, others that extend from AxisDecription will be benefited too.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org
[jira] Commented: (AXIS2-2642) Inconsistencies in getting engaged
modules
Posted by "Jaliya Ekanayake (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AXIS2-2642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12503714 ]
Jaliya Ekanayake commented on AXIS2-2642:
-----------------------------------------
Fixed;
The getEngagedModules() in AxisServiceGroup and AxisService are both renamed to getEngagedModulesNames() to resolve the ambiguity.
AxisServiceGroup's getEngagedModulesNames() is now returning a Collection instead of ArrayList.
We don't need to keep copies of engaged modules in all these places as it is available in AxisConfig.
> Inconsistencies in getting engaged modules
> -------------------------------------------
>
> Key: AXIS2-2642
> URL: https://issues.apache.org/jira/browse/AXIS2-2642
> Project: Axis 2.0 (Axis2)
> Issue Type: Bug
> Environment: Any
> Reporter: Saminda Wishwajith Abeyruwan
> Assignee: Jaliya Ekanayake
> Priority: Blocker
>
> We've came across the following inconsistencies when calling getEngagedModules() method, in
> 1. AxisOperation
> 2. AxisService
> 3. AxisServiceGroup
> AxisOperation has,
> public Collection getEngagedModules() {...} --> This will give an instance of ArrayList which has AxisModule objects.
> AxisService has,
> public Collection getEngagedModules() {...} --> This will give an instance of ArrayList which has String objects.
> String objects are the names of engaged modules.
> AxisServiceGroup has,
> public ArrayList getEngagedModules() {...} --> This will give an instance of ArrayList which has String objects.
> String objects are the names of engaged modules.
> This will lead to difficulties when working with them.
> IMHO getEngagedModules() should be an abstract method in AxisDescription;
> public List getEngagedModules(),
> and should return either AxisModule or Name of the module as String. IMHO AxisModule would be preferable. Thus, others that extend from AxisDecription will be benefited too.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org
[jira] Updated: (AXIS2-2642) Inconsistencies in getting engaged
modules
Posted by "Jaliya Ekanayake (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AXIS2-2642?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jaliya Ekanayake updated AXIS2-2642:
------------------------------------
Priority: Blocker (was: Major)
> Inconsistencies in getting engaged modules
> -------------------------------------------
>
> Key: AXIS2-2642
> URL: https://issues.apache.org/jira/browse/AXIS2-2642
> Project: Axis 2.0 (Axis2)
> Issue Type: Bug
> Environment: Any
> Reporter: Saminda Wishwajith Abeyruwan
> Assignee: Deepal Jayasinghe
> Priority: Blocker
>
> We've came across the following inconsistencies when calling getEngagedModules() method, in
> 1. AxisOperation
> 2. AxisService
> 3. AxisServiceGroup
> AxisOperation has,
> public Collection getEngagedModules() {...} --> This will give an instance of ArrayList which has AxisModule objects.
> AxisService has,
> public Collection getEngagedModules() {...} --> This will give an instance of ArrayList which has String objects.
> String objects are the names of engaged modules.
> AxisServiceGroup has,
> public ArrayList getEngagedModules() {...} --> This will give an instance of ArrayList which has String objects.
> String objects are the names of engaged modules.
> This will lead to difficulties when working with them.
> IMHO getEngagedModules() should be an abstract method in AxisDescription;
> public List getEngagedModules(),
> and should return either AxisModule or Name of the module as String. IMHO AxisModule would be preferable. Thus, others that extend from AxisDecription will be benefited too.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org
[jira] Assigned: (AXIS2-2642) Inconsistencies in getting engaged
modules
Posted by "Deepal Jayasinghe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AXIS2-2642?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Deepal Jayasinghe reassigned AXIS2-2642:
----------------------------------------
Assignee: Deepal Jayasinghe
> Inconsistencies in getting engaged modules
> -------------------------------------------
>
> Key: AXIS2-2642
> URL: https://issues.apache.org/jira/browse/AXIS2-2642
> Project: Axis 2.0 (Axis2)
> Issue Type: Bug
> Environment: Any
> Reporter: Saminda Wishwajith Abeyruwan
> Assignee: Deepal Jayasinghe
>
> We've came across the following inconsistencies when calling getEngagedModules() method, in
> 1. AxisOperation
> 2. AxisService
> 3. AxisServiceGroup
> AxisOperation has,
> public Collection getEngagedModules() {...} --> This will give an instance of ArrayList which has AxisModule objects.
> AxisService has,
> public Collection getEngagedModules() {...} --> This will give an instance of ArrayList which has String objects.
> String objects are the names of engaged modules.
> AxisServiceGroup has,
> public ArrayList getEngagedModules() {...} --> This will give an instance of ArrayList which has String objects.
> String objects are the names of engaged modules.
> This will lead to difficulties when working with them.
> IMHO getEngagedModules() should be an abstract method in AxisDescription;
> public List getEngagedModules(),
> and should return either AxisModule or Name of the module as String. IMHO AxisModule would be preferable. Thus, others that extend from AxisDecription will be benefited too.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org
[jira] Resolved: (AXIS2-2642) Inconsistencies in getting engaged
modules
Posted by "Glen Daniels (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AXIS2-2642?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Glen Daniels resolved AXIS2-2642.
---------------------------------
Resolution: Fixed
Fix Version/s: 1.3
Factored most of the module code up to AxisDescription, which now keeps track of engaged modules, handles engage/disengage, etc. There are now overridable "onEngage()" and "onDisengage()" methods which subclasses use to do individual things (for AxisService, to engage to all operations, etc).
> Inconsistencies in getting engaged modules
> -------------------------------------------
>
> Key: AXIS2-2642
> URL: https://issues.apache.org/jira/browse/AXIS2-2642
> Project: Axis 2.0 (Axis2)
> Issue Type: Bug
> Environment: Any
> Reporter: Saminda Wishwajith Abeyruwan
> Assignee: Glen Daniels
> Priority: Blocker
> Fix For: 1.3
>
>
> We've came across the following inconsistencies when calling getEngagedModules() method, in
> 1. AxisOperation
> 2. AxisService
> 3. AxisServiceGroup
> AxisOperation has,
> public Collection getEngagedModules() {...} --> This will give an instance of ArrayList which has AxisModule objects.
> AxisService has,
> public Collection getEngagedModules() {...} --> This will give an instance of ArrayList which has String objects.
> String objects are the names of engaged modules.
> AxisServiceGroup has,
> public ArrayList getEngagedModules() {...} --> This will give an instance of ArrayList which has String objects.
> String objects are the names of engaged modules.
> This will lead to difficulties when working with them.
> IMHO getEngagedModules() should be an abstract method in AxisDescription;
> public List getEngagedModules(),
> and should return either AxisModule or Name of the module as String. IMHO AxisModule would be preferable. Thus, others that extend from AxisDecription will be benefited too.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org
[jira] Resolved: (AXIS2-2642) Inconsistencies in getting engaged
modules
Posted by "Jaliya Ekanayake (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AXIS2-2642?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jaliya Ekanayake resolved AXIS2-2642.
-------------------------------------
Resolution: Fixed
The getEngagedModules() in AxisServiceGroup and AxisService are both renamed to getEngagedModulesNames() to resolve the ambiguity.
AxisServiceGroup's getEngagedModulesNames() is now returning a Collection instead of ArrayList.
We don't need to keep copies of engaged modules in all these places as it is available in AxisConfig.
> Inconsistencies in getting engaged modules
> -------------------------------------------
>
> Key: AXIS2-2642
> URL: https://issues.apache.org/jira/browse/AXIS2-2642
> Project: Axis 2.0 (Axis2)
> Issue Type: Bug
> Environment: Any
> Reporter: Saminda Wishwajith Abeyruwan
> Assignee: Jaliya Ekanayake
> Priority: Blocker
>
> We've came across the following inconsistencies when calling getEngagedModules() method, in
> 1. AxisOperation
> 2. AxisService
> 3. AxisServiceGroup
> AxisOperation has,
> public Collection getEngagedModules() {...} --> This will give an instance of ArrayList which has AxisModule objects.
> AxisService has,
> public Collection getEngagedModules() {...} --> This will give an instance of ArrayList which has String objects.
> String objects are the names of engaged modules.
> AxisServiceGroup has,
> public ArrayList getEngagedModules() {...} --> This will give an instance of ArrayList which has String objects.
> String objects are the names of engaged modules.
> This will lead to difficulties when working with them.
> IMHO getEngagedModules() should be an abstract method in AxisDescription;
> public List getEngagedModules(),
> and should return either AxisModule or Name of the module as String. IMHO AxisModule would be preferable. Thus, others that extend from AxisDecription will be benefited too.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org
[jira] Assigned: (AXIS2-2642) Inconsistencies in getting engaged
modules
Posted by "Glen Daniels (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AXIS2-2642?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Glen Daniels reassigned AXIS2-2642:
-----------------------------------
Assignee: Glen Daniels (was: Jaliya Ekanayake)
> Inconsistencies in getting engaged modules
> -------------------------------------------
>
> Key: AXIS2-2642
> URL: https://issues.apache.org/jira/browse/AXIS2-2642
> Project: Axis 2.0 (Axis2)
> Issue Type: Bug
> Environment: Any
> Reporter: Saminda Wishwajith Abeyruwan
> Assignee: Glen Daniels
> Priority: Blocker
>
> We've came across the following inconsistencies when calling getEngagedModules() method, in
> 1. AxisOperation
> 2. AxisService
> 3. AxisServiceGroup
> AxisOperation has,
> public Collection getEngagedModules() {...} --> This will give an instance of ArrayList which has AxisModule objects.
> AxisService has,
> public Collection getEngagedModules() {...} --> This will give an instance of ArrayList which has String objects.
> String objects are the names of engaged modules.
> AxisServiceGroup has,
> public ArrayList getEngagedModules() {...} --> This will give an instance of ArrayList which has String objects.
> String objects are the names of engaged modules.
> This will lead to difficulties when working with them.
> IMHO getEngagedModules() should be an abstract method in AxisDescription;
> public List getEngagedModules(),
> and should return either AxisModule or Name of the module as String. IMHO AxisModule would be preferable. Thus, others that extend from AxisDecription will be benefited too.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org