You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-dev@db.apache.org by "Kristian Waagan (JIRA)" <ji...@apache.org> on 2012/05/03 14:34:50 UTC
[jira] [Updated] (DERBY-5740) Remove unsued code in
AlterTableConstantaction.columnDroppedAndTriggerDependencies
[ https://issues.apache.org/jira/browse/DERBY-5740?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kristian Waagan updated DERBY-5740:
-----------------------------------
Attachment: derby-5740-1a-code_removal.diff
Attaching patch 1a.
Both derbyAll and suites.All passed with the patch, which suggests this is indeed unnecessary code and can be removed.
Patch ready for review.
> Remove unsued code in AlterTableConstantaction.columnDroppedAndTriggerDependencies
> ----------------------------------------------------------------------------------
>
> Key: DERBY-5740
> URL: https://issues.apache.org/jira/browse/DERBY-5740
> Project: Derby
> Issue Type: Improvement
> Components: SQL
> Affects Versions: 10.9.0.0
> Reporter: Kristian Waagan
> Priority: Trivial
> Attachments: derby-5740-1a-code_removal.diff
>
>
> The following code is executed, but the results are not used:
> CollectNodesVisitor visitor = new CollectNodesVisitor(ColumnReference.class);
> stmtnode.accept(visitor);
> Vector refs = visitor.getList(); <--- never used
> I plan to remove the code, but just want to record it here in case there are side-effects by using the visitor.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira