You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Suresh Srinivas (JIRA)" <ji...@apache.org> on 2009/05/14 07:42:45 UTC
[jira] Created: (HADOOP-5829) Fix javac warnings
Fix javac warnings
------------------
Key: HADOOP-5829
URL: https://issues.apache.org/jira/browse/HADOOP-5829
Project: Hadoop Core
Issue Type: Bug
Reporter: Suresh Srinivas
Assignee: Suresh Srinivas
Fix For: 0.21.0
Fixing javac warnings found in some of the java files
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5829) Fix javac warnings
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5829?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-5829:
-------------------------------------------
Hadoop Flags: [Reviewed]
Status: Patch Available (was: Open)
+1 patch looks good.
> Fix javac warnings
> ------------------
>
> Key: HADOOP-5829
> URL: https://issues.apache.org/jira/browse/HADOOP-5829
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Fix For: 0.21.0
>
> Attachments: fix_warnings.patch, fix_warnings.patch
>
>
> Fixing javac warnings found in some of the java files
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (HADOOP-5829) Fix javac warnings
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5829?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE resolved HADOOP-5829.
--------------------------------------------
Resolution: Fixed
I have committed this. Thanks, Suresh!
> Fix javac warnings
> ------------------
>
> Key: HADOOP-5829
> URL: https://issues.apache.org/jira/browse/HADOOP-5829
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Fix For: 0.21.0
>
> Attachments: fix_warnings.patch, fix_warnings.patch, fix_warnings.patch
>
>
> Fixing javac warnings found in some of the java files
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5829) Fix javac warnings
Posted by "Suresh Srinivas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5829?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Suresh Srinivas updated HADOOP-5829:
------------------------------------
Attachment: fix_warnings.patch
Old patch was failing to apply to the latest trunk. Here is the updated patch with test-patch results. No tests included as this patch fixes only javac warnings:
[exec] -1 overall.
[exec]
[exec] +1 @author. The patch does not contain any @author tags.
[exec]
[exec] -1 tests included. The patch doesn't appear to include any new or modified tests.
[exec] Please justify why no tests are needed for this patch.
[exec]
[exec] +1 javadoc. The javadoc tool did not generate any warning messages.
[exec]
[exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
[exec]
[exec] +1 findbugs. The patch does not introduce any new Findbugs warnings.
[exec]
[exec] +1 Eclipse classpath. The patch retains Eclipse classpath integrity.
[exec]
[exec] +1 release audit. The applied patch does not increase the total number of release audit warnings.
> Fix javac warnings
> ------------------
>
> Key: HADOOP-5829
> URL: https://issues.apache.org/jira/browse/HADOOP-5829
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Fix For: 0.21.0
>
> Attachments: fix_warnings.patch, fix_warnings.patch, fix_warnings.patch
>
>
> Fixing javac warnings found in some of the java files
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5829) Fix javac warnings
Posted by "Suresh Srinivas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12710570#action_12710570 ]
Suresh Srinivas commented on HADOOP-5829:
-----------------------------------------
Passed unit tests as well
> Fix javac warnings
> ------------------
>
> Key: HADOOP-5829
> URL: https://issues.apache.org/jira/browse/HADOOP-5829
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Fix For: 0.21.0
>
> Attachments: fix_warnings.patch, fix_warnings.patch, fix_warnings.patch
>
>
> Fixing javac warnings found in some of the java files
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5829) Fix javac warnings
Posted by "Suresh Srinivas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5829?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Suresh Srinivas updated HADOOP-5829:
------------------------------------
Attachment: fix_warnings.patch
Here is the new patch that incorporates the change you suggested.
> Fix javac warnings
> ------------------
>
> Key: HADOOP-5829
> URL: https://issues.apache.org/jira/browse/HADOOP-5829
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Fix For: 0.21.0
>
> Attachments: fix_warnings.patch, fix_warnings.patch
>
>
> Fixing javac warnings found in some of the java files
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5829) Fix javac warnings
Posted by "Suresh Srinivas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5829?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Suresh Srinivas updated HADOOP-5829:
------------------------------------
Status: Open (was: Patch Available)
> Fix javac warnings
> ------------------
>
> Key: HADOOP-5829
> URL: https://issues.apache.org/jira/browse/HADOOP-5829
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Fix For: 0.21.0
>
> Attachments: fix_warnings.patch, fix_warnings.patch
>
>
> Fixing javac warnings found in some of the java files
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5829) Fix javac warnings
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5829?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-5829:
-------------------------------------------
Component/s: dfs
How about replace switch-case statement by if-then statements, instead of adding @SuppressWarnings("fallthrough")?
> Fix javac warnings
> ------------------
>
> Key: HADOOP-5829
> URL: https://issues.apache.org/jira/browse/HADOOP-5829
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Fix For: 0.21.0
>
> Attachments: fix_warnings.patch
>
>
> Fixing javac warnings found in some of the java files
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5829) Fix javac warnings
Posted by "Suresh Srinivas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5829?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Suresh Srinivas updated HADOOP-5829:
------------------------------------
Attachment: fix_warnings.patch
> Fix javac warnings
> ------------------
>
> Key: HADOOP-5829
> URL: https://issues.apache.org/jira/browse/HADOOP-5829
> Project: Hadoop Core
> Issue Type: Bug
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Fix For: 0.21.0
>
> Attachments: fix_warnings.patch
>
>
> Fixing javac warnings found in some of the java files
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.