You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@james.apache.org by "chibenwa (via GitHub)" <gi...@apache.org> on 2024/01/22 15:41:47 UTC

[PR] JAMES-3961 Switch to Java 21 (Polished) [james-project]

chibenwa opened a new pull request, #1939:
URL: https://github.com/apache/james-project/pull/1939

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org


Re: [PR] JAMES-3961 Switch to Java 21 (Polished) [james-project]

Posted by "quantranhong1999 (via GitHub)" <gi...@apache.org>.
quantranhong1999 commented on code in PR #1939:
URL: https://github.com/apache/james-project/pull/1939#discussion_r1462667832


##########
pom.xml:
##########
@@ -2819,7 +2819,7 @@
             <dependency>
                 <groupId>org.mockito</groupId>
                 <artifactId>mockito-inline</artifactId>
-                <version>${mockito.version}</version>
+                <version>5.2.0</version>

Review Comment:
   ```suggestion
                   <version>${mockito.version}</version>
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org


Re: [PR] JAMES-3961 Switch to Java 21 (Polished) [james-project]

Posted by "chibenwa (via GitHub)" <gi...@apache.org>.
chibenwa commented on code in PR #1939:
URL: https://github.com/apache/james-project/pull/1939#discussion_r1463073089


##########
pom.xml:
##########
@@ -2819,7 +2819,7 @@
             <dependency>
                 <groupId>org.mockito</groupId>
                 <artifactId>mockito-inline</artifactId>
-                <version>${mockito.version}</version>
+                <version>5.2.0</version>

Review Comment:
   https://mvnrepository.com/artifact/org.mockito/mockito-inline
   
   ![image](https://github.com/apache/james-project/assets/6928740/c5549034-22e3-4192-86bb-02d6003a41df)
   
   5.7.0 is not available for a grab sorry.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org


Re: [PR] JAMES-3961 Switch to Java 21 (Polished) [james-project]

Posted by "quantranhong1999 (via GitHub)" <gi...@apache.org>.
quantranhong1999 commented on PR #1939:
URL: https://github.com/apache/james-project/pull/1939#issuecomment-1905196509

   `Failed to execute goal org.apache.openjpa:openjpa-maven-plugin:3.2.0:enhance (enhancer) on project james-server-data-jpa: Execution enhancer of goal org.apache.openjpa:openjpa-maven-plugin:3.2.0:enhance failed: Unsupported class file major version 65`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org


Re: [PR] JAMES-3961 Switch to Java 21 (Polished) [james-project]

Posted by "Arsnael (via GitHub)" <gi...@apache.org>.
Arsnael commented on PR #1939:
URL: https://github.com/apache/james-project/pull/1939#issuecomment-1907246900

   ```10:49:45,245 [ERROR] Failed to execute goal org.apache.openjpa:openjpa-maven-plugin:3.2.2:enhance (enhancer) on project james-server-data-jpa: Execution enhancer of goal org.apache.openjpa:openjpa-maven-plugin:3.2.2:enhance failed: Unsupported class file major version 65 -> [Help 1]
   org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.apache.openjpa:openjpa-maven-plugin:3.2.2:enhance (enhancer) on project james-server-data-jpa: Execution enhancer of goal org.apache.openjpa:openjpa-maven-plugin:3.2.2:enhance failed: Unsupported class file major version 65```
   
   still the same


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org


Re: [PR] JAMES-3961 Switch to Java 21 (Polished) [james-project]

Posted by "quantranhong1999 (via GitHub)" <gi...@apache.org>.
quantranhong1999 commented on PR #1939:
URL: https://github.com/apache/james-project/pull/1939#issuecomment-1914245399

   `Unsupported class file major version 65` -> Java 21. cf: https://stackoverflow.com/questions/9170832/list-of-java-class-file-format-major-version-numbers
   
   I guess the plugin `openjpa-maven-plugin` does not work with Java 21 .class file. And its latest version it far before Java 21 release though...
   
   I suggest to enforce the target jdk for JPA modules as Java 11 to mitigate this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org


Re: [PR] JAMES-3961 Switch to Java 21 (Polished) [james-project]

Posted by "chibenwa (via GitHub)" <gi...@apache.org>.
chibenwa commented on PR #1939:
URL: https://github.com/apache/james-project/pull/1939#issuecomment-1915100678

   Worth a try, yes!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org