You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2021/07/08 14:33:41 UTC
[GitHub] [incubator-mxnet] mozga-intel opened a new pull request #20425: [DO NOT MERGE] Replacement of standard std::unorder_map was replaced by a flat_hash_map
mozga-intel opened a new pull request #20425:
URL: https://github.com/apache/incubator-mxnet/pull/20425
## Description ##
This pull-request contains a small replacement of standard std::unorder_map was replaced by a parallel hashmap. The parallel hashmap has lower space requirements and might be used from multiple threads with high levels of concurrency.
### What is new here: ###
1. Parallel-hash map was added to 3rdparty
2. For OneDNN files, std::unorderd_map was replaced by a flat hashmap
## How to measure ##
Basically: ways used to measure the impact on (a few of them), as follows:
1. The first thing to measure is the number of what is memory consumption.
2. Performance for NLP models: i.e BERT
5. Getting performance results for an inference.
## Memory consumption: settings ##
1. Total bytes used for element storage: `__container__.size() * sizeof(M::type)`
2. Total byers used for the flat_hash_table bucket: `__container__ .bucket_count()* sizeof(M::type)`
### Memory consumption: results ###
* [1] Getting memory consumption results for an inference.
[Settings]
- Model: BERT
- Operator: mkldnn_fully_connected
```
Case Before After
---------------------------------------
Table bucket 39760 **28672
```
** This container uses almost `O(sizeof(M::type) + 1) + __container__ .bucket_count()` bytes
## Perfroamcne results ##
* [2] Getting performance results for an inference.
```
Case After
--------------------------------------------
Case [Infrence BERT] [0.5 - 1]%
```
## Checklist ##
### Essentials ###
- [ ] PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
- [ ] Changes are complete (i.e. I finished coding on this PR)
- [ ] All changes have test coverage
- [ ] Code is well-documented
### Changes ###
- [ ] Feature1, tests, (and when applicable, API doc)
- [ ] Feature2, tests, (and when applicable, API doc)
## Comments ##
- If this change is a backward incompatible change, why must this change be made.
- Interesting edge cases to note here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20425: [DO NOT MERGE] std::unordered_map was replaced by flat_hash_map
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20425:
URL: https://github.com/apache/incubator-mxnet/pull/20425#issuecomment-877266298
Jenkins CI successfully triggered : [centos-gpu, unix-cpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mozga-intel commented on pull request #20425: [DO NOT MERGE] std::unordered_map was replaced by flat_hash_map
Posted by GitBox <gi...@apache.org>.
mozga-intel commented on pull request #20425:
URL: https://github.com/apache/incubator-mxnet/pull/20425#issuecomment-892592243
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mozga-intel commented on pull request #20425: [DO NOT MERGE] std::unordered_map was replaced by flat_hash_map
Posted by GitBox <gi...@apache.org>.
mozga-intel commented on pull request #20425:
URL: https://github.com/apache/incubator-mxnet/pull/20425#issuecomment-892592243
@mxnet-bot run ci [centos-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20425: [master][optimization] std::unordered_map was replaced by flat_hash_map
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20425:
URL: https://github.com/apache/incubator-mxnet/pull/20425#issuecomment-961164962
Jenkins CI successfully triggered : [centos-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mozga-intel commented on pull request #20425: [DO NOT MERGE] std::unordered_map was replaced by flat_hash_map
Posted by GitBox <gi...@apache.org>.
mozga-intel commented on pull request #20425:
URL: https://github.com/apache/incubator-mxnet/pull/20425#issuecomment-877266249
@mxnet-bot run ci [centos-gpu, unix-cpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mozga-intel closed pull request #20425: [master][optimization] std::unordered_map was replaced by flat_hash_map
Posted by GitBox <gi...@apache.org>.
mozga-intel closed pull request #20425:
URL: https://github.com/apache/incubator-mxnet/pull/20425
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20425: [DO NOT MERGE] Replacement of standard std::unorder_map was replaced by a flat_hash_map
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20425:
URL: https://github.com/apache/incubator-mxnet/pull/20425#issuecomment-876491233
Hey @mozga-intel , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:
- To trigger all jobs: @mxnet-bot run ci [all]
- To trigger specific jobs: @mxnet-bot run ci [job1, job2]
***
**CI supported jobs**: [miscellaneous, windows-gpu, clang, unix-cpu, centos-cpu, windows-cpu, unix-gpu, edge, sanity, centos-gpu, website]
***
_Note_:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20425: [DO NOT MERGE] std::unordered_map was replaced by flat_hash_map
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20425:
URL: https://github.com/apache/incubator-mxnet/pull/20425#issuecomment-893286642
Jenkins CI successfully triggered : [centos-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20425: [DO NOT MERGE] std::unordered_map was replaced by flat_hash_map
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20425:
URL: https://github.com/apache/incubator-mxnet/pull/20425#issuecomment-892592286
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20425: [master][optimization] std::unordered_map was replaced by flat_hash_map
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20425:
URL: https://github.com/apache/incubator-mxnet/pull/20425#issuecomment-961107556
Jenkins CI successfully triggered : [centos-gpu, centos-cpu, unix-cpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mozga-intel commented on pull request #20425: [master][optimization] std::unordered_map was replaced by flat_hash_map
Posted by GitBox <gi...@apache.org>.
mozga-intel commented on pull request #20425:
URL: https://github.com/apache/incubator-mxnet/pull/20425#issuecomment-961107385
@mxnet-bot run ci [centos-cpu, centos-gpu, unix-cpu ]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mozga-intel commented on pull request #20425: [master][optimization] std::unordered_map was replaced by flat_hash_map
Posted by GitBox <gi...@apache.org>.
mozga-intel commented on pull request #20425:
URL: https://github.com/apache/incubator-mxnet/pull/20425#issuecomment-961164863
@mxnet-bot run ci [centos-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20425: [DO NOT MERGE] std::unordered_map was replaced by flat_hash_map
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20425:
URL: https://github.com/apache/incubator-mxnet/pull/20425#issuecomment-892592286
Jenkins CI successfully triggered : [centos-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mozga-intel commented on pull request #20425: [DO NOT MERGE] std::unordered_map was replaced by flat_hash_map
Posted by GitBox <gi...@apache.org>.
mozga-intel commented on pull request #20425:
URL: https://github.com/apache/incubator-mxnet/pull/20425#issuecomment-893286595
@mxnet-bot run ci [centos-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org