You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jena.apache.org by jaco0646 <gi...@git.apache.org> on 2018/03/03 01:12:47 UTC

[GitHub] jena pull request #368: JENA-1495 Return Model from PrefixMapping methods.

GitHub user jaco0646 opened a pull request:

    https://github.com/apache/jena/pull/368

    JENA-1495 Return Model from PrefixMapping methods.

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jaco0646/jena Covariant-Model-Methods

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/jena/pull/368.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #368
    
----
commit db778544bf71099447b4126daebf5e0df79c3e3c
Author: jaco0646 <ja...@...>
Date:   2018-03-03T01:06:51Z

    Return Model from PrefixMapping methods.

----


---

[GitHub] jena pull request #368: JENA-1495 Return Model from PrefixMapping methods.

Posted by jaco0646 <gi...@git.apache.org>.
Github user jaco0646 commented on a diff in the pull request:

    https://github.com/apache/jena/pull/368#discussion_r172364101
  
    --- Diff: jena-core/src/main/java/org/apache/jena/rdf/model/Model.java ---
    @@ -1051,4 +1051,12 @@ Remove all the statements matching (s, p, o) from this model.
             Answer true iff .close() has been called on this Model.
         */
         public boolean isClosed();
    +
    +    // Override return type for methods inherited from PrefixMapping
    --- End diff --
    
    Done.


---

[GitHub] jena issue #368: JENA-1495 Return Model from PrefixMapping methods.

Posted by ajs6f <gi...@git.apache.org>.
Github user ajs6f commented on the issue:

    https://github.com/apache/jena/pull/368
  
    This seems like a useful change, but it is not back-compatible, so in theory we should hold it for a major version release.


---

[GitHub] jena issue #368: JENA-1495 Return Model from PrefixMapping methods.

Posted by ajs6f <gi...@git.apache.org>.
Github user ajs6f commented on the issue:

    https://github.com/apache/jena/pull/368
  
    This looks basically good to me: with an additional commit addressing https://github.com/apache/jena/pull/368#pullrequestreview-101006841, I'll be happy to merge this.


---

[GitHub] jena pull request #368: JENA-1495 Return Model from PrefixMapping methods.

Posted by ajs6f <gi...@git.apache.org>.
Github user ajs6f commented on a diff in the pull request:

    https://github.com/apache/jena/pull/368#discussion_r172049845
  
    --- Diff: jena-core/src/main/java/org/apache/jena/rdf/model/Model.java ---
    @@ -1051,4 +1051,12 @@ Remove all the statements matching (s, p, o) from this model.
             Answer true iff .close() has been called on this Model.
         */
         public boolean isClosed();
    +
    +    // Override return type for methods inherited from PrefixMapping
    --- End diff --
    
    We should use `@Override` for explicitness on these changes.


---

[GitHub] jena issue #368: JENA-1495 Return Model from PrefixMapping methods.

Posted by ajs6f <gi...@git.apache.org>.
Github user ajs6f commented on the issue:

    https://github.com/apache/jena/pull/368
  
    Urp, just realized that `Model extends PrefixMapping`, so this is fine wrt compatibility. Sorry for the confusion!


---

[GitHub] jena pull request #368: JENA-1495 Return Model from PrefixMapping methods.

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/jena/pull/368


---

[GitHub] jena issue #368: JENA-1495 Return Model from PrefixMapping methods.

Posted by afs <gi...@git.apache.org>.
Github user afs commented on the issue:

    https://github.com/apache/jena/pull/368
  
    Closing this PR. I see these commits in the codebase under different SHA1 ids (b8b482ecaa and 036ebce8ed).
    
    @jaco0646 - thanks!


---