You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by "mneethiraj (via GitHub)" <gi...@apache.org> on 2026/07/07 21:43:08 UTC
[PR] RANGER-5666: update graalvm version to 25.1.3 [ranger]
mneethiraj opened a new pull request, #1052:
URL: https://github.com/apache/ranger/pull/1052
## What changes were proposed in this pull request?
Updated graalvm version from 23.0.11 to 25.1.3
## How was this patch tested?
Verified that build with unit tests completed successfully
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ranger.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] RANGER-5666: update graalvm version to 25.1.3 [ranger]
Posted by "ramackri (via GitHub)" <gi...@apache.org>.
ramackri commented on code in PR #1052:
URL: https://github.com/apache/ranger/pull/1052#discussion_r3550608006
##########
agents-common/pom.xml:
##########
@@ -182,6 +182,7 @@
<groupId>org.graalvm.js</groupId>
<artifactId>js</artifactId>
<version>${graalvm.version}</version>
+ <type>pom</type>
</dependency>
Review Comment:
At GraalVM 25.1.3, org.graalvm.js:js is published as a POM aggregator, not a JAR:
js-25.1.3.jar → 404 (does not exist)
js-25.1.3.pom → exists, and pulls in js-language + truffle-runtime
Without <type>pom</type>, Maven defaults to type=jar and will fail to resolve the dependency (or behave incorrectly).
GraalVM’s own docs for 25.x require:
<dependency>
<groupId>org.graalvm.js</groupId>
<artifactId>js</artifactId>
<version>25.1.3</version>
<type>pom</type> <!-- required -->
</dependency>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ranger.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] RANGER-5666: update graalvm version to 25.1.3 [ranger]
Posted by "ramackri (via GitHub)" <gi...@apache.org>.
ramackri commented on code in PR #1052:
URL: https://github.com/apache/ranger/pull/1052#discussion_r3551014255
##########
pom.xml:
##########
@@ -101,7 +101,7 @@
<google.guava.version>33.4.8-jre</google.guava.version>
<google.re2j.version>1.2</google.re2j.version>
<googlecode.log4jdbc.version>1.2</googlecode.log4jdbc.version>
- <graalvm.version>23.0.11</graalvm.version>
+ <graalvm.version>25.1.3</graalvm.version>
Review Comment:
**Follow-up: distro assembly descriptors need updating for GraalVM 25.1.3.**
The current includes reference artifacts that are no longer in the 25.1.3 dependency tree:
- `org.graalvm.js:js:jar` — no JAR exists at 25.1.3 (packaging is `pom`)
- `org.graalvm.sdk:graal-sdk:jar` — replaced by `polyglot` and finer-grained SDK modules
- `com.ibm.icu:icu4j` — GraalVM 25 uses `org.graalvm.shadowed:icu4j` instead
With the current whitelist, agent tarballs may only bundle `js-scriptengine`, `regex`, and `truffle-api`, while missing critical runtime JARs such as `js-language`, `polyglot`, and `truffle-runtime`. Unit tests can still pass because Maven puts the full transitive classpath on the test classpath, but assembled agent plugins may fail at runtime when evaluating JavaScript policies.
**Suggested replacement** (same change in `hive-agent.xml`, `hbase-agent.xml`, `hdfs-agent.xml`, `plugin-solr.xml`, `plugin-yarn.xml`):
Replace:
```xml
<include>org.graalvm.js:js:jar:${graalvm.version}</include>
<include>org.graalvm.js:js-scriptengine:jar:${graalvm.version}</include>
<include>org.graalvm.regex:regex:jar:${graalvm.version}</include>
<include>org.graalvm.sdk:graal-sdk:jar:${graalvm.version}</include>
<include>org.graalvm.truffle:truffle-api:jar:${graalvm.version}</include>
<include>com.ibm.icu:icu4j</include>
```
With:
```xml
<!-- GraalJS 25.x runtime (js is now a POM, not a JAR) -->
<include>org.graalvm.js:js-language:jar:${graalvm.version}</include>
<include>org.graalvm.js:js-scriptengine:jar:${graalvm.version}</include>
<include>org.graalvm.polyglot:polyglot:jar:${graalvm.version}</include>
<include>org.graalvm.regex:regex:jar:${graalvm.version}</include>
<include>org.graalvm.truffle:truffle-api:jar:${graalvm.version}</include>
<include>org.graalvm.truffle:truffle-runtime:jar:${graalvm.version}</include>
<include>org.graalvm.truffle:truffle-compiler:jar:${graalvm.version}</include>
<include>org.graalvm.sdk:jniutils:jar:${graalvm.version}</include>
<include>org.graalvm.sdk:collections:jar:${graalvm.version}</include>
<include>org.graalvm.sdk:nativeimage:jar:${graalvm.version}</include>
<include>org.graalvm.sdk:word:jar:${graalvm.version}</include>
<include>org.graalvm.shadowed:icu4j:jar:${graalvm.version}</include>
<include>org.graalvm.shadowed:xz:jar:${graalvm.version}</include>
```
This matches the `agents-common` dependency tree at 25.1.3:
```
js:pom
├── js-language → regex, truffle-api, jniutils, shadowed:icu4j → shadowed:xz
└── truffle-runtime → truffle-compiler
js-scriptengine → polyglot → collections, nativeimage → word
```
**Verification:** after updating, build a hive-agent tarball and confirm `js-language-*.jar`, `polyglot-*.jar`, and `truffle-runtime-*.jar` are present under `lib/ranger-hive-plugin-impl/`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ranger.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] RANGER-5666: update graalvm version to 25.1.3 [ranger]
Posted by "ramackri (via GitHub)" <gi...@apache.org>.
ramackri commented on PR #1052:
URL: https://github.com/apache/ranger/pull/1052#issuecomment-4927774629
Pushed the assembly descriptor follow-up to address the GraalVM 25.1.3 runtime JAR packaging gap.
**Commit:** `8a0a61e16` — updates `hive-agent.xml`, `hbase-agent.xml`, `hdfs-agent.xml`, `plugin-solr.xml`, and `plugin-yarn.xml` to bundle `js-language`, `polyglot`, `truffle-runtime`, and related SDK/shadowed artifacts (replacing obsolete `js:jar`, `graal-sdk:jar`, and `com.ibm.icu:icu4j` includes).
**Branch:** https://github.com/apache/ranger/tree/RANGER-5666
@mneethiraj — could you cherry-pick or merge this commit into your `RANGER-5666` branch so it lands on the PR?
```bash
git fetch https://github.com/apache/ranger.git RANGER-5666
git cherry-pick 8a0a61e16
git push origin RANGER-5666
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ranger.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] RANGER-5666: update graalvm version to 25.1.3 [ranger]
Posted by "ramackri (via GitHub)" <gi...@apache.org>.
ramackri commented on code in PR #1052:
URL: https://github.com/apache/ranger/pull/1052#discussion_r3551012847
##########
agents-common/pom.xml:
##########
@@ -182,6 +182,7 @@
<groupId>org.graalvm.js</groupId>
<artifactId>js</artifactId>
<version>${graalvm.version}</version>
+ <type>pom</type>
Review Comment:
**Keep `<type>pom</type>` — do not remove it.**
At GraalVM 25.1.3, `org.graalvm.js:js` is published as a POM aggregator, not a JAR (`js-25.1.3.jar` does not exist on Maven Central). The `<type>pom</type>` declaration is required for Maven to resolve the dependency correctly and pull in `js-language` and `truffle-runtime` transitively.
Without it, Maven defaults to `type=jar` and resolution will fail or behave incorrectly for 25.x.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ranger.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] RANGER-5666: update graalvm version to 25.1.3 [ranger]
Posted by "mneethiraj (via GitHub)" <gi...@apache.org>.
mneethiraj merged PR #1052:
URL: https://github.com/apache/ranger/pull/1052
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ranger.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] RANGER-5666: update graalvm version to 25.1.3 [ranger]
Posted by "ramackri (via GitHub)" <gi...@apache.org>.
ramackri commented on code in PR #1052:
URL: https://github.com/apache/ranger/pull/1052#discussion_r3550608006
##########
agents-common/pom.xml:
##########
@@ -182,6 +182,7 @@
<groupId>org.graalvm.js</groupId>
<artifactId>js</artifactId>
<version>${graalvm.version}</version>
+ <type>pom</type>
</dependency>
Review Comment:
At GraalVM 25.1.3, org.graalvm.js:js is published as a POM aggregator, not a JAR:
js-25.1.3.jar → 404 (does not exist)
js-25.1.3.pom → exists, and pulls in js-language + truffle-runtime
Without <type>pom</type>, Maven defaults to type=jar and will fail to resolve the dependency (or behave incorrectly).
GraalVM’s own docs for 25.x require:
<dependency>
<groupId>org.graalvm.js</groupId>
<artifactId>js</artifactId>
<version>25.1.3</version>
<type>pom</type> <!-- required -->
</dependency>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ranger.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] RANGER-5666: update graalvm version to 25.1.3 [ranger]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #1052:
URL: https://github.com/apache/ranger/pull/1052#discussion_r3539865078
##########
agents-common/pom.xml:
##########
@@ -182,6 +182,7 @@
<groupId>org.graalvm.js</groupId>
<artifactId>js</artifactId>
<version>${graalvm.version}</version>
+ <type>pom</type>
</dependency>
Review Comment:
The `org.graalvm.js:js` dependency is now declared with `<type>pom</type>`, which makes Maven resolve the POM artifact instead of the JAR. That can remove the `js` classes from the compile/runtime classpath, and it also conflicts with distro assembly descriptors that still explicitly include `org.graalvm.js:js:jar:${graalvm.version}` (e.g., `distro/src/main/assembly/hbase-agent.xml:78`). If the intent is to consume the `js` JAR, drop the explicit type. If the intent is to import a BOM/POM, this should typically be done under `<dependencyManagement>` with `<scope>import</scope>`, and the assembly includes may need adjusting accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ranger.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org