You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Vijay (Created) (JIRA)" <ji...@apache.org> on 2012/03/28 22:55:29 UTC
[jira] [Created] (CASSANDRA-4099) IncomingTCPConnection recognizes
from by doing socket.getInetAddress() instead of BroadCastAddress
IncomingTCPConnection recognizes from by doing socket.getInetAddress() instead of BroadCastAddress
--------------------------------------------------------------------------------------------------
Key: CASSANDRA-4099
URL: https://issues.apache.org/jira/browse/CASSANDRA-4099
Project: Cassandra
Issue Type: Bug
Reporter: Vijay
Priority: Minor
change "this.from = socket.getInetAddress()" to understand the broad cast IP, but the problem is we dont know until the first packet is received, this ticket is to work around the problem until it reads the first packet.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (CASSANDRA-4099) IncomingTCPConnection recognizes
from by doing socket.getInetAddress() instead of BroadCastAddress
Posted by "Vijay (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4099?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Vijay resolved CASSANDRA-4099.
------------------------------
Resolution: Fixed
Committed back Thanks!
> IncomingTCPConnection recognizes from by doing socket.getInetAddress() instead of BroadCastAddress
> --------------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-4099
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4099
> Project: Cassandra
> Issue Type: Bug
> Reporter: Vijay
> Assignee: Vijay
> Priority: Minor
> Fix For: 1.0.9, 1.1.0
>
> Attachments: 0001-CASSANDRA-4099-v2.patch, 0001-CASSANDRA-4099-v3.patch, 0001-CASSANDRA-4099-v4.patch, 0001-CASSANDRA-4099.patch
>
>
> change "this.from = socket.getInetAddress()" to understand the broad cast IP, but the problem is we dont know until the first packet is received, this ticket is to work around the problem until it reads the first packet.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Issue Comment Edited] (CASSANDRA-4099)
IncomingTCPConnection recognizes from by doing socket.getInetAddress()
instead of BroadCastAddress
Posted by "Vijay (Issue Comment Edited) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13240813#comment-13240813 ]
Vijay edited comment on CASSANDRA-4099 at 3/28/12 11:07 PM:
------------------------------------------------------------
Thanks Brandon, CASSANDRA-4101 looks like a better solution but not only does the Streaming sets the version Gossip or any connunication does set it, the following does it
{code}
from = msg.getFrom(); // why? see => CASSANDRA-4099
if (version > MessagingService.current_version)
{
// save the endpoint so gossip will reconnect to it
Gossiper.instance.addSavedEndpoint(from);
logger.info("Received " + (isStream ? "streaming " : "") + "connection from newer protocol version. Ignoring");
}
else if (msg != null)
{
Gossiper.instance.setVersion(from, version);
logger.debug("set version for {} to {}", from, version);
}
{code}
was (Author: vijay2win@yahoo.com):
Thanks Brandon, CASSANDRA-4101 looks like a better solution but not only does the Streaming sets the version Gossip or any connunication does set it, the following does it
<code>
from = msg.getFrom(); // why? see => CASSANDRA-4099
if (version > MessagingService.current_version)
{
// save the endpoint so gossip will reconnect to it
Gossiper.instance.addSavedEndpoint(from);
logger.info("Received " + (isStream ? "streaming " : "") + "connection from newer protocol version. Ignoring");
}
else if (msg != null)
{
Gossiper.instance.setVersion(from, version);
logger.debug("set version for {} to {}", from, version);
}
</code>
> IncomingTCPConnection recognizes from by doing socket.getInetAddress() instead of BroadCastAddress
> --------------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-4099
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4099
> Project: Cassandra
> Issue Type: Bug
> Reporter: Vijay
> Assignee: Vijay
> Priority: Minor
> Attachments: 0001-CASSANDRA-4099.patch
>
>
> change "this.from = socket.getInetAddress()" to understand the broad cast IP, but the problem is we dont know until the first packet is received, this ticket is to work around the problem until it reads the first packet.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-4099) IncomingTCPConnection recognizes
from by doing socket.getInetAddress() instead of BroadCastAddress
Posted by "Vijay (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4099?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Vijay updated CASSANDRA-4099:
-----------------------------
Attachment: 0001-CASSANDRA-4099-v4.patch
> IncomingTCPConnection recognizes from by doing socket.getInetAddress() instead of BroadCastAddress
> --------------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-4099
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4099
> Project: Cassandra
> Issue Type: Bug
> Reporter: Vijay
> Assignee: Vijay
> Priority: Minor
> Fix For: 1.0.9, 1.1.0
>
> Attachments: 0001-CASSANDRA-4099-v2.patch, 0001-CASSANDRA-4099-v3.patch, 0001-CASSANDRA-4099-v4.patch, 0001-CASSANDRA-4099.patch
>
>
> change "this.from = socket.getInetAddress()" to understand the broad cast IP, but the problem is we dont know until the first packet is received, this ticket is to work around the problem until it reads the first packet.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-4099) IncomingTCPConnection recognizes
from by doing socket.getInetAddress() instead of BroadCastAddress
Posted by "Vijay (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4099?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Vijay updated CASSANDRA-4099:
-----------------------------
Attachment: 0001-CASSANDRA-4099-v3.patch
Attached version incorporate's the comments... Note that the streaming a file will not remove or add the version, which i think is a better option IMHO. Plz let me know if you think otherwise. Thanks!
> IncomingTCPConnection recognizes from by doing socket.getInetAddress() instead of BroadCastAddress
> --------------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-4099
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4099
> Project: Cassandra
> Issue Type: Bug
> Reporter: Vijay
> Assignee: Vijay
> Priority: Minor
> Attachments: 0001-CASSANDRA-4099-v2.patch, 0001-CASSANDRA-4099-v3.patch, 0001-CASSANDRA-4099.patch
>
>
> change "this.from = socket.getInetAddress()" to understand the broad cast IP, but the problem is we dont know until the first packet is received, this ticket is to work around the problem until it reads the first packet.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-4099) IncomingTCPConnection
recognizes from by doing socket.getInetAddress() instead of
BroadCastAddress
Posted by "Vijay (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13240826#comment-13240826 ]
Vijay commented on CASSANDRA-4099:
----------------------------------
I think we can remove
{code}
if (version <= MessagingService.current_version)
{
int size = input.readInt();
byte[] headerBytes = new byte[size];
input.readFully(headerBytes);
StreamHeader streamHeader = StreamHeader.serializer().deserialize(new DataInputStream(new FastByteArrayInputStream(headerBytes)), version);
// why? see => CASSANDRA-4099
from = streamHeader.broadcastAddress;
{code}
Because the version will be already set by the Gossip hopefully :) but I still dont understand why we streaming needs to be version specific though.
> IncomingTCPConnection recognizes from by doing socket.getInetAddress() instead of BroadCastAddress
> --------------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-4099
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4099
> Project: Cassandra
> Issue Type: Bug
> Reporter: Vijay
> Assignee: Vijay
> Priority: Minor
> Attachments: 0001-CASSANDRA-4099.patch
>
>
> change "this.from = socket.getInetAddress()" to understand the broad cast IP, but the problem is we dont know until the first packet is received, this ticket is to work around the problem until it reads the first packet.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-4099) IncomingTCPConnection
recognizes from by doing socket.getInetAddress() instead of
BroadCastAddress
Posted by "Brandon Williams (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13241484#comment-13241484 ]
Brandon Williams commented on CASSANDRA-4099:
---------------------------------------------
I agree, we should get out of the habit of examining sockets directly due to broadcast_address.
> IncomingTCPConnection recognizes from by doing socket.getInetAddress() instead of BroadCastAddress
> --------------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-4099
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4099
> Project: Cassandra
> Issue Type: Bug
> Reporter: Vijay
> Assignee: Vijay
> Priority: Minor
> Attachments: 0001-CASSANDRA-4099-v2.patch, 0001-CASSANDRA-4099.patch
>
>
> change "this.from = socket.getInetAddress()" to understand the broad cast IP, but the problem is we dont know until the first packet is received, this ticket is to work around the problem until it reads the first packet.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-4099) IncomingTCPConnection
recognizes from by doing socket.getInetAddress() instead of
BroadCastAddress
Posted by "Brandon Williams (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13289867#comment-13289867 ]
Brandon Williams commented on CASSANDRA-4099:
---------------------------------------------
I agree that something like CASSANDRA-4101 is the right way to do this
> IncomingTCPConnection recognizes from by doing socket.getInetAddress() instead of BroadCastAddress
> --------------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-4099
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4099
> Project: Cassandra
> Issue Type: Bug
> Reporter: Vijay
> Assignee: Vijay
> Priority: Minor
> Fix For: 1.0.9, 1.1.0
>
> Attachments: 0001-CASSANDRA-4099-v2.patch, 0001-CASSANDRA-4099-v3.patch, 0001-CASSANDRA-4099-v4.patch, 0001-CASSANDRA-4099.patch
>
>
> change "this.from = socket.getInetAddress()" to understand the broad cast IP, but the problem is we dont know until the first packet is received, this ticket is to work around the problem until it reads the first packet.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-4099) IncomingTCPConnection
recognizes from by doing socket.getInetAddress() instead of
BroadCastAddress
Posted by "Brandon Williams (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13241474#comment-13241474 ]
Brandon Williams commented on CASSANDRA-4099:
---------------------------------------------
It overrides where from is set in the constructor:
{code}
this.from = socket.getInetAddress();
{code}
> IncomingTCPConnection recognizes from by doing socket.getInetAddress() instead of BroadCastAddress
> --------------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-4099
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4099
> Project: Cassandra
> Issue Type: Bug
> Reporter: Vijay
> Assignee: Vijay
> Priority: Minor
> Attachments: 0001-CASSANDRA-4099-v2.patch, 0001-CASSANDRA-4099.patch
>
>
> change "this.from = socket.getInetAddress()" to understand the broad cast IP, but the problem is we dont know until the first packet is received, this ticket is to work around the problem until it reads the first packet.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-4099) IncomingTCPConnection recognizes
from by doing socket.getInetAddress() instead of BroadCastAddress
Posted by "Vijay (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4099?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Vijay updated CASSANDRA-4099:
-----------------------------
Attachment: 0001-CASSANDRA-4099-v4.patch
v4 is on top of the v3 and it fixes the NPE
> IncomingTCPConnection recognizes from by doing socket.getInetAddress() instead of BroadCastAddress
> --------------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-4099
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4099
> Project: Cassandra
> Issue Type: Bug
> Reporter: Vijay
> Assignee: Vijay
> Priority: Minor
> Fix For: 1.0.9, 1.1.0
>
> Attachments: 0001-CASSANDRA-4099-v2.patch, 0001-CASSANDRA-4099-v3.patch, 0001-CASSANDRA-4099-v4.patch, 0001-CASSANDRA-4099.patch
>
>
> change "this.from = socket.getInetAddress()" to understand the broad cast IP, but the problem is we dont know until the first packet is received, this ticket is to work around the problem until it reads the first packet.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-4099) IncomingTCPConnection
recognizes from by doing socket.getInetAddress() instead of
BroadCastAddress
Posted by "Vijay (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13289854#comment-13289854 ]
Vijay commented on CASSANDRA-4099:
----------------------------------
Hi Jonathan, IMO the right fix for it with a similar approach as in the ticket CASSANDRA-4101 (we can also remove the ConcurrentMap.get() to compare the versions), Agree?
> IncomingTCPConnection recognizes from by doing socket.getInetAddress() instead of BroadCastAddress
> --------------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-4099
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4099
> Project: Cassandra
> Issue Type: Bug
> Reporter: Vijay
> Assignee: Vijay
> Priority: Minor
> Fix For: 1.0.9, 1.1.0
>
> Attachments: 0001-CASSANDRA-4099-v2.patch, 0001-CASSANDRA-4099-v3.patch, 0001-CASSANDRA-4099-v4.patch, 0001-CASSANDRA-4099.patch
>
>
> change "this.from = socket.getInetAddress()" to understand the broad cast IP, but the problem is we dont know until the first packet is received, this ticket is to work around the problem until it reads the first packet.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-4099) IncomingTCPConnection recognizes
from by doing socket.getInetAddress() instead of BroadCastAddress
Posted by "Vijay (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4099?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Vijay updated CASSANDRA-4099:
-----------------------------
Attachment: 0001-CASSANDRA-4099.patch
> IncomingTCPConnection recognizes from by doing socket.getInetAddress() instead of BroadCastAddress
> --------------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-4099
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4099
> Project: Cassandra
> Issue Type: Bug
> Reporter: Vijay
> Assignee: Vijay
> Priority: Minor
> Attachments: 0001-CASSANDRA-4099.patch
>
>
> change "this.from = socket.getInetAddress()" to understand the broad cast IP, but the problem is we dont know until the first packet is received, this ticket is to work around the problem until it reads the first packet.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Reopened] (CASSANDRA-4099) IncomingTCPConnection recognizes
from by doing socket.getInetAddress() instead of BroadCastAddress
Posted by "Vijay (Reopened) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4099?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Vijay reopened CASSANDRA-4099:
------------------------------
Looks like there is a case we will run into NPE when the other node which is sending a higher version we ignore it but the problem the msg object is not available.
> IncomingTCPConnection recognizes from by doing socket.getInetAddress() instead of BroadCastAddress
> --------------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-4099
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4099
> Project: Cassandra
> Issue Type: Bug
> Reporter: Vijay
> Assignee: Vijay
> Priority: Minor
> Fix For: 1.0.9, 1.1.0
>
> Attachments: 0001-CASSANDRA-4099-v2.patch, 0001-CASSANDRA-4099-v3.patch, 0001-CASSANDRA-4099.patch
>
>
> change "this.from = socket.getInetAddress()" to understand the broad cast IP, but the problem is we dont know until the first packet is received, this ticket is to work around the problem until it reads the first packet.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (CASSANDRA-4099) IncomingTCPConnection recognizes
from by doing socket.getInetAddress() instead of BroadCastAddress
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4099?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis resolved CASSANDRA-4099.
---------------------------------------
Resolution: Fixed
I kind of think we've reached the limits of what we can do by band-aiding this. Opened CASSANDRA-4311 for a deeper fix.
> IncomingTCPConnection recognizes from by doing socket.getInetAddress() instead of BroadCastAddress
> --------------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-4099
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4099
> Project: Cassandra
> Issue Type: Bug
> Reporter: Vijay
> Assignee: Vijay
> Priority: Minor
> Fix For: 1.1.0, 1.0.9
>
> Attachments: 0001-CASSANDRA-4099-v2.patch, 0001-CASSANDRA-4099-v3.patch, 0001-CASSANDRA-4099-v4.patch, 0001-CASSANDRA-4099.patch
>
>
> change "this.from = socket.getInetAddress()" to understand the broad cast IP, but the problem is we dont know until the first packet is received, this ticket is to work around the problem until it reads the first packet.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-4099) IncomingTCPConnection
recognizes from by doing socket.getInetAddress() instead of
BroadCastAddress
Posted by "Brandon Williams (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13242498#comment-13242498 ]
Brandon Williams commented on CASSANDRA-4099:
---------------------------------------------
+1
> IncomingTCPConnection recognizes from by doing socket.getInetAddress() instead of BroadCastAddress
> --------------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-4099
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4099
> Project: Cassandra
> Issue Type: Bug
> Reporter: Vijay
> Assignee: Vijay
> Priority: Minor
> Fix For: 1.0.9, 1.1.0
>
> Attachments: 0001-CASSANDRA-4099-v2.patch, 0001-CASSANDRA-4099-v3.patch, 0001-CASSANDRA-4099-v4.patch, 0001-CASSANDRA-4099.patch
>
>
> change "this.from = socket.getInetAddress()" to understand the broad cast IP, but the problem is we dont know until the first packet is received, this ticket is to work around the problem until it reads the first packet.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-4099) IncomingTCPConnection recognizes
from by doing socket.getInetAddress() instead of BroadCastAddress
Posted by "Vijay (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4099?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Vijay updated CASSANDRA-4099:
-----------------------------
Attachment: (was: 0001-CASSANDRA-4099-v4.patch)
> IncomingTCPConnection recognizes from by doing socket.getInetAddress() instead of BroadCastAddress
> --------------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-4099
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4099
> Project: Cassandra
> Issue Type: Bug
> Reporter: Vijay
> Assignee: Vijay
> Priority: Minor
> Fix For: 1.0.9, 1.1.0
>
> Attachments: 0001-CASSANDRA-4099-v2.patch, 0001-CASSANDRA-4099-v3.patch, 0001-CASSANDRA-4099-v4.patch, 0001-CASSANDRA-4099.patch
>
>
> change "this.from = socket.getInetAddress()" to understand the broad cast IP, but the problem is we dont know until the first packet is received, this ticket is to work around the problem until it reads the first packet.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-4099) IncomingTCPConnection recognizes
from by doing socket.getInetAddress() instead of BroadCastAddress
Posted by "Vijay (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4099?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Vijay updated CASSANDRA-4099:
-----------------------------
Attachment: 0001-CASSANDRA-4099-v2.patch
IRC Brandon explained the changes in flowcontrol which will not allow us to stream data from other versions, v2 removes those changes from v1
> IncomingTCPConnection recognizes from by doing socket.getInetAddress() instead of BroadCastAddress
> --------------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-4099
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4099
> Project: Cassandra
> Issue Type: Bug
> Reporter: Vijay
> Assignee: Vijay
> Priority: Minor
> Attachments: 0001-CASSANDRA-4099-v2.patch, 0001-CASSANDRA-4099.patch
>
>
> change "this.from = socket.getInetAddress()" to understand the broad cast IP, but the problem is we dont know until the first packet is received, this ticket is to work around the problem until it reads the first packet.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-4099) IncomingTCPConnection
recognizes from by doing socket.getInetAddress() instead of
BroadCastAddress
Posted by "Jonathan Ellis (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13241480#comment-13241480 ]
Jonathan Ellis commented on CASSANDRA-4099:
-------------------------------------------
I see.
Looking at the usages of ITC.from, it looks like we can drop that constructor initialization entirely...
> IncomingTCPConnection recognizes from by doing socket.getInetAddress() instead of BroadCastAddress
> --------------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-4099
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4099
> Project: Cassandra
> Issue Type: Bug
> Reporter: Vijay
> Assignee: Vijay
> Priority: Minor
> Attachments: 0001-CASSANDRA-4099-v2.patch, 0001-CASSANDRA-4099.patch
>
>
> change "this.from = socket.getInetAddress()" to understand the broad cast IP, but the problem is we dont know until the first packet is received, this ticket is to work around the problem until it reads the first packet.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-4099) IncomingTCPConnection
recognizes from by doing socket.getInetAddress() instead of
BroadCastAddress
Posted by "Jonathan Ellis (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13241440#comment-13241440 ]
Jonathan Ellis commented on CASSANDRA-4099:
-------------------------------------------
I still don't get it.
{noformat}
+ from = msg.getFrom(); // why? see => CASSANDRA-4099
- Gossiper.instance.setVersion(msg.getFrom(), version);
+ Gossiper.instance.setVersion(from, version);
{noformat}
How is the first getFrom, not the same as the one we've de-inlined?
> IncomingTCPConnection recognizes from by doing socket.getInetAddress() instead of BroadCastAddress
> --------------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-4099
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4099
> Project: Cassandra
> Issue Type: Bug
> Reporter: Vijay
> Assignee: Vijay
> Priority: Minor
> Attachments: 0001-CASSANDRA-4099-v2.patch, 0001-CASSANDRA-4099.patch
>
>
> change "this.from = socket.getInetAddress()" to understand the broad cast IP, but the problem is we dont know until the first packet is received, this ticket is to work around the problem until it reads the first packet.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-4099) IncomingTCPConnection
recognizes from by doing socket.getInetAddress() instead of
BroadCastAddress
Posted by "Brandon Williams (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13240811#comment-13240811 ]
Brandon Williams commented on CASSANDRA-4099:
---------------------------------------------
This doesn't look like a perfect solution since all nodes will have to stream to all other nodes in order to learn the correct version, and thus be able to use newer-version features. I'm not sure there's currently a way around this, though. I created CASSANDRA-4101 to get us started there, but I'll look more closely here tomorrow.
> IncomingTCPConnection recognizes from by doing socket.getInetAddress() instead of BroadCastAddress
> --------------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-4099
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4099
> Project: Cassandra
> Issue Type: Bug
> Reporter: Vijay
> Assignee: Vijay
> Priority: Minor
> Attachments: 0001-CASSANDRA-4099.patch
>
>
> change "this.from = socket.getInetAddress()" to understand the broad cast IP, but the problem is we dont know until the first packet is received, this ticket is to work around the problem until it reads the first packet.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-4099) IncomingTCPConnection
recognizes from by doing socket.getInetAddress() instead of
BroadCastAddress
Posted by "Brandon Williams (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13240822#comment-13240822 ]
Brandon Williams commented on CASSANDRA-4099:
---------------------------------------------
I think I see, in your situation the version is correct for everything except streaming, hence 1)? It seems like the problem here is it will still accept streams from a lesser version, which is always version-specific.
> IncomingTCPConnection recognizes from by doing socket.getInetAddress() instead of BroadCastAddress
> --------------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-4099
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4099
> Project: Cassandra
> Issue Type: Bug
> Reporter: Vijay
> Assignee: Vijay
> Priority: Minor
> Attachments: 0001-CASSANDRA-4099.patch
>
>
> change "this.from = socket.getInetAddress()" to understand the broad cast IP, but the problem is we dont know until the first packet is received, this ticket is to work around the problem until it reads the first packet.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (CASSANDRA-4099) IncomingTCPConnection recognizes
from by doing socket.getInetAddress() instead of BroadCastAddress
Posted by "Vijay (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4099?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Vijay reassigned CASSANDRA-4099:
--------------------------------
Assignee: Vijay
> IncomingTCPConnection recognizes from by doing socket.getInetAddress() instead of BroadCastAddress
> --------------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-4099
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4099
> Project: Cassandra
> Issue Type: Bug
> Reporter: Vijay
> Assignee: Vijay
> Priority: Minor
>
> change "this.from = socket.getInetAddress()" to understand the broad cast IP, but the problem is we dont know until the first packet is received, this ticket is to work around the problem until it reads the first packet.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-4099) IncomingTCPConnection
recognizes from by doing socket.getInetAddress() instead of
BroadCastAddress
Posted by "Vijay (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13240813#comment-13240813 ]
Vijay commented on CASSANDRA-4099:
----------------------------------
Thanks Brandon, CASSANDRA-4101 looks like a better solution but not only does the Streaming sets the version Gossip or any connunication does set it, the following does it
<code>
from = msg.getFrom(); // why? see => CASSANDRA-4099
if (version > MessagingService.current_version)
{
// save the endpoint so gossip will reconnect to it
Gossiper.instance.addSavedEndpoint(from);
logger.info("Received " + (isStream ? "streaming " : "") + "connection from newer protocol version. Ignoring");
}
else if (msg != null)
{
Gossiper.instance.setVersion(from, version);
logger.debug("set version for {} to {}", from, version);
}
</code>
> IncomingTCPConnection recognizes from by doing socket.getInetAddress() instead of BroadCastAddress
> --------------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-4099
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4099
> Project: Cassandra
> Issue Type: Bug
> Reporter: Vijay
> Assignee: Vijay
> Priority: Minor
> Attachments: 0001-CASSANDRA-4099.patch
>
>
> change "this.from = socket.getInetAddress()" to understand the broad cast IP, but the problem is we dont know until the first packet is received, this ticket is to work around the problem until it reads the first packet.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-4099) IncomingTCPConnection
recognizes from by doing socket.getInetAddress() instead of
BroadCastAddress
Posted by "Vijay (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13241305#comment-13241305 ]
Vijay commented on CASSANDRA-4099:
----------------------------------
getFrom gets the IP from the message header and the message header is set by the caller, which uses FB.BCA and the receiving machine sets it. Plz look at Message.getInternalReply for example. Thanks!
> IncomingTCPConnection recognizes from by doing socket.getInetAddress() instead of BroadCastAddress
> --------------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-4099
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4099
> Project: Cassandra
> Issue Type: Bug
> Reporter: Vijay
> Assignee: Vijay
> Priority: Minor
> Attachments: 0001-CASSANDRA-4099-v2.patch, 0001-CASSANDRA-4099.patch
>
>
> change "this.from = socket.getInetAddress()" to understand the broad cast IP, but the problem is we dont know until the first packet is received, this ticket is to work around the problem until it reads the first packet.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-4099) IncomingTCPConnection
recognizes from by doing socket.getInetAddress() instead of
BroadCastAddress
Posted by "Jonathan Ellis (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13241505#comment-13241505 ]
Jonathan Ellis commented on CASSANDRA-4099:
-------------------------------------------
+1 on v3 for 1.0+
I'm fine w/ continuing to ignore version on streaming for now
> IncomingTCPConnection recognizes from by doing socket.getInetAddress() instead of BroadCastAddress
> --------------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-4099
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4099
> Project: Cassandra
> Issue Type: Bug
> Reporter: Vijay
> Assignee: Vijay
> Priority: Minor
> Attachments: 0001-CASSANDRA-4099-v2.patch, 0001-CASSANDRA-4099-v3.patch, 0001-CASSANDRA-4099.patch
>
>
> change "this.from = socket.getInetAddress()" to understand the broad cast IP, but the problem is we dont know until the first packet is received, this ticket is to work around the problem until it reads the first packet.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-4099) IncomingTCPConnection
recognizes from by doing socket.getInetAddress() instead of
BroadCastAddress
Posted by "Brandon Williams (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13240815#comment-13240815 ]
Brandon Williams commented on CASSANDRA-4099:
---------------------------------------------
Won't 'from' still always be wrong in your configuration unless streaming occurs?
> IncomingTCPConnection recognizes from by doing socket.getInetAddress() instead of BroadCastAddress
> --------------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-4099
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4099
> Project: Cassandra
> Issue Type: Bug
> Reporter: Vijay
> Assignee: Vijay
> Priority: Minor
> Attachments: 0001-CASSANDRA-4099.patch
>
>
> change "this.from = socket.getInetAddress()" to understand the broad cast IP, but the problem is we dont know until the first packet is received, this ticket is to work around the problem until it reads the first packet.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-4099) IncomingTCPConnection
recognizes from by doing socket.getInetAddress() instead of
BroadCastAddress
Posted by "Brandon Williams (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13241258#comment-13241258 ]
Brandon Williams commented on CASSANDRA-4099:
---------------------------------------------
I'm confused, how does 'from' differ from 'msg.getFrom' in this patch? It seems like a no-op.
> IncomingTCPConnection recognizes from by doing socket.getInetAddress() instead of BroadCastAddress
> --------------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-4099
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4099
> Project: Cassandra
> Issue Type: Bug
> Reporter: Vijay
> Assignee: Vijay
> Priority: Minor
> Attachments: 0001-CASSANDRA-4099-v2.patch, 0001-CASSANDRA-4099.patch
>
>
> change "this.from = socket.getInetAddress()" to understand the broad cast IP, but the problem is we dont know until the first packet is received, this ticket is to work around the problem until it reads the first packet.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-4099) IncomingTCPConnection
recognizes from by doing socket.getInetAddress() instead of
BroadCastAddress
Posted by "Brandon Williams (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13241351#comment-13241351 ]
Brandon Williams commented on CASSANDRA-4099:
---------------------------------------------
I see, it's injecting another getFrom call. +1 (though this version only applies to trunk)
> IncomingTCPConnection recognizes from by doing socket.getInetAddress() instead of BroadCastAddress
> --------------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-4099
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4099
> Project: Cassandra
> Issue Type: Bug
> Reporter: Vijay
> Assignee: Vijay
> Priority: Minor
> Attachments: 0001-CASSANDRA-4099-v2.patch, 0001-CASSANDRA-4099.patch
>
>
> change "this.from = socket.getInetAddress()" to understand the broad cast IP, but the problem is we dont know until the first packet is received, this ticket is to work around the problem until it reads the first packet.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Reopened] (CASSANDRA-4099) IncomingTCPConnection recognizes
from by doing socket.getInetAddress() instead of BroadCastAddress
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4099?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis reopened CASSANDRA-4099:
---------------------------------------
I think this is still broken. if A forwards a message from B to C, then {{Gossiper.instance.setVersion(from, version)}} C will mark B's version (B == from) to the version that A sent. But A sends its own version, not B's. (Which is correct for the purpose of message forwarding, since A re-serializes instead of passing what B sent verbatim.)
I don't think we can accommodate both message forwarding, and broadcast address != socket address, without a protocol change to include a "here is my reply-to broadcast_address" piece of information when the connection is first established, distinct from Message.from.
> IncomingTCPConnection recognizes from by doing socket.getInetAddress() instead of BroadCastAddress
> --------------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-4099
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4099
> Project: Cassandra
> Issue Type: Bug
> Reporter: Vijay
> Assignee: Vijay
> Priority: Minor
> Fix For: 1.0.9, 1.1.0
>
> Attachments: 0001-CASSANDRA-4099-v2.patch, 0001-CASSANDRA-4099-v3.patch, 0001-CASSANDRA-4099-v4.patch, 0001-CASSANDRA-4099.patch
>
>
> change "this.from = socket.getInetAddress()" to understand the broad cast IP, but the problem is we dont know until the first packet is received, this ticket is to work around the problem until it reads the first packet.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-4099) IncomingTCPConnection
recognizes from by doing socket.getInetAddress() instead of
BroadCastAddress
Posted by "Vijay (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13240819#comment-13240819 ]
Vijay commented on CASSANDRA-4099:
----------------------------------
Nope there is 2 places where we set the from one is during the stream just before we start. the second place is when it is not a stream and when we recive the first message so we should be ok and should never be null.
1)
{code}
// why? see => CASSANDRA-4099
from = streamHeader.broadcastAddress;
stream(streamHeader, input);
{code}
2)
{code}
Message msg = receiveMessage(input, version);
from = msg.getFrom(); // why? see => CASSANDRA-4099
{code}
Hope it makes sense.
> IncomingTCPConnection recognizes from by doing socket.getInetAddress() instead of BroadCastAddress
> --------------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-4099
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4099
> Project: Cassandra
> Issue Type: Bug
> Reporter: Vijay
> Assignee: Vijay
> Priority: Minor
> Attachments: 0001-CASSANDRA-4099.patch
>
>
> change "this.from = socket.getInetAddress()" to understand the broad cast IP, but the problem is we dont know until the first packet is received, this ticket is to work around the problem until it reads the first packet.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira