You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/09/14 08:16:28 UTC

[GitHub] [apisix] membphis commented on a change in pull request #2209: draft: allow empty `service` object, it does not contain any `upstream` and `plugin`.

membphis commented on a change in pull request #2209:
URL: https://github.com/apache/apisix/pull/2209#discussion_r487731432



##########
File path: t/admin/schema.t
##########
@@ -40,7 +40,7 @@ qr/"plugins":\{"type":"object"}/
 --- request
 GET /apisix/admin/schema/service
 --- response_body eval
-qr/"required":\["upstream"\]/
+qr/"required".*additionalProperties/

Review comment:
       this way is not easy to confirm if we removed `anyOf`, we should check it in Lua land




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org