You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@buildstream.apache.org by GitBox <gi...@apache.org> on 2022/10/05 20:07:09 UTC
[GitHub] [buildstream] abderrahim opened a new pull request, #1768: sandbox: add dummy sandbox for checking out artifacts from different arches
abderrahim opened a new pull request, #1768:
URL: https://github.com/apache/buildstream/pull/1768
We've added the ability to pull stuff from different architectures since 1.5.1 but that wasn't usable as we could not check out the result (even if we don't need to run anything)
Fixes https://github.com/apache/buildstream/issues/1352 for bst-1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] nanonyme commented on a diff in pull request #1768: sandbox: add dummy sandbox for checking out artifacts from different arches
Posted by GitBox <gi...@apache.org>.
nanonyme commented on code in PR #1768:
URL: https://github.com/apache/buildstream/pull/1768#discussion_r990640145
##########
buildstream/_platform/linux.py:
##########
@@ -22,13 +22,21 @@
from .. import _site
from .. import utils
-from ..sandbox import SandboxBwrap
+from ..sandbox import SandboxBwrap, SandboxDummy
from . import Platform
class Linux(Platform):
+ ARCHITECTURES = {
Review Comment:
I know it was called like this before so it's not really a change but not entirely obvious from name that this is just an alias mapping and unlisted things may be supported.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] gtristan commented on pull request #1768: sandbox: add dummy sandbox for checking out artifacts from different arches
Posted by GitBox <gi...@apache.org>.
gtristan commented on PR #1768:
URL: https://github.com/apache/buildstream/pull/1768#issuecomment-1274434299
Overall looks good to me.
One thing is curious to me, it appears that even if we do support 32bit builds on 64bit hosts via `arch-test`, we still bail out and complain if the user does not have `linux32` installed. However this is clearly not a regression looking at the ported code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] nanonyme commented on pull request #1768: sandbox: add dummy sandbox for checking out artifacts from different arches
Posted by GitBox <gi...@apache.org>.
nanonyme commented on PR #1768:
URL: https://github.com/apache/buildstream/pull/1768#issuecomment-1272315688
Looks good to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] gtristan merged pull request #1768: sandbox: add dummy sandbox for checking out artifacts from different arches
Posted by GitBox <gi...@apache.org>.
gtristan merged PR #1768:
URL: https://github.com/apache/buildstream/pull/1768
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org