You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@apex.apache.org by vrozov <gi...@git.apache.org> on 2015/12/02 02:05:35 UTC
[GitHub] incubator-apex-core pull request: All annotations should be on a s...
GitHub user vrozov opened a pull request:
https://github.com/apache/incubator-apex-core/pull/182
All annotations should be on a separate line. Upgraded checkstyle to 6.13
@chandnisingh Please review
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vrozov/incubator-apex-core checkstyle
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-apex-core/pull/182.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #182
----
commit 564888e5930e0cddf0b5037696fe2ba0cdd0e515
Author: Vlad Rozov <v....@datatorrent.com>
Date: 2015-12-02T01:04:04Z
All annotations should be on a separate line.
Upgraded checkstyle to 6.13
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-core pull request: All annotations should be on a s...
Posted by chandnisingh <gi...@git.apache.org>.
Github user chandnisingh commented on a diff in the pull request:
https://github.com/apache/incubator-apex-core/pull/182#discussion_r46365750
--- Diff: pom.xml ---
@@ -306,7 +306,7 @@
<dependency>
<groupId>com.puppycrawl.tools</groupId>
<artifactId>checkstyle</artifactId>
- <version>6.12.1</version>
+ <version>6.13</version>
--- End diff --
Why do we need to bump the version?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-core pull request: All annotations should be on a s...
Posted by chandnisingh <gi...@git.apache.org>.
Github user chandnisingh commented on a diff in the pull request:
https://github.com/apache/incubator-apex-core/pull/182#discussion_r46365498
--- Diff: apex_checks.xml ---
@@ -152,7 +152,7 @@
<module name="AnnotationLocation">
<property name="allowSamelineMultipleAnnotations" value="false"/>
- <property name="allowSamelineSingleParameterlessAnnotation" value="true"/>
+ <property name="allowSamelineSingleParameterlessAnnotation" value="false"/>
--- End diff --
will this dis-allow void setPropX(@NotNull String x) ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-core pull request: All annotations should be on a s...
Posted by chandnisingh <gi...@git.apache.org>.
Github user chandnisingh commented on a diff in the pull request:
https://github.com/apache/incubator-apex-core/pull/182#discussion_r46367822
--- Diff: pom.xml ---
@@ -306,7 +306,7 @@
<dependency>
<groupId>com.puppycrawl.tools</groupId>
<artifactId>checkstyle</artifactId>
- <version>6.12.1</version>
+ <version>6.13</version>
--- End diff --
The problem with bumping plugin version quite often is that there are child modules (Malhar) outside Apex core repo and the plugin gets inherited to them. Any changes made in the configuration related to a particular version of checkstyle has then also be updated to outside child repositories.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-core pull request: All annotations should be on a s...
Posted by vrozov <gi...@git.apache.org>.
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/incubator-apex-core/pull/182#discussion_r46375054
--- Diff: pom.xml ---
@@ -306,7 +306,7 @@
<dependency>
<groupId>com.puppycrawl.tools</groupId>
<artifactId>checkstyle</artifactId>
- <version>6.12.1</version>
+ <version>6.13</version>
--- End diff --
This can't prevent Apex core from upgrading. There are bug fixes included into the new version of the checkstyle and even if we don't hit those bugs in the current code line, we need those fixes to avoid introducing style violations into the future codeline.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-core pull request: All annotations should be on a s...
Posted by vrozov <gi...@git.apache.org>.
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/incubator-apex-core/pull/182#discussion_r46366680
--- Diff: pom.xml ---
@@ -306,7 +306,7 @@
<dependency>
<groupId>com.puppycrawl.tools</groupId>
<artifactId>checkstyle</artifactId>
- <version>6.12.1</version>
+ <version>6.13</version>
--- End diff --
Please see checkstyle 6.13 release notes for the list of bugs fixed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-core pull request: All annotations should be on a s...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-apex-core/pull/182
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-core pull request: All annotations should be on a s...
Posted by vrozov <gi...@git.apache.org>.
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/incubator-apex-core/pull/182#discussion_r46366231
--- Diff: apex_checks.xml ---
@@ -152,7 +152,7 @@
<module name="AnnotationLocation">
<property name="allowSamelineMultipleAnnotations" value="false"/>
- <property name="allowSamelineSingleParameterlessAnnotation" value="true"/>
+ <property name="allowSamelineSingleParameterlessAnnotation" value="false"/>
--- End diff --
No, by default it applies to CLASS_DEF, INTERFACE_DEF, ENUM_DEF, METHOD_DEF, CTOR_DEF, VARIABLE_DEF. So it does not apply to PARAMETER_DEF. It does not affect number of existing violations either.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---