You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/12/08 05:24:56 UTC
[GitHub] [arrow] kou opened a new pull request #8868: ARROW-10843: [C++] Add support for temporal types in sort family kernels
kou opened a new pull request #8868:
URL: https://github.com/apache/arrow/pull/8868
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on a change in pull request #8868: ARROW-10843: [C++] Add support for temporal types in sort family kernels
Posted by GitBox <gi...@apache.org>.
pitrou commented on a change in pull request #8868:
URL: https://github.com/apache/arrow/pull/8868#discussion_r538249607
##########
File path: cpp/src/arrow/compute/kernels/vector_sort.cc
##########
@@ -267,14 +267,19 @@ uint64_t* PartitionNulls(uint64_t* indices_begin, uint64_t* indices_end,
// We need to preserve the options
using PartitionNthToIndicesState = internal::OptionsWrapper<PartitionNthOptions>;
+// Convert string array to binary array and large string array to
+// large binary array. Because we want to reuse kernels for binary
+// array and large binary array to reduce generated codes.
Review comment:
Can we do the same for temporal types?
##########
File path: cpp/src/arrow/compute/kernels/vector_sort.cc
##########
@@ -267,14 +267,19 @@ uint64_t* PartitionNulls(uint64_t* indices_begin, uint64_t* indices_end,
// We need to preserve the options
using PartitionNthToIndicesState = internal::OptionsWrapper<PartitionNthOptions>;
+// Convert string array to binary array and large string array to
+// large binary array. Because we want to reuse kernels for binary
+// array and large binary array to reduce generated codes.
Review comment:
Can we do the same for temporal types? @kou
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] xhochy closed pull request #8868: ARROW-10843: [C++] Add support for temporal types in sort family kernels
Posted by GitBox <gi...@apache.org>.
xhochy closed pull request #8868:
URL: https://github.com/apache/arrow/pull/8868
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8868: ARROW-10843: [C++] Add support for temporal types in sort family kernels
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8868:
URL: https://github.com/apache/arrow/pull/8868#issuecomment-740397948
https://issues.apache.org/jira/browse/ARROW-10843
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on a change in pull request #8868: ARROW-10843: [C++] Add support for temporal types in sort family kernels
Posted by GitBox <gi...@apache.org>.
kou commented on a change in pull request #8868:
URL: https://github.com/apache/arrow/pull/8868#discussion_r538898690
##########
File path: cpp/src/arrow/compute/kernels/vector_sort.cc
##########
@@ -267,14 +267,19 @@ uint64_t* PartitionNulls(uint64_t* indices_begin, uint64_t* indices_end,
// We need to preserve the options
using PartitionNthToIndicesState = internal::OptionsWrapper<PartitionNthOptions>;
+// Convert string array to binary array and large string array to
+// large binary array. Because we want to reuse kernels for binary
+// array and large binary array to reduce generated codes.
Review comment:
Ah, yes. We can reuse `Int*` code for temporal types.
I didn't notice it.
ARROW-10851
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org