You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "Carsten Ziegeler (JIRA)" <ji...@apache.org> on 2012/07/18 13:44:34 UTC
[jira] [Created] (SLING-2538) Remove fallback code for old resource
implementations
Carsten Ziegeler created SLING-2538:
---------------------------------------
Summary: Remove fallback code for old resource implementations
Key: SLING-2538
URL: https://issues.apache.org/jira/browse/SLING-2538
Project: Sling
Issue Type: Bug
Components: API
Affects Versions: API 2.2.4
Reporter: Carsten Ziegeler
Fix For: API 2.2.6
See SLING-2457 for some examples, we currently have some "unusal" handling of some ResourceUtil/AbstractResource methods which are basically there to support very old implementations of the resource api which predate the 2.1.0 release.
As we now extended the resource interface as well as resource resolver and other stuff, I think it's time to not support this old stuff anymore and clean up the code
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (SLING-2538) Remove fallback code for old
resource implementations
Posted by "Ian Boston (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-2538?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ian Boston resolved SLING-2538.
-------------------------------
Resolution: Fixed
Nothing heard on list so assuming the changes are Ok.
Have applied the patch an committed.
> Remove fallback code for old resource implementations
> -----------------------------------------------------
>
> Key: SLING-2538
> URL: https://issues.apache.org/jira/browse/SLING-2538
> Project: Sling
> Issue Type: Improvement
> Components: API
> Affects Versions: API 2.2.4
> Reporter: Carsten Ziegeler
> Assignee: Ian Boston
> Fix For: API 2.2.6
>
> Attachments: SLING-2538.patch
>
>
> See SLING-2457 for some examples, we currently have some "unusal" handling of some ResourceUtil/AbstractResource methods which are basically there to support very old implementations of the resource api which predate the 2.1.0 release.
> As we now extended the resource interface as well as resource resolver and other stuff, I think it's time to not support this old stuff anymore and clean up the code
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2538) Remove fallback code for old
resource implementations
Posted by "Ian Boston (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-2538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13485745#comment-13485745 ]
Ian Boston commented on SLING-2538:
-----------------------------------
Appears to be caused[1] by an unclosed session after JcrResourceListenerTest[2] which passed.
Since I think this is not related to the changes made in this issue and I can reproduce locally, I am going to re-close and see if its reported elsewhere.
1 https://builds.apache.org/job/sling-trunk-1.5/org.apache.sling$org.apache.sling.jcr.resource/1835/testReport/org.apache.sling.jcr.resource.internal/JcrModifiablePropertyMapTest/testInputStream/
2 https://builds.apache.org/job/sling-trunk-1.5/org.apache.sling$org.apache.sling.jcr.resource/1835/testReport/org.apache.sling.jcr.resource.internal/JcrResourceListenerTest/
> Remove fallback code for old resource implementations
> -----------------------------------------------------
>
> Key: SLING-2538
> URL: https://issues.apache.org/jira/browse/SLING-2538
> Project: Sling
> Issue Type: Improvement
> Components: API
> Affects Versions: API 2.2.4
> Reporter: Carsten Ziegeler
> Assignee: Ian Boston
> Fix For: API 2.2.6
>
> Attachments: SLING-2538.patch
>
>
> See SLING-2457 for some examples, we currently have some "unusal" handling of some ResourceUtil/AbstractResource methods which are basically there to support very old implementations of the resource api which predate the 2.1.0 release.
> As we now extended the resource interface as well as resource resolver and other stuff, I think it's time to not support this old stuff anymore and clean up the code
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (SLING-2538) Remove fallback code for old
resource implementations
Posted by "Ian Boston (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-2538?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ian Boston reassigned SLING-2538:
---------------------------------
Assignee: Ian Boston
> Remove fallback code for old resource implementations
> -----------------------------------------------------
>
> Key: SLING-2538
> URL: https://issues.apache.org/jira/browse/SLING-2538
> Project: Sling
> Issue Type: Improvement
> Components: API
> Affects Versions: API 2.2.4
> Reporter: Carsten Ziegeler
> Assignee: Ian Boston
> Fix For: API 2.2.6
>
> Attachments: SLING-2538.patch
>
>
> See SLING-2457 for some examples, we currently have some "unusal" handling of some ResourceUtil/AbstractResource methods which are basically there to support very old implementations of the resource api which predate the 2.1.0 release.
> As we now extended the resource interface as well as resource resolver and other stuff, I think it's time to not support this old stuff anymore and clean up the code
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (SLING-2538) Remove fallback code for old
resource implementations
Posted by "Ian Boston (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-2538?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ian Boston resolved SLING-2538.
-------------------------------
Resolution: Fixed
Still fixed.
> Remove fallback code for old resource implementations
> -----------------------------------------------------
>
> Key: SLING-2538
> URL: https://issues.apache.org/jira/browse/SLING-2538
> Project: Sling
> Issue Type: Improvement
> Components: API
> Affects Versions: API 2.2.4
> Reporter: Carsten Ziegeler
> Assignee: Ian Boston
> Fix For: API 2.2.6
>
> Attachments: SLING-2538.patch
>
>
> See SLING-2457 for some examples, we currently have some "unusal" handling of some ResourceUtil/AbstractResource methods which are basically there to support very old implementations of the resource api which predate the 2.1.0 release.
> As we now extended the resource interface as well as resource resolver and other stuff, I think it's time to not support this old stuff anymore and clean up the code
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SLING-2538) Remove fallback code for old resource
implementations
Posted by "Ian Boston (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-2538?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ian Boston updated SLING-2538:
------------------------------
Attachment: SLING-2538.patch
Hopefully this is what is required... but I am not sure.
> Remove fallback code for old resource implementations
> -----------------------------------------------------
>
> Key: SLING-2538
> URL: https://issues.apache.org/jira/browse/SLING-2538
> Project: Sling
> Issue Type: Improvement
> Components: API
> Affects Versions: API 2.2.4
> Reporter: Carsten Ziegeler
> Fix For: API 2.2.6
>
> Attachments: SLING-2538.patch
>
>
> See SLING-2457 for some examples, we currently have some "unusal" handling of some ResourceUtil/AbstractResource methods which are basically there to support very old implementations of the resource api which predate the 2.1.0 release.
> As we now extended the resource interface as well as resource resolver and other stuff, I think it's time to not support this old stuff anymore and clean up the code
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2538) Remove fallback code for old
resource implementations
Posted by "Carsten Ziegeler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-2538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13484925#comment-13484925 ]
Carsten Ziegeler commented on SLING-2538:
-----------------------------------------
lgtm
> Remove fallback code for old resource implementations
> -----------------------------------------------------
>
> Key: SLING-2538
> URL: https://issues.apache.org/jira/browse/SLING-2538
> Project: Sling
> Issue Type: Improvement
> Components: API
> Affects Versions: API 2.2.4
> Reporter: Carsten Ziegeler
> Assignee: Ian Boston
> Fix For: API 2.2.6
>
> Attachments: SLING-2538.patch
>
>
> See SLING-2457 for some examples, we currently have some "unusal" handling of some ResourceUtil/AbstractResource methods which are basically there to support very old implementations of the resource api which predate the 2.1.0 release.
> As we now extended the resource interface as well as resource resolver and other stuff, I think it's time to not support this old stuff anymore and clean up the code
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Comment Edited] (SLING-2538) Remove fallback code for old
resource implementations
Posted by "Ian Boston (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-2538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13485745#comment-13485745 ]
Ian Boston edited comment on SLING-2538 at 10/28/12 11:38 PM:
--------------------------------------------------------------
Appears to be caused[1] by an unclosed session after JcrResourceListenerTest[2] which passed.
Since I think this is not related to the changes made in this issue and I can't reproduce locally, I am going to re-close and see if its reported elsewhere.
1 https://builds.apache.org/job/sling-trunk-1.5/org.apache.sling$org.apache.sling.jcr.resource/1835/testReport/org.apache.sling.jcr.resource.internal/JcrModifiablePropertyMapTest/testInputStream/
2 https://builds.apache.org/job/sling-trunk-1.5/org.apache.sling$org.apache.sling.jcr.resource/1835/testReport/org.apache.sling.jcr.resource.internal/JcrResourceListenerTest/
was (Author: ianeboston):
Appears to be caused[1] by an unclosed session after JcrResourceListenerTest[2] which passed.
Since I think this is not related to the changes made in this issue and I can reproduce locally, I am going to re-close and see if its reported elsewhere.
1 https://builds.apache.org/job/sling-trunk-1.5/org.apache.sling$org.apache.sling.jcr.resource/1835/testReport/org.apache.sling.jcr.resource.internal/JcrModifiablePropertyMapTest/testInputStream/
2 https://builds.apache.org/job/sling-trunk-1.5/org.apache.sling$org.apache.sling.jcr.resource/1835/testReport/org.apache.sling.jcr.resource.internal/JcrResourceListenerTest/
> Remove fallback code for old resource implementations
> -----------------------------------------------------
>
> Key: SLING-2538
> URL: https://issues.apache.org/jira/browse/SLING-2538
> Project: Sling
> Issue Type: Improvement
> Components: API
> Affects Versions: API 2.2.4
> Reporter: Carsten Ziegeler
> Assignee: Ian Boston
> Fix For: API 2.2.6
>
> Attachments: SLING-2538.patch
>
>
> See SLING-2457 for some examples, we currently have some "unusal" handling of some ResourceUtil/AbstractResource methods which are basically there to support very old implementations of the resource api which predate the 2.1.0 release.
> As we now extended the resource interface as well as resource resolver and other stuff, I think it's time to not support this old stuff anymore and clean up the code
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SLING-2538) Remove fallback code for old resource
implementations
Posted by "Carsten Ziegeler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-2538?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carsten Ziegeler updated SLING-2538:
------------------------------------
Issue Type: Improvement (was: Bug)
> Remove fallback code for old resource implementations
> -----------------------------------------------------
>
> Key: SLING-2538
> URL: https://issues.apache.org/jira/browse/SLING-2538
> Project: Sling
> Issue Type: Improvement
> Components: API
> Affects Versions: API 2.2.4
> Reporter: Carsten Ziegeler
> Fix For: API 2.2.6
>
>
> See SLING-2457 for some examples, we currently have some "unusal" handling of some ResourceUtil/AbstractResource methods which are basically there to support very old implementations of the resource api which predate the 2.1.0 release.
> As we now extended the resource interface as well as resource resolver and other stuff, I think it's time to not support this old stuff anymore and clean up the code
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SLING-2538) Remove fallback code for old resource
implementations
Posted by "Ian Boston (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-2538?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ian Boston updated SLING-2538:
------------------------------
Attachment: (was: SLING-2538.patch)
> Remove fallback code for old resource implementations
> -----------------------------------------------------
>
> Key: SLING-2538
> URL: https://issues.apache.org/jira/browse/SLING-2538
> Project: Sling
> Issue Type: Improvement
> Components: API
> Affects Versions: API 2.2.4
> Reporter: Carsten Ziegeler
> Assignee: Ian Boston
> Fix For: API 2.2.6
>
>
> See SLING-2457 for some examples, we currently have some "unusal" handling of some ResourceUtil/AbstractResource methods which are basically there to support very old implementations of the resource api which predate the 2.1.0 release.
> As we now extended the resource interface as well as resource resolver and other stuff, I think it's time to not support this old stuff anymore and clean up the code
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SLING-2538) Remove fallback code for old resource
implementations
Posted by "Ian Boston (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-2538?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ian Boston updated SLING-2538:
------------------------------
Attachment: SLING-2538.patch
Patch Updated and tested.
I am going to leave this over the weekend to give the community a chance to look at it and shout if its going to be a problem for them. If thats Ok, I'll commit it on Monday morning Sydney time.
> Remove fallback code for old resource implementations
> -----------------------------------------------------
>
> Key: SLING-2538
> URL: https://issues.apache.org/jira/browse/SLING-2538
> Project: Sling
> Issue Type: Improvement
> Components: API
> Affects Versions: API 2.2.4
> Reporter: Carsten Ziegeler
> Assignee: Ian Boston
> Fix For: API 2.2.6
>
> Attachments: SLING-2538.patch
>
>
> See SLING-2457 for some examples, we currently have some "unusal" handling of some ResourceUtil/AbstractResource methods which are basically there to support very old implementations of the resource api which predate the 2.1.0 release.
> As we now extended the resource interface as well as resource resolver and other stuff, I think it's time to not support this old stuff anymore and clean up the code
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2538) Remove fallback code for old
resource implementations
Posted by "Carsten Ziegeler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-2538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13484731#comment-13484731 ]
Carsten Ziegeler commented on SLING-2538:
-----------------------------------------
Patch looks good, I would also move the code from the ResourceUtil.internalIsA into the Resource class.
> Remove fallback code for old resource implementations
> -----------------------------------------------------
>
> Key: SLING-2538
> URL: https://issues.apache.org/jira/browse/SLING-2538
> Project: Sling
> Issue Type: Improvement
> Components: API
> Affects Versions: API 2.2.4
> Reporter: Carsten Ziegeler
> Fix For: API 2.2.6
>
> Attachments: SLING-2538.patch
>
>
> See SLING-2457 for some examples, we currently have some "unusal" handling of some ResourceUtil/AbstractResource methods which are basically there to support very old implementations of the resource api which predate the 2.1.0 release.
> As we now extended the resource interface as well as resource resolver and other stuff, I think it's time to not support this old stuff anymore and clean up the code
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Reopened] (SLING-2538) Remove fallback code for old
resource implementations
Posted by "Ian Boston (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-2538?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ian Boston reopened SLING-2538:
-------------------------------
CI on 1.5 is reporting test failiures, reopening.
https://builds.apache.org/job/sling-trunk-1.5/org.apache.sling$org.apache.sling.jcr.resource/1835/testReport/
> Remove fallback code for old resource implementations
> -----------------------------------------------------
>
> Key: SLING-2538
> URL: https://issues.apache.org/jira/browse/SLING-2538
> Project: Sling
> Issue Type: Improvement
> Components: API
> Affects Versions: API 2.2.4
> Reporter: Carsten Ziegeler
> Assignee: Ian Boston
> Fix For: API 2.2.6
>
> Attachments: SLING-2538.patch
>
>
> See SLING-2457 for some examples, we currently have some "unusal" handling of some ResourceUtil/AbstractResource methods which are basically there to support very old implementations of the resource api which predate the 2.1.0 release.
> As we now extended the resource interface as well as resource resolver and other stuff, I think it's time to not support this old stuff anymore and clean up the code
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira