You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2020/06/08 10:43:00 UTC
[jira] [Commented] (WICKET-6794) Improve performance of UrlEncoder
and UrlDecoder
[ https://issues.apache.org/jira/browse/WICKET-6794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17128148#comment-17128148 ]
ASF subversion and git services commented on WICKET-6794:
---------------------------------------------------------
Commit 2666c8ea6ba7a5d30d259269a4e0cf6d32df0f64 in wicket's branch refs/heads/master from Thomas Heigl
[ https://gitbox.apache.org/repos/asf?p=wicket.git;h=2666c8e ]
WICKET-6794 Base `UrlEncoder` and `UrlDecoder` on Spring's `UriUtils` instead of the JDK classes
> Improve performance of UrlEncoder and UrlDecoder
> ------------------------------------------------
>
> Key: WICKET-6794
> URL: https://issues.apache.org/jira/browse/WICKET-6794
> Project: Wicket
> Issue Type: Improvement
> Components: wicket-core
> Affects Versions: 9.0.0-M5
> Reporter: Thomas Heigl
> Assignee: Thomas Heigl
> Priority: Minor
> Fix For: 9.0.0-M6
>
>
> Wicket's {{UrlEncoder}} and {{UrlDecoder}} are customized versions of {{java.net.URLEncoder}} adapted to support conditional encoding of space for paths vs queries.
> The implementation of {{java.net.URLEncoder}} is far from optimal and frameworks such as Spring and Apache HttpClient use their own, much faster implementations.
> Since both of these classes showed up prominently in my production profiler, I would suggest to replace the current implementation with the quite elegant one in Spring's {{UriUtils}}.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)