You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by GitBox <gi...@apache.org> on 2021/01/19 13:07:13 UTC
[GitHub] [carbondata] QiangCai opened a new pull request #4078: [CARBONDATA-4075] Refactor code use withEvents instead of fireEvent
QiangCai opened a new pull request #4078:
URL: https://github.com/apache/carbondata/pull/4078
### Why is this PR needed?
withEvents method can simply code to fire event
### What changes were proposed in this PR?
Refactor code use the withEvents method instead of fireEvent
### Does this PR introduce any user interface change?
- No
### Is any new testcase added?
- No
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4078: [CARBONDATA-4075] Using withEvents instead of fireEvent
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4078:
URL: https://github.com/apache/carbondata/pull/4078#issuecomment-797238704
Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12444/job/ApacheCarbon_PR_Builder_2.4.5/3793/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4078: [CARBONDATA-4075] Using withEvents instead of fireEvent
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4078:
URL: https://github.com/apache/carbondata/pull/4078#issuecomment-787049871
Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12444/job/ApacheCarbon_PR_Builder_2.4.5/3757/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] QiangCai commented on pull request #4078: [CARBONDATA-4075] Using withEvents instead of fireEvent
Posted by GitBox <gi...@apache.org>.
QiangCai commented on pull request #4078:
URL: https://github.com/apache/carbondata/pull/4078#issuecomment-787034910
@Indhumathi27 done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] Indhumathi27 commented on pull request #4078: [CARBONDATA-4075] Using withEvents instead of fireEvent
Posted by GitBox <gi...@apache.org>.
Indhumathi27 commented on pull request #4078:
URL: https://github.com/apache/carbondata/pull/4078#issuecomment-775715984
@QiangCai please rebase
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4078: [CARBONDATA-4075] Using withEvents instead of fireEvent
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4078:
URL: https://github.com/apache/carbondata/pull/4078#issuecomment-795238993
Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/5053/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4078: [CARBONDATA-4075] Using withEvents instead of fireEvent
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4078:
URL: https://github.com/apache/carbondata/pull/4078#issuecomment-766553329
Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3290/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4078: [CARBONDATA-4075] Using withEvents instead of fireEvent
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4078:
URL: https://github.com/apache/carbondata/pull/4078#issuecomment-796603559
Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12444/job/ApacheCarbonPRBuilder2.3/5550/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] Indhumathi27 commented on a change in pull request #4078: [CARBONDATA-4075] Using withEvents instead of fireEvent
Posted by GitBox <gi...@apache.org>.
Indhumathi27 commented on a change in pull request #4078:
URL: https://github.com/apache/carbondata/pull/4078#discussion_r586150541
##########
File path: integration/spark/src/main/scala/org/apache/spark/sql/execution/command/management/CarbonAlterTableCompactionCommand.scala
##########
@@ -74,7 +74,7 @@ case class CarbonAlterTableCompactionCommand(
CarbonTable.buildFromTableInfo(tableInfoOp.get)
} else {
val relation = CarbonEnv.getInstance(sparkSession).carbonMetaStore
- .lookupRelation(Option(dbName), tableName)(sparkSession).asInstanceOf[CarbonRelation]
+ .lookupRelation(Option(dbName), tableName)(sparkSession)
Review comment:
please remove unused carbonrelation import also
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4078: [CARBONDATA-4075] Refactor code to use withEvents instead of fireEvent
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4078:
URL: https://github.com/apache/carbondata/pull/4078#issuecomment-765088260
Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12444/job/ApacheCarbonPRBuilder2.3/5333/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] QiangCai commented on pull request #4078: [CARBONDATA-4075] Refactor code to use withEvents instead of fireEvent
Posted by GitBox <gi...@apache.org>.
QiangCai commented on pull request #4078:
URL: https://github.com/apache/carbondata/pull/4078#issuecomment-765053051
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4078: [CARBONDATA-4075] Using withEvents instead of fireEvent
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4078:
URL: https://github.com/apache/carbondata/pull/4078#issuecomment-796605615
Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12444/job/ApacheCarbon_PR_Builder_2.4.5/3784/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4078: [CARBONDATA-4075] Using withEvents instead of fireEvent
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4078:
URL: https://github.com/apache/carbondata/pull/4078#issuecomment-788592710
Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3342/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4078: [CARBONDATA-4075] Refactor code to use withEvents instead of fireEvent
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4078:
URL: https://github.com/apache/carbondata/pull/4078#issuecomment-763307623
Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12444/job/ApacheCarbon_PR_Builder_2.4.5/3557/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] Indhumathi27 commented on pull request #4078: [CARBONDATA-4075] Using withEvents instead of fireEvent
Posted by GitBox <gi...@apache.org>.
Indhumathi27 commented on pull request #4078:
URL: https://github.com/apache/carbondata/pull/4078#issuecomment-789482217
@QiangCai i think you can refactor fireEevents in SIRebuildSegmentRunner class
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4078: [CARBONDATA-4075] Refactor code use withEvents instead of fireEvent
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4078:
URL: https://github.com/apache/carbondata/pull/4078#issuecomment-762873450
Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12444/job/ApacheCarbon_PR_Builder_2.4.5/3556/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4078: [CARBONDATA-4075] Refactor code to use withEvents instead of fireEvent
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4078:
URL: https://github.com/apache/carbondata/pull/4078#issuecomment-765091491
Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12444/job/ApacheCarbon_PR_Builder_2.4.5/3573/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] QiangCai commented on pull request #4078: [CARBONDATA-4075] Refactor code to use withEvents instead of fireEvent
Posted by GitBox <gi...@apache.org>.
QiangCai commented on pull request #4078:
URL: https://github.com/apache/carbondata/pull/4078#issuecomment-765053051
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4078: [CARBONDATA-4075] Refactor code use withEvents instead of fireEvent
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4078:
URL: https://github.com/apache/carbondata/pull/4078#issuecomment-762873216
Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12444/job/ApacheCarbonPRBuilder2.3/5316/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4078: [CARBONDATA-4075] Using withEvents instead of fireEvent
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4078:
URL: https://github.com/apache/carbondata/pull/4078#issuecomment-795231030
Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3295/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] Indhumathi27 commented on pull request #4078: [CARBONDATA-4075] Using withEvents instead of fireEvent
Posted by GitBox <gi...@apache.org>.
Indhumathi27 commented on pull request #4078:
URL: https://github.com/apache/carbondata/pull/4078#issuecomment-797352431
LGTM
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4078: [CARBONDATA-4075] Refactor code to use withEvents instead of fireEvent
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4078:
URL: https://github.com/apache/carbondata/pull/4078#issuecomment-765088260
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4078: [CARBONDATA-4075] Refactor code to use withEvents instead of fireEvent
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4078:
URL: https://github.com/apache/carbondata/pull/4078#issuecomment-763306439
Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12444/job/ApacheCarbonPRBuilder2.3/5317/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4078: [CARBONDATA-4075] Using withEvents instead of fireEvent
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4078:
URL: https://github.com/apache/carbondata/pull/4078#issuecomment-766553109
Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/5048/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] VenuReddy2103 commented on pull request #4078: [CARBONDATA-4075] Using withEvents instead of fireEvent
Posted by GitBox <gi...@apache.org>.
VenuReddy2103 commented on pull request #4078:
URL: https://github.com/apache/carbondata/pull/4078#issuecomment-797368071
LGTM
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] VenuReddy2103 commented on pull request #4078: [CARBONDATA-4075] Using withEvents instead of fireEvent
Posted by GitBox <gi...@apache.org>.
VenuReddy2103 commented on pull request #4078:
URL: https://github.com/apache/carbondata/pull/4078#issuecomment-769842827
We still seem to have few more pre and post events being fired in conventional way. Yet to change them too ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] QiangCai commented on pull request #4078: [CARBONDATA-4075] Using withEvents instead of fireEvent
Posted by GitBox <gi...@apache.org>.
QiangCai commented on pull request #4078:
URL: https://github.com/apache/carbondata/pull/4078#issuecomment-796521588
@Indhumathi27 done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4078: [CARBONDATA-4075] Using withEvents instead of fireEvent
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4078:
URL: https://github.com/apache/carbondata/pull/4078#issuecomment-788596393
Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/5101/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4078: [CARBONDATA-4075] Using withEvents instead of fireEvent
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4078:
URL: https://github.com/apache/carbondata/pull/4078#issuecomment-766553109
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] Indhumathi27 commented on pull request #4078: [CARBONDATA-4075] Using withEvents instead of fireEvent
Posted by GitBox <gi...@apache.org>.
Indhumathi27 commented on pull request #4078:
URL: https://github.com/apache/carbondata/pull/4078#issuecomment-797199630
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4078: [CARBONDATA-4075] Using withEvents instead of fireEvent
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4078:
URL: https://github.com/apache/carbondata/pull/4078#issuecomment-787049266
Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12444/job/ApacheCarbonPRBuilder2.3/5522/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4078: [CARBONDATA-4075] Using withEvents instead of fireEvent
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4078:
URL: https://github.com/apache/carbondata/pull/4078#issuecomment-797237888
Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12444/job/ApacheCarbonPRBuilder2.3/5559/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] asfgit closed pull request #4078: [CARBONDATA-4075] Using withEvents instead of fireEvent
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #4078:
URL: https://github.com/apache/carbondata/pull/4078
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] QiangCai commented on pull request #4078: [CARBONDATA-4075] Using withEvents instead of fireEvent
Posted by GitBox <gi...@apache.org>.
QiangCai commented on pull request #4078:
URL: https://github.com/apache/carbondata/pull/4078#issuecomment-787036665
@VenuReddy2103
I checked all places, but 14 places still keep the same with previous.
1) in 9 places, it uses only one event, fireEvent is ok.
2) in 4 places, preEvent and postEvent are in the different code blocks.
3) in 1 place, there is a large code block between preEvent and postEvent.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org