You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by "harshithasudhakar (via GitHub)" <gi...@apache.org> on 2023/04/05 05:51:12 UTC
[GitHub] [eventmesh] harshithasudhakar opened a new pull request, #3630: [ISSUE#3483]Replace this call to "replaceAll()" by a call to the "replace()" method.[PushConsumerImpl]
harshithasudhakar opened a new pull request, #3630:
URL: https://github.com/apache/eventmesh/pull/3630
Fixes #3483
### Motivation
When String::replaceAll is used, the first argument should be a real regular expression. If it’s not the case, String::replace does exactly the same thing as String::replaceAll without the performance drawback of the regex.
### Modifications
Replaced "replaceAll()" with "replace()"
### Documentation
- Does this pull request introduce a new feature? (yes / no)
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [eventmesh] xwm1992 merged pull request #3630: [ISSUE #3483]Replace this call to "replaceAll()" by a call to the "replace()" method.[PushConsumerImpl]
Posted by "xwm1992 (via GitHub)" <gi...@apache.org>.
xwm1992 merged PR #3630:
URL: https://github.com/apache/eventmesh/pull/3630
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [eventmesh] codecov[bot] commented on pull request #3630: [ISSUE #3483]Replace this call to "replaceAll()" by a call to the "replace()" method.[PushConsumerImpl]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #3630:
URL: https://github.com/apache/eventmesh/pull/3630#issuecomment-1498406366
## [Codecov](https://codecov.io/gh/apache/eventmesh/pull/3630?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#3630](https://codecov.io/gh/apache/eventmesh/pull/3630?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (03fd6fe) into [master](https://codecov.io/gh/apache/eventmesh/commit/4eb819f6938749b0e22c54dc905f9d055589cb37?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4eb819f) will **decrease** coverage by `0.01%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head 03fd6fe differs from pull request most recent head dddfdf0. Consider uploading reports for the commit dddfdf0 to get more accurate results
```diff
@@ Coverage Diff @@
## master #3630 +/- ##
============================================
- Coverage 13.76% 13.75% -0.01%
- Complexity 1291 1292 +1
============================================
Files 571 571
Lines 29239 29232 -7
Branches 2885 2873 -12
============================================
- Hits 4024 4022 -2
+ Misses 24841 24838 -3
+ Partials 374 372 -2
```
| [Impacted Files](https://codecov.io/gh/apache/eventmesh/pull/3630?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...sh/storage/rocketmq/consumer/PushConsumerImpl.java](https://codecov.io/gh/apache/eventmesh/pull/3630?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXN0b3JhZ2UtcGx1Z2luL2V2ZW50bWVzaC1zdG9yYWdlLXJvY2tldG1xL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvc3RvcmFnZS9yb2NrZXRtcS9jb25zdW1lci9QdXNoQ29uc3VtZXJJbXBsLmphdmE=) | `24.47% <0.00%> (ø)` | |
... and [8 files with indirect coverage changes](https://codecov.io/gh/apache/eventmesh/pull/3630/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org