[GitHub] [incubator-brpc] wenweihu86 commented on a change in pull request #723: fix build scripts under mac os env and add building section for README

[GitBox <gi...@apache.org>]

wenweihu86 commented on a change in pull request #723: fix build  scripts under mac os env and add building section for README
URL: https://github.com/apache/incubator-brpc/pull/723#discussion_r274752102
 
 

 ##########
 File path: config_brpc.sh
 ##########
 @@ -138,7 +138,12 @@ find_dir_of_header_or_die() {
 
 # Inconvenient to check these headers in baidu-internal
 #PTHREAD_HDR=$(find_dir_of_header_or_die pthread.h)
-OPENSSL_HDR=$(find_dir_of_header_or_die openssl/ssl.h)
+if [ "$SYSTEM" = "Darwin" ]; then
+    OPENSSL_HDR="/usr/local/Cellar/openssl\@1.1/1.1.1b/include"
+    OPENSSL_LIB="/usr/local/Cellar/openssl\@1.1/1.1.1b/lib"
+else
+    OPENSSL_HDR=$(find_dir_of_header_or_die openssl/ssl.h)
+fi
 
 Review comment:
   @zyearn 每个release的依赖版本建议定死，我本地试了1.0.2没编译通过。

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org