[jira] [Commented] (DRILL-3640) Drill JDBC driver support Statement.setQueryTimeout(int)

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DRILL-3640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16281219#comment-16281219 ] 

ASF GitHub Bot commented on DRILL-3640:
---------------------------------------

Github user parthchandra commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1024#discussion_r155402523
  
    --- Diff: exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillStatementImpl.java ---
    @@ -156,29 +156,19 @@ public void cleanUp() {
       }
     
       @Override
    -  public int getQueryTimeout() throws AlreadyClosedSqlException
    +  public int getQueryTimeout() throws AlreadyClosedSqlException, SQLException
       {
         throwIfClosed();
    -    return 0;  // (No no timeout.)
    +    return super.getQueryTimeout();
       }
     
       @Override
    -  public void setQueryTimeout( int milliseconds )
    +  public void setQueryTimeout( int seconds )
           throws AlreadyClosedSqlException,
                  InvalidParameterSqlException,
    -             SQLFeatureNotSupportedException {
    +             SQLException {
    --- End diff --
    
    the parent setQueryTimeout will throw a SQLException if the parameter is invalid, so this method now no longer throws an InvalidParameterSqlException


> Drill JDBC driver support Statement.setQueryTimeout(int)
> --------------------------------------------------------
>
>                 Key: DRILL-3640
>                 URL: https://issues.apache.org/jira/browse/DRILL-3640
>             Project: Apache Drill
>          Issue Type: Improvement
>          Components: Client - JDBC
>    Affects Versions: 1.2.0
>            Reporter: Chun Chang
>            Assignee: Kunal Khatua
>             Fix For: 1.13.0
>
>
> It would be nice if we have this implemented. Run away queries can be automatically canceled by setting the timeout. 
> java.sql.SQLFeatureNotSupportedException: Setting network timeout is not supported.
> 	at org.apache.drill.jdbc.impl.DrillStatementImpl.setQueryTimeout(DrillStatementImpl.java:152)



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)