[GitHub] [iceberg] nastra commented on a diff in pull request #7752: Core: Switch tests to Junit5 in deletes,expressions,auth packages

["nastra (via GitHub)" <gi...@apache.org>]

nastra commented on code in PR #7752:
URL: https://github.com/apache/iceberg/pull/7752#discussion_r1213954553


##########
core/src/test/java/org/apache/iceberg/deletes/TestEqualityFilter.java:
##########
@@ -63,14 +64,17 @@ public void testEqualitySetFilterLongColumn() {
             Row.of(7L, "g", "grizzly"),
             Row.of(8L, "h", null));
 
-    Assert.assertEquals(
-        "Filter should produce expected rows",
-        expected,
+    List<StructLike> actual =
         Lists.newArrayList(
             Deletes.filter(
                 ROWS,
                 row -> Row.of(row.get(0, Long.class)),
-                Deletes.toEqualitySet(deletes, ROW_SCHEMA.select("id").asStruct()))));
+                Deletes.toEqualitySet(deletes, ROW_SCHEMA.select("id").asStruct())));
+
+    assertThat(actual)
+        .as("Filter should produce expected rows")
+        .usingRecursiveComparison()

Review Comment:
   why do we need this one? The test passes for me without having `usingRecursiveComparison()`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org