Re: [PR] Fix flush command stack problem and clean old code in DataRegion [iotdb]

["jt2594838 (via GitHub)" <gi...@apache.org>]

jt2594838 commented on code in PR #14027:
URL: https://github.com/apache/iotdb/pull/14027#discussion_r1839678079


##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/flush/FlushManager.java:
##########
@@ -125,32 +121,16 @@ public void runMayThrow() {
   public Future<?> registerTsFileProcessor(TsFileProcessor tsFileProcessor) {
     synchronized (tsFileProcessor) {
       if (tsFileProcessor.isManagedByFlushManager()) {
-        LOGGER.debug(
-            "{} is already in the flushPool, the given processor flushMemtable number = {}",
-            tsFileProcessor.getTsFileResource().getTsFile().getAbsolutePath(),
-            tsFileProcessor.getFlushingMemTableSize());
+        return CompletableFuture.completedFuture(null);

Review Comment:
   Maybe we can store the first future in TsFileProcessor and return it for the rest of the flushes.
   Otherwise, if two users issue flush concurrently, one will wait for a while, and the other will return instantly,
   which may be a little confusing.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org