Re: [PR] Fix serialization of large integers in JSON (#5038) [arrow-rs]

["alamb (via GitHub)" <gi...@apache.org>]

alamb commented on code in PR #5042:
URL: https://github.com/apache/arrow-rs/pull/5042#discussion_r1383374802


##########
arrow-json/src/reader/tape.rs:
##########
@@ -180,7 +180,7 @@ impl<'a> Tape<'a> {
             TapeElement::Null => out.push_str("null"),
             TapeElement::I64(high) => match self.get(idx + 1) {
                 TapeElement::I32(low) => {
-                    let val = (high as i64) << 32 | low as i64;
+                    let val = (high as i64) << 32 | (low as u32) as i64;

Review Comment:
   Can you confirm this code is only used for debugging? it wasn't clear to me that this is covered by a test, but if it is only used in https://github.com/apache/arrow-rs/blob/08b8cba1c5e8876543fcbb4e73da6a891f8ec2f6/arrow-json/src/reader/tape.rs#L210 I don't think that is necessary



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org