You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by el...@apache.org on 2024/10/17 11:43:53 UTC

(maven-dependency-plugin) branch wontfix created (now f3a842a1)

This is an automated email from the ASF dual-hosted git repository.

elharo pushed a change to branch wontfix
in repository https://gitbox.apache.org/repos/asf/maven-dependency-plugin.git


      at f3a842a1 Delete obsolete commented code for issue that was won't fixed 10 years ago

This branch includes the following new commits:

     new f3a842a1 Delete obsolete commented code for issue that was won't fixed 10 years ago

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.



(maven-dependency-plugin) 01/01: Delete obsolete commented code for issue that was won't fixed 10 years ago

Posted by el...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

elharo pushed a commit to branch wontfix
in repository https://gitbox.apache.org/repos/asf/maven-dependency-plugin.git

commit f3a842a1d2aad7f202969b6f2d32232069f76bb5
Author: Elliotte Rusty Harold <el...@ibiblio.org>
AuthorDate: Thu Oct 17 07:43:35 2024 -0400

    Delete obsolete commented code for issue that was won't fixed 10 years ago
---
 .../fromConfiguration/AbstractFromConfigurationMojo.java | 16 +++-------------
 1 file changed, 3 insertions(+), 13 deletions(-)

diff --git a/src/main/java/org/apache/maven/plugins/dependency/fromConfiguration/AbstractFromConfigurationMojo.java b/src/main/java/org/apache/maven/plugins/dependency/fromConfiguration/AbstractFromConfigurationMojo.java
index debac774..7fbedc4a 100644
--- a/src/main/java/org/apache/maven/plugins/dependency/fromConfiguration/AbstractFromConfigurationMojo.java
+++ b/src/main/java/org/apache/maven/plugins/dependency/fromConfiguration/AbstractFromConfigurationMojo.java
@@ -192,24 +192,14 @@ public abstract class AbstractFromConfigurationMojo extends AbstractDependencyMo
      * Resolves the Artifact from the remote repository if necessary. If no version is specified, it will be retrieved
      * from the dependency list or from the DependencyManagement section of the pom.
      *
-     * @param artifactItem containing information about artifact from plugin configuration.
-     * @return Artifact object representing the specified file.
-     * @throws MojoExecutionException with a message if the version can't be found in DependencyManagement.
+     * @param artifactItem containing information about artifact from plugin configuration
+     * @return Artifact object representing the specified file
+     * @throws MojoExecutionException if the version can't be found in DependencyManagement
      */
     protected Artifact getArtifact(ArtifactItem artifactItem) throws MojoExecutionException {
         Artifact artifact;
 
         try {
-            // mdep-50 - rolledback for now because it's breaking some functionality.
-            /*
-             * List listeners = new ArrayList(); Set theSet = new HashSet(); theSet.add( artifact );
-             * ArtifactResolutionResult artifactResolutionResult = artifactCollector.collect( theSet, project
-             * .getArtifact(), managedVersions, this.local, project.getRemoteArtifactRepositories(),
-             * artifactMetadataSource, null, listeners ); Iterator iter =
-             * artifactResolutionResult.getArtifactResolutionNodes().iterator(); while ( iter.hasNext() ) {
-             * ResolutionNode node = (ResolutionNode) iter.next(); artifact = node.getArtifact(); }
-             */
-
             ProjectBuildingRequest buildingRequest = newResolveArtifactProjectBuildingRequest();
 
             if (localRepositoryDirectory != null) {