You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@knox.apache.org by GitBox <gi...@apache.org> on 2021/11/29 16:03:13 UTC
[GitHub] [knox] smolnar82 opened a new pull request #520: KNOX-2692 - Topology redeployment can be configured to require changes in topologies
smolnar82 opened a new pull request #520:
URL: https://github.com/apache/knox/pull/520
## What changes were proposed in this pull request?
To support backward compatibility, a new Gateway-level configuration is introduced to allow end-users to configure if they require changes in topologies for redeployment or a simple `touch` is enough (relying on the topology file's timestamp).
## How was this patch tested?
Updated and executed JUnit tests. In addition to unit testing, I ran the following manual test steps:
- redeployed Knox w/ my changes
- confirmed that `touch conf/topologies/sandbox.xml` re-deployed the `sandbox` topology
- edit `gateway-site.xml` (set `gateway.topology.redeploy.requires.changes=true`) and re-started Knox
- confirmed that
- `touch conf/topologies/sandbox.xml` did not re-deploy the `sandbox` topology
- `bin/knoxcli.sh redeploy --cluster sandbox` re-deployed the `sandbox` topology
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@knox.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [knox] smolnar82 commented on pull request #520: KNOX-2692 - Topology redeployment can be configured to require changes in topologies
Posted by GitBox <gi...@apache.org>.
smolnar82 commented on pull request #520:
URL: https://github.com/apache/knox/pull/520#issuecomment-981775948
Cc. @zeroflag
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@knox.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [knox] zeroflag commented on pull request #520: KNOX-2692 - Topology redeployment can be configured to require changes in topologies
Posted by GitBox <gi...@apache.org>.
zeroflag commented on pull request #520:
URL: https://github.com/apache/knox/pull/520#issuecomment-981808364
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@knox.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [knox] smolnar82 merged pull request #520: KNOX-2692 - Topology redeployment can be configured to require changes in topologies
Posted by GitBox <gi...@apache.org>.
smolnar82 merged pull request #520:
URL: https://github.com/apache/knox/pull/520
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@knox.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org