Re: [PR] [MINOR UPDATE] Shard CI tests and raise the surefire fork count (drill)

["shfshihuafeng (via GitHub)" <gi...@apache.org>]

shfshihuafeng commented on code in PR #3079:
URL: https://github.com/apache/drill/pull/3079#discussion_r4208050991


##########
.github/workflows/ci.yml:
##########
@@ -57,9 +63,36 @@ jobs:
             mkswap /tmp/swapfile
             swapon /tmp/swapfile
           "
+      # Which slice of the suite this job runs. The patterns are spelled out one prefix
+      # at a time because surefire does NOT support character-class globs:
+      # -Dtest='Test[A-F]*' silently matches nothing and the build passes green having
+      # run no tests. Only '*' wildcards and comma separated lists work, so each letter
+      # gets its own entry, in both cases (TestforBaseTestInheritance has a lowercase f).
+      #
+      # Shard 3 repeats surefire's other default includes (*Test, *Tests, *TestCase) to
+      # pick up classes not named Test*. Verified exhaustive against every test
+      # class in the repo. TestFrameworkTest matches shards 1 and 3 and runs twice —
+      # harmless, and far safer than a gap that skips tests without saying so.
+      - name: Select test shard
+        id: shard
+        run: |
+          case "${{ matrix.shard }}" in
+            1) echo 'pattern=TestA*,Testa*,TestB*,Testb*,TestC*,Testc*,TestD*,Testd*,TestE*,Teste*,TestF*,Testf*' >> "$GITHUB_OUTPUT" ;;
+            2) echo 'pattern=TestG*,Testg*,TestH*,Testh*,TestI*,Testi*,TestJ*,Testj*,TestK*,Testk*,TestL*,Testl*,TestM*,Testm*,TestN*,Testn*,TestO*,Testo*,TestP*,Testp*' >> "$GITHUB_OUTPUT" ;;
+            3) echo 'pattern=TestQ*,Testq*,TestR*,Testr*,TestS*,Tests*,TestT*,Testt*,TestU*,Testu*,TestV*,Testv*,TestW*,Testw*,TestX*,Testx*,TestY*,Testy*,TestZ*,Testz*,*Test,*Tests,*TestCase,Test0*,Test1*,Test2*,Test3*,Test4*,Test5*,Test6*,Test7*,Test8*,Test9*,Test_*' >> "$GITHUB_OUTPUT" ;;
+          esac

Review Comment:
   Minor: Could you add a default branch to the bash case statement to fail fast on invalid shard values?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org