You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/12/14 01:11:21 UTC

[GitHub] [spark] zero323 commented on a change in pull request #34886: [WIP][SPARK-37632][PYTHON] Drop code that targets Python < 3.7

zero323 commented on a change in pull request #34886:
URL: https://github.com/apache/spark/pull/34886#discussion_r768241629



##########
File path: python/pyspark/ml/stat.py
##########
@@ -100,7 +100,7 @@ def test(dataset, featuresCol, labelCol, flatten=False):
         return _java2py(sc, javaTestObj.test(*args))
 
 
-class Correlation(object):

Review comment:
       For me, it is just one more thing, that requires additional thought, unless you're familiar with Python 2 and the history of the project. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org