[jira] [Commented] (YARN-209) Capacity scheduler doesn't trigger app-activation after adding nodes

["Bikas Saha (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YARN-209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13614819#comment-13614819 ] 

Bikas Saha commented on YARN-209:
---------------------------------

Patch looks good overall. I dont quite see what testActivatingPendingApplication() is buying us in its current form. If the leaf queue test fails before the fix and passes after it, then it should be enough IMO.
                
> Capacity scheduler doesn't trigger app-activation after adding nodes
> --------------------------------------------------------------------
>
>                 Key: YARN-209
>                 URL: https://issues.apache.org/jira/browse/YARN-209
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Bikas Saha
>            Assignee: Zhijie Shen
>             Fix For: 3.0.0
>
>         Attachments: YARN-209.1.patch, YARN-209.2.patch, YARN-209.3.patch, YARN-209-test.patch
>
>
> Say application A is submitted but at that time it does not meet the bar for activation because of resource limit settings for applications. After that if more hardware is added to the system and the application becomes valid it still remains in pending state, likely forever.
> This might be rare to hit in real life because enough NM's heartbeat to the RM before applications can get submitted. But a change in settings or heartbeat interval might make it easier to repro. In RM restart scenarios, this will likely hit more if its implemented by re-playing events and re-submitting applications to the scheduler before the RPC to NM's is activated.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira