[GitHub] [incubator-pekko-management] mdedetrich commented on a diff in pull request #80: Add Scala 3.3 Support

["mdedetrich (via GitHub)" <gi...@apache.org>]

mdedetrich commented on code in PR #80:
URL: https://github.com/apache/incubator-pekko-management/pull/80#discussion_r1207270838


##########
discovery-aws-api/src/test/scala/org/apache/pekko/discovery/awsapi/ec2/Ec2TagBasedSimpleServiceDiscoveryTest.scala:
##########
@@ -25,7 +25,7 @@ class FiltersParsingTest extends AnyFunSuite with Matchers {
   test("empty string does not break parsing") {
     val filters = ""
     val result: List[Filter] = parseFiltersString(filters)
-    result should be('empty)
+    result should be(Symbol("empty"))

Review Comment:
   Isn't `shouldBe empty` for an empty collection/option? In this case we are checking for a string



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org