You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by ma...@apache.org on 2022/10/31 20:02:02 UTC
[tomcat-native] branch main updated: native: Fix the build with rlibtool
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat-native.git
The following commit(s) were added to refs/heads/main by this push:
new 54dccd3a4 native: Fix the build with rlibtool
new 4f7fb7f44 Merge pull request #14 from orbea/slibtool
54dccd3a4 is described below
commit 54dccd3a4dc01801d9311b3160808305ec9fc2cf
Author: orbea <or...@riseup.net>
AuthorDate: Thu Jul 21 17:59:14 2022 -0700
native: Fix the build with rlibtool
When building tomcat-native with slibtool using the rlibtool symlink the
build will fail. This is because rlibtool requires the generated libtool
script to determine if the build is shared, static or both.
Gentoo bug: https://bugs.gentoo.org/778914
---
native/configure.in | 3 +++
1 file changed, 3 insertions(+)
diff --git a/native/configure.in b/native/configure.in
index 567894b10..e082ae6d2 100644
--- a/native/configure.in
+++ b/native/configure.in
@@ -50,6 +50,9 @@ AC_SUBST(TCN_CONFIG_LOCATION)
AC_CANONICAL_TARGET
AC_PROG_INSTALL
+dnl Generate the libtool script which is needed for rlibtool
+LT_INIT
+
dnl
dnl compute the top directory of the build
dnl note: this is needed for LIBTOOL and exporting the bundled Expat
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: [tomcat-native] branch main updated: native: Fix the build with rlibtool
Posted by Mark Thomas <ma...@apache.org>.
On 18/06/2023 13:45, Rainer Jung wrote:
> Am 06.06.23 um 12:57 schrieb Mark Thomas:
>> On 05/06/2023 21:20, Rainer Jung wrote:
>>> Something is wrong with our regeneration of configure in the release
>>> process, at least for the 2.x branch (main). The configure script
>>> contains "LT_INIT" verbatim instead of LT_INIT being replaced by its
>>> script implementation. I can't actually say what is wrong :(
>>>
>>> If I run "autoreconf --force --install" on my system LT_INIT gets
>>> resolved but configure also get much bigger (more than double the size).
>>>
>>> Let me know if you have no good idea and I should investigate deeper.
>>
>> Sorry, no idea here. I tested the PR to the extent I check I could
>> still build with the PR applied but went no deeper. Linux build
>> systems are mostly a mystery to me.
>
> I hope I fixed it today without breaking other stuff. I tested with
> generating a release tarball from the main branch and the tarball deltas
> to 2.0.4 looked reasonable. Also the Makefile generated by configure
> looks consistent. As always things ight vary a bit depending on the
> system used for releases.
Builds looks OK to me here.
Thanks.
Mark
>
> Best regards,
>
> Rainer
>
>>> Am 31.10.22 um 21:02 schrieb markt@apache.org:
>>>> This is an automated email from the ASF dual-hosted git repository.
>>>>
>>>> markt pushed a commit to branch main
>>>> in repository https://gitbox.apache.org/repos/asf/tomcat-native.git
>>>>
>>>>
>>>> The following commit(s) were added to refs/heads/main by this push:
>>>> new 54dccd3a4 native: Fix the build with rlibtool
>>>> new 4f7fb7f44 Merge pull request #14 from orbea/slibtool
>>>> 54dccd3a4 is described below
>>>>
>>>> commit 54dccd3a4dc01801d9311b3160808305ec9fc2cf
>>>> Author: orbea <or...@riseup.net>
>>>> AuthorDate: Thu Jul 21 17:59:14 2022 -0700
>>>>
>>>> native: Fix the build with rlibtool
>>>> When building tomcat-native with slibtool using the rlibtool
>>>> symlink the
>>>> build will fail. This is because rlibtool requires the
>>>> generated libtool
>>>> script to determine if the build is shared, static or both.
>>>> Gentoo bug: https://bugs.gentoo.org/778914
>>>> ---
>>>> native/configure.in | 3 +++
>>>> 1 file changed, 3 insertions(+)
>>>>
>>>> diff --git a/native/configure.in b/native/configure.in
>>>> index 567894b10..e082ae6d2 100644
>>>> --- a/native/configure.in
>>>> +++ b/native/configure.in
>>>> @@ -50,6 +50,9 @@ AC_SUBST(TCN_CONFIG_LOCATION)
>>>> AC_CANONICAL_TARGET
>>>> AC_PROG_INSTALL
>>>> +dnl Generate the libtool script which is needed for rlibtool
>>>> +LT_INIT
>>>> +
>>>> dnl
>>>> dnl compute the top directory of the build
>>>> dnl note: this is needed for LIBTOOL and exporting the bundled Expat
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: [tomcat-native] branch main updated: native: Fix the build with rlibtool
Posted by Rainer Jung <ra...@kippdata.de>.
Am 06.06.23 um 12:57 schrieb Mark Thomas:
> On 05/06/2023 21:20, Rainer Jung wrote:
>> Something is wrong with our regeneration of configure in the release
>> process, at least for the 2.x branch (main). The configure script
>> contains "LT_INIT" verbatim instead of LT_INIT being replaced by its
>> script implementation. I can't actually say what is wrong :(
>>
>> If I run "autoreconf --force --install" on my system LT_INIT gets
>> resolved but configure also get much bigger (more than double the size).
>>
>> Let me know if you have no good idea and I should investigate deeper.
>
> Sorry, no idea here. I tested the PR to the extent I check I could still
> build with the PR applied but went no deeper. Linux build systems are
> mostly a mystery to me.
I hope I fixed it today without breaking other stuff. I tested with
generating a release tarball from the main branch and the tarball deltas
to 2.0.4 looked reasonable. Also the Makefile generated by configure
looks consistent. As always things ight vary a bit depending on the
system used for releases.
Best regards,
Rainer
>> Am 31.10.22 um 21:02 schrieb markt@apache.org:
>>> This is an automated email from the ASF dual-hosted git repository.
>>>
>>> markt pushed a commit to branch main
>>> in repository https://gitbox.apache.org/repos/asf/tomcat-native.git
>>>
>>>
>>> The following commit(s) were added to refs/heads/main by this push:
>>> new 54dccd3a4 native: Fix the build with rlibtool
>>> new 4f7fb7f44 Merge pull request #14 from orbea/slibtool
>>> 54dccd3a4 is described below
>>>
>>> commit 54dccd3a4dc01801d9311b3160808305ec9fc2cf
>>> Author: orbea <or...@riseup.net>
>>> AuthorDate: Thu Jul 21 17:59:14 2022 -0700
>>>
>>> native: Fix the build with rlibtool
>>> When building tomcat-native with slibtool using the rlibtool
>>> symlink the
>>> build will fail. This is because rlibtool requires the generated
>>> libtool
>>> script to determine if the build is shared, static or both.
>>> Gentoo bug: https://bugs.gentoo.org/778914
>>> ---
>>> native/configure.in | 3 +++
>>> 1 file changed, 3 insertions(+)
>>>
>>> diff --git a/native/configure.in b/native/configure.in
>>> index 567894b10..e082ae6d2 100644
>>> --- a/native/configure.in
>>> +++ b/native/configure.in
>>> @@ -50,6 +50,9 @@ AC_SUBST(TCN_CONFIG_LOCATION)
>>> AC_CANONICAL_TARGET
>>> AC_PROG_INSTALL
>>> +dnl Generate the libtool script which is needed for rlibtool
>>> +LT_INIT
>>> +
>>> dnl
>>> dnl compute the top directory of the build
>>> dnl note: this is needed for LIBTOOL and exporting the bundled Expat
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: [tomcat-native] branch main updated: native: Fix the build with rlibtool
Posted by Mark Thomas <ma...@apache.org>.
On 05/06/2023 21:20, Rainer Jung wrote:
> Something is wrong with our regeneration of configure in the release
> process, at least for the 2.x branch (main). The configure script
> contains "LT_INIT" verbatim instead of LT_INIT being replaced by its
> script implementation. I can't actually say what is wrong :(
>
> If I run "autoreconf --force --install" on my system LT_INIT gets
> resolved but configure also get much bigger (more than double the size).
>
> Let me know if you have no good idea and I should investigate deeper.
Sorry, no idea here. I tested the PR to the extent I check I could still
build with the PR applied but went no deeper. Linux build systems are
mostly a mystery to me.
Mark
>
> Thanks and regards,
>
> Rainer
>
> Am 31.10.22 um 21:02 schrieb markt@apache.org:
>> This is an automated email from the ASF dual-hosted git repository.
>>
>> markt pushed a commit to branch main
>> in repository https://gitbox.apache.org/repos/asf/tomcat-native.git
>>
>>
>> The following commit(s) were added to refs/heads/main by this push:
>> new 54dccd3a4 native: Fix the build with rlibtool
>> new 4f7fb7f44 Merge pull request #14 from orbea/slibtool
>> 54dccd3a4 is described below
>>
>> commit 54dccd3a4dc01801d9311b3160808305ec9fc2cf
>> Author: orbea <or...@riseup.net>
>> AuthorDate: Thu Jul 21 17:59:14 2022 -0700
>>
>> native: Fix the build with rlibtool
>> When building tomcat-native with slibtool using the rlibtool
>> symlink the
>> build will fail. This is because rlibtool requires the generated
>> libtool
>> script to determine if the build is shared, static or both.
>> Gentoo bug: https://bugs.gentoo.org/778914
>> ---
>> native/configure.in | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/native/configure.in b/native/configure.in
>> index 567894b10..e082ae6d2 100644
>> --- a/native/configure.in
>> +++ b/native/configure.in
>> @@ -50,6 +50,9 @@ AC_SUBST(TCN_CONFIG_LOCATION)
>> AC_CANONICAL_TARGET
>> AC_PROG_INSTALL
>> +dnl Generate the libtool script which is needed for rlibtool
>> +LT_INIT
>> +
>> dnl
>> dnl compute the top directory of the build
>> dnl note: this is needed for LIBTOOL and exporting the bundled Expat
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
>> For additional commands, e-mail: dev-help@tomcat.apache.org
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: [tomcat-native] branch main updated: native: Fix the build with rlibtool
Posted by Rainer Jung <ra...@kippdata.de>.
Something is wrong with our regeneration of configure in the release
process, at least for the 2.x branch (main). The configure script
contains "LT_INIT" verbatim instead of LT_INIT being replaced by its
script implementation. I can't actually say what is wrong :(
If I run "autoreconf --force --install" on my system LT_INIT gets
resolved but configure also get much bigger (more than double the size).
Let me know if you have no good idea and I should investigate deeper.
Thanks and regards,
Rainer
Am 31.10.22 um 21:02 schrieb markt@apache.org:
> This is an automated email from the ASF dual-hosted git repository.
>
> markt pushed a commit to branch main
> in repository https://gitbox.apache.org/repos/asf/tomcat-native.git
>
>
> The following commit(s) were added to refs/heads/main by this push:
> new 54dccd3a4 native: Fix the build with rlibtool
> new 4f7fb7f44 Merge pull request #14 from orbea/slibtool
> 54dccd3a4 is described below
>
> commit 54dccd3a4dc01801d9311b3160808305ec9fc2cf
> Author: orbea <or...@riseup.net>
> AuthorDate: Thu Jul 21 17:59:14 2022 -0700
>
> native: Fix the build with rlibtool
>
> When building tomcat-native with slibtool using the rlibtool symlink the
> build will fail. This is because rlibtool requires the generated libtool
> script to determine if the build is shared, static or both.
>
> Gentoo bug: https://bugs.gentoo.org/778914
> ---
> native/configure.in | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/native/configure.in b/native/configure.in
> index 567894b10..e082ae6d2 100644
> --- a/native/configure.in
> +++ b/native/configure.in
> @@ -50,6 +50,9 @@ AC_SUBST(TCN_CONFIG_LOCATION)
> AC_CANONICAL_TARGET
> AC_PROG_INSTALL
>
> +dnl Generate the libtool script which is needed for rlibtool
> +LT_INIT
> +
> dnl
> dnl compute the top directory of the build
> dnl note: this is needed for LIBTOOL and exporting the bundled Expat
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org