You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by le...@apache.org on 2020/03/15 16:52:10 UTC

svn commit: r1875212 - /pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdfparser/BaseParser.java

Author: lehmi
Date: Sun Mar 15 16:52:10 2020
New Revision: 1875212

URL: http://svn.apache.org/viewvc?rev=1875212&view=rev
Log:
PDFBOX-3888: simplify parsing of boolean values

Modified:
    pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdfparser/BaseParser.java

Modified: pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdfparser/BaseParser.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdfparser/BaseParser.java?rev=1875212&r1=1875211&r2=1875212&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdfparser/BaseParser.java (original)
+++ pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdfparser/BaseParser.java Sun Mar 15 16:52:10 2020
@@ -849,30 +849,14 @@ public abstract class BaseParser
         }
         case 't':
         {
-            String trueString = new String( seqSource.readFully(4), StandardCharsets.ISO_8859_1 );
-            if( trueString.equals( TRUE ) )
-            {
-                retval = COSBoolean.TRUE;
-            }
-            else
-            {
-                throw new IOException( "expected true actual='" + trueString + "' " + seqSource + 
-                        "' at offset " + seqSource.getPosition());
-            }
+            readExpectedString(TRUE);
+            retval = COSBoolean.TRUE;
             break;
         }
         case 'f':
         {
-            String falseString = new String( seqSource.readFully(5), StandardCharsets.ISO_8859_1 );
-            if( falseString.equals( FALSE ) )
-            {
-                retval = COSBoolean.FALSE;
-            }
-            else
-            {
-                throw new IOException( "expected false actual='" + falseString + "' " + seqSource + 
-                        "' at offset " + seqSource.getPosition());
-            }
+            readExpectedString(FALSE);
+            retval = COSBoolean.FALSE;
             break;
         }
         case 'R':