You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "somiljain2006 (via GitHub)" <gi...@apache.org> on 2026/07/21 10:50:28 UTC
[PR] Support production data source lookup after sharding routing [shardingsphere]
somiljain2006 opened a new pull request, #39205:
URL: https://github.com/apache/shardingsphere/pull/39205
Fixes #37081
Allow findProductionDataSourceName() to resolve production data source names directly after sharding routing. Add unit tests for production data source lookup and shadow routing after sharding.
---
Before committing this PR, I'm sure that I have checked the following options:
- [ ] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [ ] I have self-reviewed the commit code.
- [ ] I have (or in the comment I request) added corresponding labels for the pull request.
- [ ] I have passed Maven check locally: `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
- [ ] I have made corresponding changes to the documentation.
- [ ] I have added corresponding unit tests for my changes.
- [ ] I have updated the Release Notes of the current development version. For more details, see [Update Release Note](https://shardingsphere.apache.org/community/en/involved/contribute/contributor/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Support production data source lookup after sharding routing [shardingsphere]
Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu commented on PR #39205:
URL: https://github.com/apache/shardingsphere/pull/39205#issuecomment-5586804567
The findings from the previous review are retained. There has been no implementation update since the review, and the routing contract remains ambiguous.
The current approach allows the same name to represent both a logical Shadow data source and a physical production data source. When those namespaces overlap, the lookup may resolve to the wrong production database. It can also rebuild and reorder physical route units even when no Shadow mapping matches.
This needs an unambiguous logical/physical route-provenance and name-resolution design before implementation continues. I am closing this PR due to inactivity. Please discuss the contract in [#37081](https://github.com/apache/shardingsphere/issues/37081) before opening a new PR based on the latest `master`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Support production data source lookup after sharding routing [shardingsphere]
Posted by "somiljain2006 (via GitHub)" <gi...@apache.org>.
somiljain2006 commented on PR #39205:
URL: https://github.com/apache/shardingsphere/pull/39205#issuecomment-5033410235
@terrymanu Can you review this pr?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Support production data source lookup after sharding routing [shardingsphere]
Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu closed pull request #39205: Support production data source lookup after sharding routing
URL: https://github.com/apache/shardingsphere/pull/39205
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org