You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@samza.apache.org by "Martin Kleppmann (JIRA)" <ji...@apache.org> on 2014/03/07 19:49:46 UTC

[jira] [Updated] (SAMZA-16) Test Samza with Java 7

     [ https://issues.apache.org/jira/browse/SAMZA-16?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Martin Kleppmann updated SAMZA-16:
----------------------------------

    Attachment: SAMZA-16.patch

Ok, I've reproduced that test failure, and I think I've fixed it. Patch attached, rb: https://reviews.apache.org/r/18915/

The failure was due to state leakage between the two tests in the TestTopicMetadataCache class. They would pass if executed in the order they appear in the file, and fail if executed in the reverse order. Java 7 must have changed something about the order of methods returned by reflection APIs. I've fixed the tests to not leak state, so they should execute fine in any order.

I've also replaced the use of "assert" with "assertEquals", in order to get better error messages on test failure.

> Test Samza with Java 7
> ----------------------
>
>                 Key: SAMZA-16
>                 URL: https://issues.apache.org/jira/browse/SAMZA-16
>             Project: Samza
>          Issue Type: Bug
>          Components: test
>    Affects Versions: 0.6.0
>            Reporter: Chris Riccomini
>            Assignee: Martin Kleppmann
>         Attachments: SAMZA-16.patch
>
>
> We should try running Samza with Java 7.
> Linking to a ticket that shows a build issue in with Samza on Java 7.



--
This message was sent by Atlassian JIRA
(v6.2#6252)