[GitHub] [storm] Ethanlm commented on a change in pull request #3406: STORM-3786 ensure v2 metrics tick reporting occurs at specified interval

[GitBox <gi...@apache.org>]

Ethanlm commented on a change in pull request #3406:
URL: https://github.com/apache/storm/pull/3406#discussion_r679959591



##########
File path: storm-client/src/jvm/org/apache/storm/executor/Executor.java
##########
@@ -462,6 +473,30 @@ protected void setupMetrics() {
                     }
                 }
             );
+            if (interval == v2MetricsTickInterval) {
+                v2TickScheduled = true;
+            }
+        }
+
+        if (!v2TickScheduled) {
+            LOG.info("Scheduling v2 metrics tick for interval {}", v2MetricsTickInterval);
+            StormTimer timerTask = workerData.getUserTimer();

Review comment:
       This code looks similar to above. Can we de-duplicate?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@storm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org