You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Greg Mann <gr...@mesosphere.io> on 2019/07/08 18:28:15 UTC
Review Request 71035: Added test to verify that Docker executor can
override kill policy.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71035/
-----------------------------------------------------------
Review request for mesos, Benno Evers, Benjamin Mahler, and Joseph Wu.
Bugs: MESOS-9853
https://issues.apache.org/jira/browse/MESOS-9853
Repository: mesos
Description
-------
This adds a test which verifies that when a scheduler attemps to
override a task's default kill policy, the Docker executor will
honor that override.
Diffs
-----
src/internal/evolve.hpp ffbb342a42ec3501383500dee55dff3588725478
src/internal/evolve.cpp 81de15e192580d2f35237e124c11902e1fc67a1d
src/tests/containerizer/docker_containerizer_tests.cpp a6217581e20168c5114f733323e927a83ac59fd0
Diff: https://reviews.apache.org/r/71035/diff/1/
Testing
-------
`make check`
`sudo bin/mesos-tests.sh --gtest_filter="*ROOT_DOCKER_OverrideKillPolicy*" --gtest_repeat=-1 --gtest_break_on_failure`
Verified that this new test fails on current master, and passes when the preceding patches in this chain are applied.
Thanks,
Greg Mann
Re: Review Request 71035: Added test to verify that Docker executor
can override kill policy.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71035/#review216622
-----------------------------------------------------------
Ship it!
Ship It!
- Joseph Wu
On July 8, 2019, 11:28 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71035/
> -----------------------------------------------------------
>
> (Updated July 8, 2019, 11:28 a.m.)
>
>
> Review request for mesos, Benno Evers, Benjamin Mahler, and Joseph Wu.
>
>
> Bugs: MESOS-9853
> https://issues.apache.org/jira/browse/MESOS-9853
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This adds a test which verifies that when a scheduler attemps to
> override a task's default kill policy, the Docker executor will
> honor that override.
>
>
> Diffs
> -----
>
> src/internal/evolve.hpp ffbb342a42ec3501383500dee55dff3588725478
> src/internal/evolve.cpp 81de15e192580d2f35237e124c11902e1fc67a1d
> src/tests/containerizer/docker_containerizer_tests.cpp a6217581e20168c5114f733323e927a83ac59fd0
>
>
> Diff: https://reviews.apache.org/r/71035/diff/1/
>
>
> Testing
> -------
>
> `make check`
> `sudo bin/mesos-tests.sh --gtest_filter="*ROOT_DOCKER_OverrideKillPolicy*" --gtest_repeat=-1 --gtest_break_on_failure`
>
> Verified that this new test fails on current master, and passes when the preceding patches in this chain are applied.
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 71035: Added test to verify that Docker executor
can override kill policy.
Posted by Benno Evers <be...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71035/#review216502
-----------------------------------------------------------
Ship it!
Ship It!
- Benno Evers
On July 8, 2019, 6:28 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71035/
> -----------------------------------------------------------
>
> (Updated July 8, 2019, 6:28 p.m.)
>
>
> Review request for mesos, Benno Evers, Benjamin Mahler, and Joseph Wu.
>
>
> Bugs: MESOS-9853
> https://issues.apache.org/jira/browse/MESOS-9853
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This adds a test which verifies that when a scheduler attemps to
> override a task's default kill policy, the Docker executor will
> honor that override.
>
>
> Diffs
> -----
>
> src/internal/evolve.hpp ffbb342a42ec3501383500dee55dff3588725478
> src/internal/evolve.cpp 81de15e192580d2f35237e124c11902e1fc67a1d
> src/tests/containerizer/docker_containerizer_tests.cpp a6217581e20168c5114f733323e927a83ac59fd0
>
>
> Diff: https://reviews.apache.org/r/71035/diff/1/
>
>
> Testing
> -------
>
> `make check`
> `sudo bin/mesos-tests.sh --gtest_filter="*ROOT_DOCKER_OverrideKillPolicy*" --gtest_repeat=-1 --gtest_break_on_failure`
>
> Verified that this new test fails on current master, and passes when the preceding patches in this chain are applied.
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 71035: Added test to verify that Docker executor
can override kill policy.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71035/#review216442
-----------------------------------------------------------
Patch looks great!
Reviews applied: [71033, 71034, 71035]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On July 8, 2019, 6:28 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71035/
> -----------------------------------------------------------
>
> (Updated July 8, 2019, 6:28 p.m.)
>
>
> Review request for mesos, Benno Evers, Benjamin Mahler, and Joseph Wu.
>
>
> Bugs: MESOS-9853
> https://issues.apache.org/jira/browse/MESOS-9853
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This adds a test which verifies that when a scheduler attemps to
> override a task's default kill policy, the Docker executor will
> honor that override.
>
>
> Diffs
> -----
>
> src/internal/evolve.hpp ffbb342a42ec3501383500dee55dff3588725478
> src/internal/evolve.cpp 81de15e192580d2f35237e124c11902e1fc67a1d
> src/tests/containerizer/docker_containerizer_tests.cpp a6217581e20168c5114f733323e927a83ac59fd0
>
>
> Diff: https://reviews.apache.org/r/71035/diff/1/
>
>
> Testing
> -------
>
> `make check`
> `sudo bin/mesos-tests.sh --gtest_filter="*ROOT_DOCKER_OverrideKillPolicy*" --gtest_repeat=-1 --gtest_break_on_failure`
>
> Verified that this new test fails on current master, and passes when the preceding patches in this chain are applied.
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 71035: Added test to verify that Docker executor
can override kill policy.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71035/#review216868
-----------------------------------------------------------
Patch looks great!
Reviews applied: [71033, 71034, 71035]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On July 8, 2019, 6:28 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71035/
> -----------------------------------------------------------
>
> (Updated July 8, 2019, 6:28 p.m.)
>
>
> Review request for mesos, Benno Evers, Benjamin Mahler, and Joseph Wu.
>
>
> Bugs: MESOS-9853
> https://issues.apache.org/jira/browse/MESOS-9853
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This adds a test which verifies that when a scheduler attemps to
> override a task's default kill policy, the Docker executor will
> honor that override.
>
>
> Diffs
> -----
>
> src/internal/evolve.hpp ffbb342a42ec3501383500dee55dff3588725478
> src/internal/evolve.cpp 81de15e192580d2f35237e124c11902e1fc67a1d
> src/tests/containerizer/docker_containerizer_tests.cpp a6217581e20168c5114f733323e927a83ac59fd0
>
>
> Diff: https://reviews.apache.org/r/71035/diff/1/
>
>
> Testing
> -------
>
> `make check`
> `sudo bin/mesos-tests.sh --gtest_filter="*ROOT_DOCKER_OverrideKillPolicy*" --gtest_repeat=-1 --gtest_break_on_failure`
>
> Verified that this new test fails on current master, and passes when the preceding patches in this chain are applied.
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 71035: Added test to verify that Docker executor
can override kill policy.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71035/#review216506
-----------------------------------------------------------
Patch looks great!
Reviews applied: [71033, 71034, 71035]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On July 8, 2019, 11:28 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71035/
> -----------------------------------------------------------
>
> (Updated July 8, 2019, 11:28 a.m.)
>
>
> Review request for mesos, Benno Evers, Benjamin Mahler, and Joseph Wu.
>
>
> Bugs: MESOS-9853
> https://issues.apache.org/jira/browse/MESOS-9853
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This adds a test which verifies that when a scheduler attemps to
> override a task's default kill policy, the Docker executor will
> honor that override.
>
>
> Diffs
> -----
>
> src/internal/evolve.hpp ffbb342a42ec3501383500dee55dff3588725478
> src/internal/evolve.cpp 81de15e192580d2f35237e124c11902e1fc67a1d
> src/tests/containerizer/docker_containerizer_tests.cpp a6217581e20168c5114f733323e927a83ac59fd0
>
>
> Diff: https://reviews.apache.org/r/71035/diff/1/
>
>
> Testing
> -------
>
> `make check`
> `sudo bin/mesos-tests.sh --gtest_filter="*ROOT_DOCKER_OverrideKillPolicy*" --gtest_repeat=-1 --gtest_break_on_failure`
>
> Verified that this new test fails on current master, and passes when the preceding patches in this chain are applied.
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 71035: Added test to verify that Docker executor
can override kill policy.
Posted by Greg Mann <gr...@mesosphere.io>.
> On July 10, 2019, 3:27 p.m., Benno Evers wrote:
> > src/tests/containerizer/docker_containerizer_tests.cpp
> > Lines 5250 (patched)
> > <https://reviews.apache.org/r/71035/diff/1/?file=2153977#file2153977line5250>
> >
> > The test itself looks good, but is it possible to run it with a stopped clock? Given the various timers involved in the body, this feels like a prime candidate to become flaky sooner or later.
I ran into issues using a stopped clock due to the use of the Docker runtime. I'm not sure precisely why, but it seems that some Docker containerizer operations require the clock to be running; currently, no tests in this file stop the clock :-/
- Greg
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71035/#review216483
-----------------------------------------------------------
On July 8, 2019, 6:28 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71035/
> -----------------------------------------------------------
>
> (Updated July 8, 2019, 6:28 p.m.)
>
>
> Review request for mesos, Benno Evers, Benjamin Mahler, and Joseph Wu.
>
>
> Bugs: MESOS-9853
> https://issues.apache.org/jira/browse/MESOS-9853
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This adds a test which verifies that when a scheduler attemps to
> override a task's default kill policy, the Docker executor will
> honor that override.
>
>
> Diffs
> -----
>
> src/internal/evolve.hpp ffbb342a42ec3501383500dee55dff3588725478
> src/internal/evolve.cpp 81de15e192580d2f35237e124c11902e1fc67a1d
> src/tests/containerizer/docker_containerizer_tests.cpp a6217581e20168c5114f733323e927a83ac59fd0
>
>
> Diff: https://reviews.apache.org/r/71035/diff/1/
>
>
> Testing
> -------
>
> `make check`
> `sudo bin/mesos-tests.sh --gtest_filter="*ROOT_DOCKER_OverrideKillPolicy*" --gtest_repeat=-1 --gtest_break_on_failure`
>
> Verified that this new test fails on current master, and passes when the preceding patches in this chain are applied.
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 71035: Added test to verify that Docker executor
can override kill policy.
Posted by Benno Evers <be...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71035/#review216483
-----------------------------------------------------------
src/tests/containerizer/docker_containerizer_tests.cpp
Lines 5250 (patched)
<https://reviews.apache.org/r/71035/#comment303717>
The test itself looks good, but is it possible to run it with a stopped clock? Given the various timers involved in the body, this feels like a prime candidate to become flaky sooner or later.
- Benno Evers
On July 8, 2019, 6:28 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71035/
> -----------------------------------------------------------
>
> (Updated July 8, 2019, 6:28 p.m.)
>
>
> Review request for mesos, Benno Evers, Benjamin Mahler, and Joseph Wu.
>
>
> Bugs: MESOS-9853
> https://issues.apache.org/jira/browse/MESOS-9853
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This adds a test which verifies that when a scheduler attemps to
> override a task's default kill policy, the Docker executor will
> honor that override.
>
>
> Diffs
> -----
>
> src/internal/evolve.hpp ffbb342a42ec3501383500dee55dff3588725478
> src/internal/evolve.cpp 81de15e192580d2f35237e124c11902e1fc67a1d
> src/tests/containerizer/docker_containerizer_tests.cpp a6217581e20168c5114f733323e927a83ac59fd0
>
>
> Diff: https://reviews.apache.org/r/71035/diff/1/
>
>
> Testing
> -------
>
> `make check`
> `sudo bin/mesos-tests.sh --gtest_filter="*ROOT_DOCKER_OverrideKillPolicy*" --gtest_repeat=-1 --gtest_break_on_failure`
>
> Verified that this new test fails on current master, and passes when the preceding patches in this chain are applied.
>
>
> Thanks,
>
> Greg Mann
>
>