[GitHub] [spark] dongjoon-hyun commented on a change in pull request #23945: [SPARK-27035][SQL] Get more precise current time

[GitBox <gi...@apache.org>]

dongjoon-hyun commented on a change in pull request #23945: [SPARK-27035][SQL] Get more precise current time
URL: https://github.com/apache/spark/pull/23945#discussion_r261887599
 
 

 ##########
 File path: docs/sql-migration-guide-upgrade.md
 ##########
 @@ -97,7 +97,9 @@ displayTitle: Spark SQL Upgrading Guide
 
     - the JDBC options `lowerBound` and `upperBound` are converted to TimestampType/DateType values in the same way as casting strings to TimestampType/DateType values. The conversion is based on Proleptic Gregorian calendar, and time zone defined by the SQL config `spark.sql.session.timeZone`. In Spark version 2.4 and earlier, the conversion is based on the hybrid calendar (Julian + Gregorian) and on default system time zone.
 
-  - In Spark version 2.4 and earlier, invalid time zone ids are silently ignored and replaced by GMT time zone, for example, in the from_utc_timestamp function. Since Spark 3.0, such time zone ids are rejected, and Spark throws `java.time.DateTimeException`. 
+  - In Spark version 2.4 and earlier, invalid time zone ids are silently ignored and replaced by GMT time zone, for example, in the from_utc_timestamp function. Since Spark 3.0, such time zone ids are rejected, and Spark throws `java.time.DateTimeException`.
+
 
 Review comment:
   @MaxGekk . The PR looks reasonable. BTW, did you change something in the above two lines? For me, it seems not. Could you update this PR to add the following line 102 only in this file?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org