You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by "Karthik K (Created) (JIRA)" <ji...@apache.org> on 2012/01/31 01:13:10 UTC
[jira] [Created] (HTTPCLIENT-1161) httpclient-cache:
RequestEquivalent # appendTo : make it take Appendable as opposed to
StringBuffer
httpclient-cache: RequestEquivalent # appendTo : make it take Appendable as opposed to StringBuffer
----------------------------------------------------------------------------------------------------
Key: HTTPCLIENT-1161
URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1161
Project: HttpComponents HttpClient
Issue Type: Improvement
Affects Versions: 4.2 Alpha1
Reporter: Karthik K
Priority: Minor
Fix For: 4.2 Final
Current signature, reads:
org/apache/http/impl/client/cache/RequestEquivalent.java:
public void appendTo(StringBuffer buf) {
Replace the signature with Appendable, to make it more generic and not tied to StringBuffer.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[jira] [Closed] (HTTPCLIENT-1161) httpclient-cache:
RequestEquivalent # appendTo : make it take Appendable as opposed to
StringBuffer
Posted by "Jon Moore (Closed) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HTTPCLIENT-1161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jon Moore closed HTTPCLIENT-1161.
---------------------------------
Resolution: Invalid
Assignee: Jon Moore
This method is part of the IArgumentMatcher interface from EasyMock:
http://easymock.org/api/easymock/3.1/org/easymock/IArgumentMatcher.html#appendTo(java.lang.StringBuffer)
Therefore, we're not able to make this change even if we wanted to.
Furthermore, this is a test class supporting the various unit tests in httpclient-cache, and hence not a part of the public API. I am in general a subscriber to YAGNI (You Ain't Gonna Need It) and resist premature generalization, particularly of test classes that are project-internal.
> httpclient-cache: RequestEquivalent # appendTo : make it take Appendable as opposed to StringBuffer
> ----------------------------------------------------------------------------------------------------
>
> Key: HTTPCLIENT-1161
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1161
> Project: HttpComponents HttpClient
> Issue Type: Improvement
> Affects Versions: 4.2 Alpha1
> Reporter: Karthik K
> Assignee: Jon Moore
> Priority: Minor
> Fix For: 4.2 Final
>
> Attachments: HTTPCLIENT-1161.patch
>
>
> Current signature, reads:
> org/apache/http/impl/client/cache/RequestEquivalent.java:
> public void appendTo(StringBuffer buf) {
> Replace the signature with Appendable, to make it more generic and not tied to StringBuffer.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[jira] [Commented] (HTTPCLIENT-1161) httpclient-cache:
RequestEquivalent # appendTo : make it take Appendable as opposed to
StringBuffer
Posted by "Sebb (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HTTPCLIENT-1161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13196571#comment-13196571 ]
Sebb commented on HTTPCLIENT-1161:
----------------------------------
We something similar in Commons (Lang, I think) and hit some problems.
One is that the Appendable interface throws IOException; cannot remember off-hand what (if any) other issues were found.
It may not be as simple as replacing the parameter type.
Also, changing a parameter type is not binary compatible, so we would need to keep the existing method at least for now.
> httpclient-cache: RequestEquivalent # appendTo : make it take Appendable as opposed to StringBuffer
> ----------------------------------------------------------------------------------------------------
>
> Key: HTTPCLIENT-1161
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1161
> Project: HttpComponents HttpClient
> Issue Type: Improvement
> Affects Versions: 4.2 Alpha1
> Reporter: Karthik K
> Priority: Minor
> Fix For: 4.2 Final
>
> Attachments: HTTPCLIENT-1161.patch
>
>
> Current signature, reads:
> org/apache/http/impl/client/cache/RequestEquivalent.java:
> public void appendTo(StringBuffer buf) {
> Replace the signature with Appendable, to make it more generic and not tied to StringBuffer.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[jira] [Updated] (HTTPCLIENT-1161) httpclient-cache:
RequestEquivalent # appendTo : make it take Appendable as opposed to
StringBuffer
Posted by "Karthik K (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HTTPCLIENT-1161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Karthik K updated HTTPCLIENT-1161:
----------------------------------
Attachment: HTTPCLIENT-1161.patch
> httpclient-cache: RequestEquivalent # appendTo : make it take Appendable as opposed to StringBuffer
> ----------------------------------------------------------------------------------------------------
>
> Key: HTTPCLIENT-1161
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1161
> Project: HttpComponents HttpClient
> Issue Type: Improvement
> Affects Versions: 4.2 Alpha1
> Reporter: Karthik K
> Priority: Minor
> Fix For: 4.2 Final
>
> Attachments: HTTPCLIENT-1161.patch
>
>
> Current signature, reads:
> org/apache/http/impl/client/cache/RequestEquivalent.java:
> public void appendTo(StringBuffer buf) {
> Replace the signature with Appendable, to make it more generic and not tied to StringBuffer.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org