[GitHub] [spark] zhouyejoe commented on a change in pull request #34018: [WIP][SPARK-36772] FinalizeShuffleMerge fails with an exception due to attempt id not matching

[GitBox <gi...@apache.org>]

zhouyejoe commented on a change in pull request #34018:
URL: https://github.com/apache/spark/pull/34018#discussion_r710681652



##########
File path: common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/BlockStoreClient.java
##########
@@ -46,6 +46,8 @@
 
   protected volatile TransportClientFactory clientFactory;
   protected String appId;
+  // Store the application attemptId
+  protected int appAttemptId;

Review comment:
       I actually keep the appAttemptId within BlockStoreClient and move the setAppAttemptId into the BlockStoreClient, as in BlockManager it only calls from BlockStoreClient, other than ExternalBlockStoreClient.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org