[GitHub] sijie commented on a change in pull request #231: Issue 230: Add Checkstyle to the build process (Part 1)

[gi...@git.apache.org]

sijie commented on a change in pull request #231: Issue 230: Add Checkstyle to the build process (Part 1)
URL: https://github.com/apache/bookkeeper/pull/231#discussion_r126549041
 
 

 ##########
 File path: bookkeeper-stats-providers/twitter-ostrich-provider/pom.xml
 ##########
 @@ -32,6 +32,38 @@
     <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
     <project.libdir>${basedir}/lib</project.libdir>
   </properties>
+  <build>
+    <plugins>
+      <plugin>
+        <groupId>org.apache.maven.plugins</groupId>
+        <artifactId>maven-checkstyle-plugin</artifactId>
 
 Review comment:
   " it is better to add checkstyle only those projects those are fixed. After every project finished, it can be moved to the root.
   In this way you can't left anything unchecked."
   
   +1
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services