[GitHub] [druid] somu-imply commented on a diff in pull request #13934: Unnest changes for moving the filter on right side of correlate to inside the unnest datasource

["somu-imply (via GitHub)" <gi...@apache.org>]

somu-imply commented on code in PR #13934:
URL: https://github.com/apache/druid/pull/13934#discussion_r1137776597


##########
processing/src/main/java/org/apache/druid/query/UnnestDataSource.java:
##########
@@ -172,14 +191,18 @@ public boolean equals(Object o)
       return false;
     }
     UnnestDataSource that = (UnnestDataSource) o;
-    return virtualColumn.equals(that.virtualColumn)
-           && base.equals(that.base);
+    if (unnestFilter != null) {
+      return virtualColumn.equals(that.virtualColumn) && unnestFilter.equals(that.unnestFilter)
+             && base.equals(that.base);
+    } else {
+      return virtualColumn.equals(that.virtualColumn) && base.equals(that.base);
+    }

Review Comment:
   yup, fixed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org