[GitHub] [airflow] uranusjr commented on a diff in pull request #26169: Auto tail file logs in Web UI

[GitBox <gi...@apache.org>]

uranusjr commented on code in PR #26169:
URL: https://github.com/apache/airflow/pull/26169#discussion_r963445277


##########
airflow/providers/microsoft/azure/log/wasb_task_handler.py:
##########
@@ -127,7 +129,7 @@ def _read(self, ti, try_number: int, metadata: Optional[str] = None) -> Tuple[st
             log = f'*** Reading remote log from {remote_loc}.\n{remote_log}\n'
             return log, {'end_of_log': True}
         else:
-            return super()._read(ti, try_number)
+            return super()._read(ti, try_number, metadata)

Review Comment:
   You need to support not passing `metadata` here, otherwise all provider log handlers would be incompatible with 2.3 (and below), which is not acceptable.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org