You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by we...@apache.org on 2017/02/06 15:10:17 UTC
spark git commit: [SPARK-17213][SQL][FOLLOWUP] Re-enable Parquet
filter tests for binary and string
Repository: spark
Updated Branches:
refs/heads/master 7beb227cc -> 0f16ff5b0
[SPARK-17213][SQL][FOLLOWUP] Re-enable Parquet filter tests for binary and string
## What changes were proposed in this pull request?
This PR proposes to enable the tests for Parquet filter pushdown with binary and string.
This was disabled in https://github.com/apache/spark/pull/16106 due to Parquet's issue but it is now revived in https://github.com/apache/spark/pull/16791 after upgrading Parquet to 1.8.2.
## How was this patch tested?
Manually tested `ParquetFilterSuite` via IDE.
Author: hyukjinkwon <gu...@gmail.com>
Closes #16817 from HyukjinKwon/SPARK-17213.
Project: http://git-wip-us.apache.org/repos/asf/spark/repo
Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/0f16ff5b
Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/0f16ff5b
Diff: http://git-wip-us.apache.org/repos/asf/spark/diff/0f16ff5b
Branch: refs/heads/master
Commit: 0f16ff5b0ec8cd828774ba5ddb276d7b06dbe273
Parents: 7beb227
Author: hyukjinkwon <gu...@gmail.com>
Authored: Mon Feb 6 23:10:05 2017 +0800
Committer: Wenchen Fan <we...@databricks.com>
Committed: Mon Feb 6 23:10:05 2017 +0800
----------------------------------------------------------------------
.../sql/execution/datasources/parquet/ParquetFilterSuite.scala | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/spark/blob/0f16ff5b/sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFilterSuite.scala
----------------------------------------------------------------------
diff --git a/sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFilterSuite.scala b/sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFilterSuite.scala
index fa046c8..9a3328f 100644
--- a/sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFilterSuite.scala
+++ b/sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFilterSuite.scala
@@ -229,8 +229,7 @@ class ParquetFilterSuite extends QueryTest with ParquetTest with SharedSQLContex
}
}
- // See SPARK-17213: https://issues.apache.org/jira/browse/SPARK-17213
- ignore("filter pushdown - string") {
+ test("filter pushdown - string") {
withParquetDataFrame((1 to 4).map(i => Tuple1(i.toString))) { implicit df =>
checkFilterPredicate('_1.isNull, classOf[Eq[_]], Seq.empty[Row])
checkFilterPredicate(
@@ -258,8 +257,7 @@ class ParquetFilterSuite extends QueryTest with ParquetTest with SharedSQLContex
}
}
- // See SPARK-17213: https://issues.apache.org/jira/browse/SPARK-17213
- ignore("filter pushdown - binary") {
+ test("filter pushdown - binary") {
implicit class IntToBinary(int: Int) {
def b: Array[Byte] = int.toString.getBytes(StandardCharsets.UTF_8)
}
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org