You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/09/02 20:38:57 UTC

[GitHub] [cloudstack] shwstppr opened a new pull request, #6696: kvm: add virsh capabilities method for cpu speed retrieval

shwstppr opened a new pull request, #6696:
URL: https://github.com/apache/cloudstack/pull/6696

   ### Description
   
   Fixes #6680
   
   While finding CPU speed for KVM host following methods will be used in the same order:
   1. lscpu
   2. value in /sys/devices/system/cpu/cpu0/cpufreq/base_frequency
   3. virsh capabilities
   4. libvirt nodeinfo
   
   This will allow the correct value for AMD-based hosts when the first two methods don't give a value
   
   ### Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [x] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ### Feature/Enhancement Scale or Bug Severity
   
   #### Feature/Enhancement Scale
   
   - [ ] Major
   - [ ] Minor
   
   #### Bug Severity
   
   - [ ] BLOCKER
   - [ ] Critical
   - [ ] Major
   - [ ] Minor
   - [ ] Trivial
   
   
   ### Screenshots (if appropriate):
   
   
   ### How Has This Been Tested?
   <!-- Please describe in detail how you tested your changes. -->
   <!-- Include details of your testing environment, and the tests you ran to -->
   <!-- see how your change affects other areas of the code, etc. -->
   
   
   <!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #6696: kvm: add virsh capabilities method for cpu speed retrieval

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6696:
URL: https://github.com/apache/cloudstack/pull/6696#issuecomment-1235881895

   @shwstppr a Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] shwstppr commented on pull request #6696: kvm: add libvirt host capabilities method for cpu speed retrieval

Posted by GitBox <gi...@apache.org>.
shwstppr commented on PR #6696:
URL: https://github.com/apache/cloudstack/pull/6696#issuecomment-1237878196

   @rohityadavcloud tested centos7, rocky8 and Ubuntu on Intel and AMD servers. On Intel mostly code won't need to get speed from host capabilities as lscpu method will return it. But I've checked it returns the same value.
   
   **CentOS7 - Intel**
   ```
   [root@pr6696-t4825-kvm-centos7-kvm1 ~]# virsh capabilities
   <capabilities>
   
     <host>
       <uuid>203e0e42-61ac-c0f9-facd-7302b61f2166</uuid>
       <cpu>
         <arch>x86_64</arch>
         <model>Broadwell-noTSX-IBRS</model>
         <vendor>Intel</vendor>
         <microcode version='83898371'/>
         <counter name='tsc' frequency='2100000000' scaling='no'/>
   ```
   
   ```
   2022-09-06 08:51:23,526 INFO  [utils.nio.NioClient] (main:null) (logid:) Connected to 10.0.33.0:8250
   2022-09-06 08:51:23,545 INFO  [utils.linux.KVMHostInfo] (Agent-Handler-1:null) (logid:) Fetching CPU speed from command "lscpu".
   2022-09-06 08:51:23,559 INFO  [utils.linux.KVMHostInfo] (Agent-Handler-1:null) (logid:) Command [lscpu | grep -i 'Model name' | head -n 1 | egrep -o '[[:digit:]].[[:digit:]]+GHz' | sed 's/GHz//g'] resulted in the value [2100] for CPU speed.
   ```
   
   **Rocky8 - Intel**
   ```
   [root@pr6696-t4823-kvm-rocky8-kvm1 ~]# virsh capabilities
   <capabilities>
   
     <host>
       <uuid>9fc50e42-65f7-be8a-cd44-641597cfa587</uuid>
       <cpu>
         <arch>x86_64</arch>
         <model>Broadwell-noTSX-IBRS</model>
         <vendor>Intel</vendor>
         <microcode version='83898371'/>
         <counter name='tsc' frequency='2099999000' scaling='no'/>
   ```
   
   ```
   2022-09-06 08:48:42,283 INFO  [utils.nio.NioClient] (main:null) (logid:) Connected to 10.0.33.110:8250
   2022-09-06 08:48:42,300 INFO  [utils.linux.KVMHostInfo] (Agent-Handler-1:null) (logid:) Fetching CPU speed from command "lscpu".
   2022-09-06 08:48:42,314 INFO  [utils.linux.KVMHostInfo] (Agent-Handler-1:null) (logid:) Command [lscpu | grep -i 'Model name' | head -n 1 | egrep -o '[[:digit:]].[[:digit:]]+GHz' | sed 's/GHz//g'] resulted in the value [2100] for CPU speed.
   ```
   
   **Ubuntu20 - Intel**
   ```
   root@pr6696-t4824-kvm-ubuntu20-kvm1:~# virsh capabilities
   <capabilities>
   
     <host>
       <uuid>3b010e42-d42c-2f3f-7125-fb2e186d4396</uuid>
       <cpu>
         <arch>x86_64</arch>
         <model>Broadwell-noTSX-IBRS</model>
         <vendor>Intel</vendor>
         <microcode version='83898371'/>
         <counter name='tsc' frequency='2100001000' scaling='no'/>
   ```
   
   ```
   2022-09-06 08:53:38,370 INFO  [utils.nio.NioClient] (main:null) (logid:) Connected to 10.0.34.7:8250
   2022-09-06 08:53:38,386 INFO  [utils.linux.KVMHostInfo] (Agent-Handler-1:null) (logid:) Fetching CPU speed from command "lscpu".
   2022-09-06 08:53:38,396 INFO  [utils.linux.KVMHostInfo] (Agent-Handler-1:null) (logid:) Command [lscpu | grep -i 'Model name' | head -n 1 | egrep -o '[[:digit:]].[[:digit:]]+GHz' | sed 's/GHz//g'] resulted in the value [2100] for CPU speed.
   ```
   
   **CentOS7 - AMD**
   ```
   [root@pr6696-t3-kvm-centos7-kvm1 ~]# virsh capabilities
   <capabilities>
   
     <host>
       <uuid>dd140742-568f-434b-246f-febf41f6d016</uuid>
       <cpu>
         <arch>x86_64</arch>
         <model>Opteron_G2</model>
         <vendor>AMD</vendor>
         <microcode version='137367589'/>
         <counter name='tsc' frequency='2350000000' scaling='no'/>
   ```
   
   ```
   2022-09-06 09:02:53,800 INFO  [utils.nio.NioClient] (main:null) (logid:) Connected to 10.1.35.226:8250
   2022-09-06 09:02:53,813 INFO  [utils.linux.KVMHostInfo] (Agent-Handler-1:null) (logid:) Fetching CPU speed from command "lscpu".
   2022-09-06 09:02:53,831 ERROR [utils.linux.KVMHostInfo] (Agent-Handler-1:null) (logid:) Unable to retrieve the CPU speed from lscpu.
   java.lang.NullPointerException
   	at java.base/jdk.internal.math.FloatingDecimal.readJavaFormatString(FloatingDecimal.java:1838)
   	at java.base/jdk.internal.math.FloatingDecimal.parseFloat(FloatingDecimal.java:122)
   	at java.base/java.lang.Float.parseFloat(Float.java:455)
   	at org.apache.cloudstack.utils.linux.KVMHostInfo.getCpuSpeedFromCommandLscpu(KVMHostInfo.java:124)
   	at org.apache.cloudstack.utils.linux.KVMHostInfo.getCpuSpeed(KVMHostInfo.java:99)
   	at org.apache.cloudstack.utils.linux.KVMHostInfo.getHostInfoFromLibvirt(KVMHostInfo.java:179)
   	at org.apache.cloudstack.utils.linux.KVMHostInfo.<init>(KVMHostInfo.java:65)
   	at com.cloud.hypervisor.kvm.resource.LibvirtComputingResource.initialize(LibvirtComputingResource.java:3376)
   	at com.cloud.agent.Agent.sendStartup(Agent.java:441)
   	at com.cloud.agent.Agent$ServerHandler.doTask(Agent.java:1099)
   	at com.cloud.utils.nio.Task.call(Task.java:83)
   	at com.cloud.utils.nio.Task.call(Task.java:29)
   	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
   	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
   	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
   	at java.base/java.lang.Thread.run(Thread.java:829)
   2022-09-06 09:02:53,833 INFO  [utils.linux.KVMHostInfo] (Agent-Handler-1:null) (logid:) Fetching CPU speed from file [/sys/devices/system/cpu/cpu0/cpufreq/base_frequency].
   2022-09-06 09:02:53,833 ERROR [utils.linux.KVMHostInfo] (Agent-Handler-1:null) (logid:) Unable to retrieve the CPU speed from file [/sys/devices/system/cpu/cpu0/cpufreq/base_frequency]
   java.io.FileNotFoundException: /sys/devices/system/cpu/cpu0/cpufreq/base_frequency (No such file or directory)
   	at java.base/java.io.FileInputStream.open0(Native Method)
   	at java.base/java.io.FileInputStream.open(FileInputStream.java:219)
   	at java.base/java.io.FileInputStream.<init>(FileInputStream.java:157)
   	at java.base/java.io.FileInputStream.<init>(FileInputStream.java:112)
   	at java.base/java.io.FileReader.<init>(FileReader.java:60)
   	at org.apache.cloudstack.utils.linux.KVMHostInfo.getCpuSpeedFromFile(KVMHostInfo.java:135)
   	at org.apache.cloudstack.utils.linux.KVMHostInfo.getCpuSpeed(KVMHostInfo.java:104)
   	at org.apache.cloudstack.utils.linux.KVMHostInfo.getHostInfoFromLibvirt(KVMHostInfo.java:179)
   	at org.apache.cloudstack.utils.linux.KVMHostInfo.<init>(KVMHostInfo.java:65)
   	at com.cloud.hypervisor.kvm.resource.LibvirtComputingResource.initialize(LibvirtComputingResource.java:3376)
   	at com.cloud.agent.Agent.sendStartup(Agent.java:441)
   	at com.cloud.agent.Agent$ServerHandler.doTask(Agent.java:1099)
   	at com.cloud.utils.nio.Task.call(Task.java:83)
   	at com.cloud.utils.nio.Task.call(Task.java:29)
   	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
   	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
   	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
   	at java.base/java.lang.Thread.run(Thread.java:829)
   2022-09-06 09:02:53,834 INFO  [utils.linux.KVMHostInfo] (Agent-Handler-1:null) (logid:) Fetching CPU speed from "host capabilities"
   2022-09-06 09:02:53,844 INFO  [utils.linux.KVMHostInfo] (Agent-Handler-1:null) (logid:) Retrieved value [2350000000] from "host capabilities". This corresponds to a CPU speed of [2350] MHz.
   ```
   
   **Rocky8 - AMD**
   ```
   [root@pr6696-t4-kvm-rocky8-kvm1 ~]# virsh capabilities
   <capabilities>
   
     <host>
       <uuid>5b8a0742-de56-d3b3-633e-47f70d470648</uuid>
       <cpu>
         <arch>x86_64</arch>
         <model>Opteron_G3</model>
         <vendor>AMD</vendor>
         <microcode version='137367580'/>
         <counter name='tsc' frequency='2350000000' scaling='no'/>
   ```
   
   ```
   2022-09-06 09:06:47,536 INFO  [utils.nio.NioClient] (main:null) (logid:) Connected to 10.1.33.146:8250
   2022-09-06 09:06:47,557 INFO  [utils.linux.KVMHostInfo] (Agent-Handler-1:null) (logid:) Fetching CPU speed from command "lscpu".
   2022-09-06 09:06:47,565 ERROR [utils.linux.KVMHostInfo] (Agent-Handler-1:null) (logid:) Unable to retrieve the CPU speed from lscpu.
   java.lang.NullPointerException
   	at java.base/jdk.internal.math.FloatingDecimal.readJavaFormatString(FloatingDecimal.java:1838)
   	at java.base/jdk.internal.math.FloatingDecimal.parseFloat(FloatingDecimal.java:122)
   	at java.base/java.lang.Float.parseFloat(Float.java:455)
   	at org.apache.cloudstack.utils.linux.KVMHostInfo.getCpuSpeedFromCommandLscpu(KVMHostInfo.java:124)
   	at org.apache.cloudstack.utils.linux.KVMHostInfo.getCpuSpeed(KVMHostInfo.java:99)
   	at org.apache.cloudstack.utils.linux.KVMHostInfo.getHostInfoFromLibvirt(KVMHostInfo.java:179)
   	at org.apache.cloudstack.utils.linux.KVMHostInfo.<init>(KVMHostInfo.java:65)
   	at com.cloud.hypervisor.kvm.resource.LibvirtComputingResource.initialize(LibvirtComputingResource.java:3376)
   	at com.cloud.agent.Agent.sendStartup(Agent.java:441)
   	at com.cloud.agent.Agent$ServerHandler.doTask(Agent.java:1099)
   	at com.cloud.utils.nio.Task.call(Task.java:83)
   	at com.cloud.utils.nio.Task.call(Task.java:29)
   	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
   	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
   	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
   	at java.base/java.lang.Thread.run(Thread.java:829)
   2022-09-06 09:06:47,567 INFO  [utils.linux.KVMHostInfo] (Agent-Handler-1:null) (logid:) Fetching CPU speed from file [/sys/devices/system/cpu/cpu0/cpufreq/base_frequency].
   2022-09-06 09:06:47,567 ERROR [utils.linux.KVMHostInfo] (Agent-Handler-1:null) (logid:) Unable to retrieve the CPU speed from file [/sys/devices/system/cpu/cpu0/cpufreq/base_frequency]
   java.io.FileNotFoundException: /sys/devices/system/cpu/cpu0/cpufreq/base_frequency (No such file or directory)
   	at java.base/java.io.FileInputStream.open0(Native Method)
   	at java.base/java.io.FileInputStream.open(FileInputStream.java:219)
   	at java.base/java.io.FileInputStream.<init>(FileInputStream.java:157)
   	at java.base/java.io.FileInputStream.<init>(FileInputStream.java:112)
   	at java.base/java.io.FileReader.<init>(FileReader.java:60)
   	at org.apache.cloudstack.utils.linux.KVMHostInfo.getCpuSpeedFromFile(KVMHostInfo.java:135)
   	at org.apache.cloudstack.utils.linux.KVMHostInfo.getCpuSpeed(KVMHostInfo.java:104)
   	at org.apache.cloudstack.utils.linux.KVMHostInfo.getHostInfoFromLibvirt(KVMHostInfo.java:179)
   	at org.apache.cloudstack.utils.linux.KVMHostInfo.<init>(KVMHostInfo.java:65)
   	at com.cloud.hypervisor.kvm.resource.LibvirtComputingResource.initialize(LibvirtComputingResource.java:3376)
   	at com.cloud.agent.Agent.sendStartup(Agent.java:441)
   	at com.cloud.agent.Agent$ServerHandler.doTask(Agent.java:1099)
   	at com.cloud.utils.nio.Task.call(Task.java:83)
   	at com.cloud.utils.nio.Task.call(Task.java:29)
   	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
   	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
   	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
   	at java.base/java.lang.Thread.run(Thread.java:829)
   2022-09-06 09:06:47,568 INFO  [utils.linux.KVMHostInfo] (Agent-Handler-1:null) (logid:) Fetching CPU speed from "host capabilities"
   2022-09-06 09:06:47,574 INFO  [utils.linux.KVMHostInfo] (Agent-Handler-1:null) (logid:) Retrieved value [2350000000] from "host capabilities". This corresponds to a CPU speed of [2350] MHz.
   ```
   
   **Ubuntu20 - AMD**
   ```
   root@pr6696-t5-kvm-ubuntu20-kvm1:~# virsh capabilities
   <capabilities>
   
     <host>
       <uuid>86ea0742-baff-6b0a-1261-b849ace1a53b</uuid>
       <cpu>
         <arch>x86_64</arch>
         <model>Opteron_G2</model>
         <vendor>AMD</vendor>
         <microcode version='137367580'/>
         <counter name='tsc' frequency='2350002000' scaling='no'/>
   ```
   
   ```
   2022-09-06 09:04:51,125 INFO  [utils.nio.NioClient] (main:null) (logid:) Connected to 10.1.35.181:8250
   2022-09-06 09:04:51,137 INFO  [utils.linux.KVMHostInfo] (Agent-Handler-1:null) (logid:) Fetching CPU speed from command "lscpu".
   2022-09-06 09:04:51,150 ERROR [utils.linux.KVMHostInfo] (Agent-Handler-1:null) (logid:) Unable to retrieve the CPU speed from lscpu.
   java.lang.NullPointerException
   	at java.base/jdk.internal.math.FloatingDecimal.readJavaFormatString(FloatingDecimal.java:1838)
   	at java.base/jdk.internal.math.FloatingDecimal.parseFloat(FloatingDecimal.java:122)
   	at java.base/java.lang.Float.parseFloat(Float.java:455)
   	at org.apache.cloudstack.utils.linux.KVMHostInfo.getCpuSpeedFromCommandLscpu(KVMHostInfo.java:124)
   	at org.apache.cloudstack.utils.linux.KVMHostInfo.getCpuSpeed(KVMHostInfo.java:99)
   	at org.apache.cloudstack.utils.linux.KVMHostInfo.getHostInfoFromLibvirt(KVMHostInfo.java:179)
   	at org.apache.cloudstack.utils.linux.KVMHostInfo.<init>(KVMHostInfo.java:65)
   	at com.cloud.hypervisor.kvm.resource.LibvirtComputingResource.initialize(LibvirtComputingResource.java:3376)
   	at com.cloud.agent.Agent.sendStartup(Agent.java:441)
   	at com.cloud.agent.Agent$ServerHandler.doTask(Agent.java:1099)
   	at com.cloud.utils.nio.Task.call(Task.java:83)
   	at com.cloud.utils.nio.Task.call(Task.java:29)
   	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
   	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
   	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
   	at java.base/java.lang.Thread.run(Thread.java:829)
   2022-09-06 09:04:51,154 INFO  [utils.linux.KVMHostInfo] (Agent-Handler-1:null) (logid:) Fetching CPU speed from file [/sys/devices/system/cpu/cpu0/cpufreq/base_frequency].
   2022-09-06 09:04:51,154 ERROR [utils.linux.KVMHostInfo] (Agent-Handler-1:null) (logid:) Unable to retrieve the CPU speed from file [/sys/devices/system/cpu/cpu0/cpufreq/base_frequency]
   java.io.FileNotFoundException: /sys/devices/system/cpu/cpu0/cpufreq/base_frequency (No such file or directory)
   	at java.base/java.io.FileInputStream.open0(Native Method)
   	at java.base/java.io.FileInputStream.open(FileInputStream.java:219)
   	at java.base/java.io.FileInputStream.<init>(FileInputStream.java:157)
   	at java.base/java.io.FileInputStream.<init>(FileInputStream.java:112)
   	at java.base/java.io.FileReader.<init>(FileReader.java:60)
   	at org.apache.cloudstack.utils.linux.KVMHostInfo.getCpuSpeedFromFile(KVMHostInfo.java:135)
   	at org.apache.cloudstack.utils.linux.KVMHostInfo.getCpuSpeed(KVMHostInfo.java:104)
   	at org.apache.cloudstack.utils.linux.KVMHostInfo.getHostInfoFromLibvirt(KVMHostInfo.java:179)
   	at org.apache.cloudstack.utils.linux.KVMHostInfo.<init>(KVMHostInfo.java:65)
   	at com.cloud.hypervisor.kvm.resource.LibvirtComputingResource.initialize(LibvirtComputingResource.java:3376)
   	at com.cloud.agent.Agent.sendStartup(Agent.java:441)
   	at com.cloud.agent.Agent$ServerHandler.doTask(Agent.java:1099)
   	at com.cloud.utils.nio.Task.call(Task.java:83)
   	at com.cloud.utils.nio.Task.call(Task.java:29)
   	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
   	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
   	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
   	at java.base/java.lang.Thread.run(Thread.java:829)
   2022-09-06 09:04:51,155 INFO  [utils.linux.KVMHostInfo] (Agent-Handler-1:null) (logid:) Fetching CPU speed from "host capabilities"
   2022-09-06 09:04:51,171 INFO  [utils.linux.KVMHostInfo] (Agent-Handler-1:null) (logid:) Retrieved value [2350002000] from "host capabilities". This corresponds to a CPU speed of [2350] MHz.
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] shwstppr commented on pull request #6696: kvm: add libvirt host capabilities method for cpu speed retrieval

Posted by GitBox <gi...@apache.org>.
shwstppr commented on PR #6696:
URL: https://github.com/apache/cloudstack/pull/6696#issuecomment-1237898735

   > Can we add a unit test with an example output? Would the speed be retrieved independently of the version?
   
   @nvazquez added test. Refactored code to use java lib so version shouldn't affect. Also, tested different combinations as reported above


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #6696: kvm: add virsh capabilities method for cpu speed retrieval

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6696:
URL: https://github.com/apache/cloudstack/pull/6696#issuecomment-1236357397

   @rohityadavcloud a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #6696: kvm: add libvirt host capabilities method for cpu speed retrieval

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6696:
URL: https://github.com/apache/cloudstack/pull/6696#issuecomment-1237386766

   Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 4128


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] shwstppr merged pull request #6696: kvm: add libvirt host capabilities method for cpu speed retrieval

Posted by GitBox <gi...@apache.org>.
shwstppr merged PR #6696:
URL: https://github.com/apache/cloudstack/pull/6696


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #6696: kvm: add virsh capabilities method for cpu speed retrieval

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6696:
URL: https://github.com/apache/cloudstack/pull/6696#issuecomment-1237365172

   @shwstppr a Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #6696: kvm: add libvirt host capabilities method for cpu speed retrieval

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6696:
URL: https://github.com/apache/cloudstack/pull/6696#issuecomment-1237721845

   <b>Trillian test result (tid-4819)</b>
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 39502 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6696-t4819-kvm-centos7.zip
   Smoke tests completed. 100 look OK, 1 have errors
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_08_upgrade_kubernetes_ha_cluster | `Failure` | 551.95 | test_kubernetes_clusters.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] shwstppr commented on pull request #6696: kvm: add virsh capabilities method for cpu speed retrieval

Posted by GitBox <gi...@apache.org>.
shwstppr commented on PR #6696:
URL: https://github.com/apache/cloudstack/pull/6696#issuecomment-1236926416

   Moving to draft for now. Code could have written with `Connect::getCapabilities` instead of calling bash script. Will refactor.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6696: kvm: add libvirt host capabilities method for cpu speed retrieval

Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #6696:
URL: https://github.com/apache/cloudstack/pull/6696#issuecomment-1237398467

   SonarCloud Quality Gate failed.&nbsp; &nbsp; [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate failed')](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=6696)
   
   [![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png 'Bug')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6696&resolved=false&types=BUG) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6696&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6696&resolved=false&types=BUG)  
   [![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png 'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6696&resolved=false&types=VULNERABILITY) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6696&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6696&resolved=false&types=VULNERABILITY)  
   [![Security Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png 'Security Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6696&resolved=false&types=SECURITY_HOTSPOT) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6696&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6696&resolved=false&types=SECURITY_HOTSPOT)  
   [![Code Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png 'Code Smell')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6696&resolved=false&types=CODE_SMELL) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6696&resolved=false&types=CODE_SMELL) [1 Code Smell](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6696&resolved=false&types=CODE_SMELL)
   
   [![54.4%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/50-16px.png '54.4%')](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6696&metric=new_coverage&view=list) [54.4% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6696&metric=new_coverage&view=list)  
   [![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png '0.0%')](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6696&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6696&metric=new_duplicated_lines_density&view=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #6696: kvm: add virsh capabilities method for cpu speed retrieval

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6696:
URL: https://github.com/apache/cloudstack/pull/6696#issuecomment-1236046148

   <b>Trillian Build Failed (tid-4812)<b/>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] shwstppr commented on pull request #6696: kvm: add libvirt host capabilities method for cpu speed retrieval

Posted by GitBox <gi...@apache.org>.
shwstppr commented on PR #6696:
URL: https://github.com/apache/cloudstack/pull/6696#issuecomment-1238012153

   Merging based on LGTM, smoke test results and manual tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #6696: kvm: add libvirt host capabilities method for cpu speed retrieval

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6696:
URL: https://github.com/apache/cloudstack/pull/6696#issuecomment-1237405311

   @shwstppr a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] shwstppr commented on pull request #6696: kvm: add virsh capabilities method for cpu speed retrieval

Posted by GitBox <gi...@apache.org>.
shwstppr commented on PR #6696:
URL: https://github.com/apache/cloudstack/pull/6696#issuecomment-1235881409

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #6696: kvm: add libvirt host capabilities method for cpu speed retrieval

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6696:
URL: https://github.com/apache/cloudstack/pull/6696#issuecomment-1237454898

   <b>Trillian test result (tid-4815)</b>
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 46000 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6696-t4815-kvm-centos7.zip
   Smoke tests completed. 99 look OK, 2 have errors
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_08_upgrade_kubernetes_ha_cluster | `Failure` | 650.99 | test_kubernetes_clusters.py
   test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Failure` | 457.48 | test_vpc_redundant.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] codecov[bot] commented on pull request #6696: kvm: add virsh capabilities method for cpu speed retrieval

Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #6696:
URL: https://github.com/apache/cloudstack/pull/6696#issuecomment-1235941474

   # [Codecov](https://codecov.io/gh/apache/cloudstack/pull/6696?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#6696](https://codecov.io/gh/apache/cloudstack/pull/6696?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3fece73) into [4.17](https://codecov.io/gh/apache/cloudstack/commit/c290cbcb71e80910c4ef22149803d758f13afbc6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c290cbc) will **decrease** coverage by `0.00%`.
   > The diff coverage is `0.00%`.
   
   ```diff
   @@             Coverage Diff              @@
   ##               4.17    #6696      +/-   ##
   ============================================
   - Coverage      5.87%    5.87%   -0.01%     
     Complexity     3928     3928              
   ============================================
     Files          2451     2451              
     Lines        242312   242344      +32     
     Branches      37920    37923       +3     
   ============================================
     Hits          14239    14239              
   - Misses       226499   226531      +32     
     Partials       1574     1574              
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/cloudstack/pull/6696?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...org/apache/cloudstack/utils/linux/KVMHostInfo.java](https://codecov.io/gh/apache/cloudstack/pull/6696/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy9oeXBlcnZpc29ycy9rdm0vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Nsb3Vkc3RhY2svdXRpbHMvbGludXgvS1ZNSG9zdEluZm8uamF2YQ==) | `34.00% <0.00%> (-16.00%)` | :arrow_down: |
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #6696: kvm: add virsh capabilities method for cpu speed retrieval

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6696:
URL: https://github.com/apache/cloudstack/pull/6696#issuecomment-1236044886

   @rohityadavcloud a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rohityadavcloud commented on pull request #6696: kvm: add libvirt host capabilities method for cpu speed retrieval

Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on PR #6696:
URL: https://github.com/apache/cloudstack/pull/6696#issuecomment-1237886550

   On the NPE causing code, can you add a check to see if the file exists before trying to read it @shwstppr ? Rest LGTM, let's merge when you're satisfied.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #6696: kvm: add libvirt host capabilities method for cpu speed retrieval

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6696:
URL: https://github.com/apache/cloudstack/pull/6696#issuecomment-1237795090

   Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. LL-JID 157


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6696: kvm: add virsh capabilities method for cpu speed retrieval

Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #6696:
URL: https://github.com/apache/cloudstack/pull/6696#issuecomment-1235918538

   SonarCloud Quality Gate failed.&nbsp; &nbsp; [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate failed')](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=6696)
   
   [![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png 'Bug')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6696&resolved=false&types=BUG) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6696&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6696&resolved=false&types=BUG)  
   [![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png 'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6696&resolved=false&types=VULNERABILITY) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6696&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6696&resolved=false&types=VULNERABILITY)  
   [![Security Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png 'Security Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6696&resolved=false&types=SECURITY_HOTSPOT) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6696&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6696&resolved=false&types=SECURITY_HOTSPOT)  
   [![Code Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png 'Code Smell')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6696&resolved=false&types=CODE_SMELL) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6696&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6696&resolved=false&types=CODE_SMELL)
   
   [![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/0-16px.png '0.0%')](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6696&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6696&metric=new_coverage&view=list)  
   [![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png '0.0%')](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6696&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6696&metric=new_duplicated_lines_density&view=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rohityadavcloud commented on pull request #6696: kvm: add virsh capabilities method for cpu speed retrieval

Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on PR #6696:
URL: https://github.com/apache/cloudstack/pull/6696#issuecomment-1236044822

   @blueorangutan test 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rohityadavcloud commented on pull request #6696: kvm: add virsh capabilities method for cpu speed retrieval

Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on PR #6696:
URL: https://github.com/apache/cloudstack/pull/6696#issuecomment-1236357319

   
   @blueorangutan test
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] shwstppr commented on pull request #6696: kvm: add libvirt host capabilities method for cpu speed retrieval

Posted by GitBox <gi...@apache.org>.
shwstppr commented on PR #6696:
URL: https://github.com/apache/cloudstack/pull/6696#issuecomment-1237897230

   @rohityadavcloud these exceptions don't affect the behaviour. Code moves to the next methods to retrieve CPU speed


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] shwstppr commented on pull request #6696: kvm: add virsh capabilities method for cpu speed retrieval

Posted by GitBox <gi...@apache.org>.
shwstppr commented on PR #6696:
URL: https://github.com/apache/cloudstack/pull/6696#issuecomment-1237364946

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] shwstppr commented on pull request #6696: kvm: add libvirt host capabilities method for cpu speed retrieval

Posted by GitBox <gi...@apache.org>.
shwstppr commented on PR #6696:
URL: https://github.com/apache/cloudstack/pull/6696#issuecomment-1237405064

   @blueorangutan test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #6696: kvm: add virsh capabilities method for cpu speed retrieval

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6696:
URL: https://github.com/apache/cloudstack/pull/6696#issuecomment-1235907557

   Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 4119


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org