You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/06/13 01:28:50 UTC
[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #36847: [SPARK-39448][SQL] Add `ReplaceCTERefWithRepartition` into `nonExcludableRules` list
dongjoon-hyun commented on code in PR #36847:
URL: https://github.com/apache/spark/pull/36847#discussion_r895265570
##########
sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala:
##########
@@ -4456,6 +4456,20 @@ class SQLQuerySuite extends QueryTest with SharedSparkSession with AdaptiveSpark
""".stripMargin),
Seq(Row(2), Row(1)))
}
+
+ test("SPARK-39448: Add ReplaceCTERefWithRepartition into nonExcludableRules list") {
Review Comment:
A question. Is it inevitable for us to have this?
As you know, we recommend `SQLQueryTestSuite` over `SQLQuerySuite` in these days, @wangyum ?
##########
sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala:
##########
@@ -4456,6 +4456,20 @@ class SQLQuerySuite extends QueryTest with SharedSparkSession with AdaptiveSpark
""".stripMargin),
Seq(Row(2), Row(1)))
}
+
+ test("SPARK-39448: Add ReplaceCTERefWithRepartition into nonExcludableRules list") {
Review Comment:
A question. Is it inevitable for us to have this here?
As you know, we recommend `SQLQueryTestSuite` over `SQLQuerySuite` in these days, @wangyum ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org