You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "rluvaton (via GitHub)" <gi...@apache.org> on 2025/01/07 22:44:23 UTC
[PR] allow to override Base(Large)RepeatedValueViewVector [arrow-java]
rluvaton opened a new pull request, #488:
URL: https://github.com/apache/arrow-java/pull/488
This is done as different arrow implementation have different default list item field name
For example, Rust implementation of Arrow (`arrow-rs`) has default value of `item` (https://github.com/apache/arrow-rs/blob/4f1f6e57c568fae8233ab9da7d7c7acdaea4112a/arrow-schema/src/field.rs#L125).
And according to the specification, the name of the list is not required to be a specific string. so to make it easier to use Java Arrow implementation with other implementation of Arrow, I'm making the `DATA_VECTOR_NAME` configurable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] allow to override Base(Large)RepeatedValueViewVector [arrow-java]
Posted by "rluvaton (via GitHub)" <gi...@apache.org>.
rluvaton commented on PR #488:
URL: https://github.com/apache/arrow-java/pull/488#issuecomment-2576441560
But it can still be too late, is there a way to change a field (or field name) of existing list?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] allow to override Base(Large)RepeatedValueViewVector [arrow-java]
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on PR #488:
URL: https://github.com/apache/arrow-java/pull/488#issuecomment-2576445692
Do you have a sample to show the scenario you are concerned about?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] allow to override Base(Large)RepeatedValueViewVector [arrow-java]
Posted by "rluvaton (via GitHub)" <gi...@apache.org>.
rluvaton commented on PR #488:
URL: https://github.com/apache/arrow-java/pull/488#issuecomment-2576429007
> I think it'd make more sense to allow changing `defaultDataVectorName` for an instance? I'm not a big fan of mutable globals
Changing `defaultDataVectorName` for an instance is too late, no? as the instance already created
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] allow to override Base(Large)RepeatedValueViewVector [arrow-java]
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on PR #488:
URL: https://github.com/apache/arrow-java/pull/488#issuecomment-2576445369
I don't see how a mutable global lets you change the name of an existing list either, though.
Once the child is created I think you'd have to recreate the child instead of being able to mutate the name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] allow to override Base(Large)RepeatedValueViewVector [arrow-java]
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on PR #488:
URL: https://github.com/apache/arrow-java/pull/488#issuecomment-2576432419
The child vector is created lazily, though
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org